Received: by 2002:a05:6a10:8c0a:0:0:0:0 with SMTP id go10csp1464272pxb; Fri, 26 Feb 2021 11:18:52 -0800 (PST) X-Google-Smtp-Source: ABdhPJzhUYODs1awsFDVAP4BC91NuKS1qESz0SyCTk+M7KIhG3CkFlVNOI2g5EOe6qKeYB9TmsZS X-Received: by 2002:a17:906:4c56:: with SMTP id d22mr5234151ejw.426.1614367131988; Fri, 26 Feb 2021 11:18:51 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1614367131; cv=none; d=google.com; s=arc-20160816; b=BNb7sXS9+txr9BvRI3Oz1Maa4/gEj2OzzTwtuhPm1F4IQpKNiy27MNGeuCq6wdWlxT B7BNZ8/keKktHTUXEu3ZIeYS6RKPyvWXOtOARQ/ThhuobA7G5qqReAGVyfFa1KjxAbMV eJpp2pqbXuQelj9l/AxgXF/yzkYcJYjQE5VcjG6p21sKIJnzALVlfnFb+LI0x3CiHqWM F7IISXoVrg20nml8aL6EFWssXAciMd/cRVBzmMtMJpNi0x1MXkhalzqADzwE2jFhCk/+ fzFu5IJkwaYBylGhKpUeLjJxDp4ZO7GKRcsz7ycoVsv6YTBR2MCy/mlwFszwy2HY0FVA yKvQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:cc:to:subject:message-id:date:from:in-reply-to :references:mime-version:dkim-signature; bh=RmNPihVYfoHDM3Z6zETchBPFQqTyDidGTwTaEWOkuxQ=; b=0w50ZAAJ5LTfh1bheJ0EgDVBfUIBPBfC1Si873uYaS/IfQ6mJBsa0gCwVVodoT9Lwc 0SBuHVU6SrhD4A7s2La2SXsNc6sYt92WlvgYlQ9uIvVGlB+67Oye32LFI5bBodK26Op6 zXgFp6UaZc0EYu37ZUWkkOViep9TUB3npK5W4G40fIqZDDvyda+seil7+J5XQWYabpbC lEyhoPrk8eFww3tyYtvzJD+vbVUiZyOhU1EKA+zntnCW6zixDtonAjjfVwwy5YDC2jA/ eFUUduqYySYUSb8jx1sWAPLyO3+aZhXroVsWEL7WZ7A1wvEP4Kaqssy2Gi0j5vbKT1xc jhmg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@google.com header.s=20161025 header.b=hnEtnl8T; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=google.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id w26si6648620ejf.489.2021.02.26.11.18.29; Fri, 26 Feb 2021 11:18:51 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@google.com header.s=20161025 header.b=hnEtnl8T; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=google.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230230AbhBZTQT (ORCPT + 99 others); Fri, 26 Feb 2021 14:16:19 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56460 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229990AbhBZTQR (ORCPT ); Fri, 26 Feb 2021 14:16:17 -0500 Received: from mail-yb1-xb33.google.com (mail-yb1-xb33.google.com [IPv6:2607:f8b0:4864:20::b33]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 46853C06174A for ; Fri, 26 Feb 2021 11:15:37 -0800 (PST) Received: by mail-yb1-xb33.google.com with SMTP id x19so9983184ybe.0 for ; Fri, 26 Feb 2021 11:15:37 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=RmNPihVYfoHDM3Z6zETchBPFQqTyDidGTwTaEWOkuxQ=; b=hnEtnl8Tz18q1Pms6/HbWvyKXM387au2eBsjS3MlO8e51EmZqW71Rw+xE3xtL9zZdm e3E4UWmHGKLED5x88gts3yc9id4jGA/I5H+Z6GRboxJTK2KXJhus2sJH1LCX4pI99Ypz 0ULD1F6YRjcs3RxkgX43DJGsYE+2fLhz+0rY6ASAfspRMpy9M6jAUCoOI5GdMgBQ3DfI tPKWjP0Y8IxOh91iGhyMQqGASJJOSDFW3477y43CJF//+DmLZIIV3q8oImcNmf5RLUVK Vajp6CFqIgIC1nSRGXmbvLhD1rhrerVkOklhrDXChSplRLf5/X21gvZOhzLrplVGRb9m kl9A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=RmNPihVYfoHDM3Z6zETchBPFQqTyDidGTwTaEWOkuxQ=; b=Sgd9dqo4XOZmZCJ3yOPy5O9Mo+1ZLv5UlkntCr4U701dNeCn6KalUy4SzXYMSaWhbJ 0Hklov9cK/ekNDuMew/ME9474Sih/Qb3k4LZACHoo7ltx7hERsZv1mOZwjSmnfaqIPEo oVd6dUvWsq+AR6zdYPXUcyVwLFA5mvQnF21iLQXY4FY6R5jVHzn0KJp+EH6O465ws0Uf UeXN2J21TKMdRM5b/E55j+8drMg9Le5Ki2o07oZGJ9zkQ/1p3KuhR623Oglm0vFmR0Ao n6gpATFirm9r1ehWA/yXymS7H3D6EA+wMKF8MqL/QOsKBdOHTUK9mPV4b1KivLnLrvAL krHg== X-Gm-Message-State: AOAM5310MkpXnGdP7kK6a/124pMZcbq9KVKTbJxXmY+aPRSj4zxXsx/1 gvjzuQ3X2LAifJAkMHX5Jd7D+b2wwCPe8je5QCh2zA== X-Received: by 2002:a25:2a04:: with SMTP id q4mr7129613ybq.412.1614366936409; Fri, 26 Feb 2021 11:15:36 -0800 (PST) MIME-Version: 1.0 References: <20210205013847.1736929-1-saravanak@google.com> In-Reply-To: From: Saravana Kannan Date: Fri, 26 Feb 2021 11:15:00 -0800 Message-ID: Subject: Re: [PATCH v3] ARM: imx: avic: Convert to using IRQCHIP_DECLARE To: Fabio Estevam Cc: Russell King , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , NXP Linux Team , Greg Kroah-Hartman , Martin Kaiser , Android Kernel Team , "moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE" , linux-kernel Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Feb 22, 2021 at 6:33 PM Saravana Kannan wrote: > > On Thu, Feb 4, 2021 at 6:07 PM Saravana Kannan wrote: > > > > On Thu, Feb 4, 2021 at 5:54 PM Fabio Estevam wrote: > > > > > > Hi Saravana, > > > > > > On Thu, Feb 4, 2021 at 10:39 PM Saravana Kannan wrote: > > > > > > > > Using IRQCHIP_DECLARE lets fw_devlink know that it should not wait for > > > > these interrupt controllers to be populated as struct devices. Without > > > > this change, fw_devlink=on will make the consumers of these interrupt > > > > controllers wait for the struct device to be added and thereby block the > > > > consumers' probes forever. Converting to IRQCHIP_DECLARE addresses boot > > > > issues on imx25 with fw_devlink=on that were reported by Martin. > > > > > > > > This also removes a lot of boilerplate code. > > > > > > > > Fixes: e590474768f1 ("driver core: Set fw_devlink=on by default") > > > > Reported-by: Martin Kaiser > > > > Signed-off-by: Saravana Kannan > > > > Tested-by: Martin Kaiser > > > > > > Thanks for the respin: > > > > > > Reviewed-by: Fabio Estevam > > > > Thanks for the quick review. > > > > Maintainers, > > Is this getting picked up for 5.12? > Gentle reminder. -Saravana