Received: by 2002:a05:6a10:8c0a:0:0:0:0 with SMTP id go10csp1519189pxb; Fri, 26 Feb 2021 12:58:14 -0800 (PST) X-Google-Smtp-Source: ABdhPJzmg/gjBMCROSh+o0nQYkPzskAiGKlmtalvPdAbat9SdoGSjdrrPSoq/h3I3kI6i4EXiC/C X-Received: by 2002:a17:906:3849:: with SMTP id w9mr5363732ejc.7.1614373094695; Fri, 26 Feb 2021 12:58:14 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1614373094; cv=none; d=google.com; s=arc-20160816; b=cjLZ4RCWXnlUDpaCABgGlmzLR9fDSooGSJ5Cg4pgboW60E+tdblNgBrrqnlvBa67Jv MCBNeCMYP270fSyufUgiY/g3KXCpJ2biEfg1WgSmLBmAHDv+RrLzdbT8fpNecNG5WHbi I66iqKCwGd+MT6hp4PX7lNMYexV7WIXNoaOkLf2WgoY01u0WXY0bpRfT/x1cA0FpGLHt xHiSJq5s/pRmfBJ/faTnCdC/8ysRxXLMct5tbhMZLShL+wRRyJcvlyYqyCnhSYFlKgcv 8aY2eHvA5zCw8OQZVAOj1xSIxH5I4YTWD8qCzZDGA9I4DIi7aKhKC1Hbu2lWL45ILQ88 r9fA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date; bh=y6KOVWVhoH4Q6RYRO4KFNDY0GoSLmVQP7tLZkkQm+eI=; b=lLyyYh65VzP/I7jVke2veJDBrAT30JId/PLkGM7xWucqNU6XvSeWT/EihpP08VyPYj K02aow8pWRzHd/kbJuhPTStZQ/ohcKlpuBlB1D8Cnv0/e1cLNDQ2VZMf5SsSUDczNl4u j7JE0cB1psrjT51T/5Kt1KoKu8FC3MBulhgeyimxQCC/SsLujA+IUxfJ4Jjpp+IfgdyE JxVgZSh9p6FA+qna9TByYcFca4ro0rgS01ifABWGwNuU/397lqPXY8QmYAWHUNJDd/yE EJCeWfPbQ/5Lo7ZjlQQBoiVg8OsOH7W0epCevORh2Ht4eGxgnfM1lLp/GZYeHVSqUAkq Xgig== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id h26si6043820edw.139.2021.02.26.12.57.51; Fri, 26 Feb 2021 12:58:14 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230396AbhBZU4Z (ORCPT + 99 others); Fri, 26 Feb 2021 15:56:25 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49722 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230211AbhBZU4T (ORCPT ); Fri, 26 Feb 2021 15:56:19 -0500 Received: from zeniv-ca.linux.org.uk (zeniv-ca.linux.org.uk [IPv6:2607:5300:60:148a::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id DE99DC061788; Fri, 26 Feb 2021 12:55:38 -0800 (PST) Received: from viro by zeniv-ca.linux.org.uk with local (Exim 4.94 #2 (Red Hat Linux)) id 1lFk90-0019jq-Ld; Fri, 26 Feb 2021 20:55:26 +0000 Date: Fri, 26 Feb 2021 20:55:26 +0000 From: Al Viro To: Konrad Rzeszutek Wilk Cc: alison.schofield@intel.com, vishal.l.verma@intel.com, ira.weiny@intel.com, ben.widawsky@intel.com, dan.j.williams@intel.com, linux-cxl@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] cxl: Make loop variable be 'i' instead of 'j' Message-ID: References: <20210226204552.45399-1-konrad.wilk@oracle.com> <20210226204552.45399-2-konrad.wilk@oracle.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210226204552.45399-2-konrad.wilk@oracle.com> Sender: Al Viro Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Feb 26, 2021 at 03:45:52PM -0500, Konrad Rzeszutek Wilk wrote: > .. otherwise people spend extra cycles looking for the > inner loop and wondering 'why j'? > > This was an over-sight when initial work was rebased > so lets fix it here. > > Fixes: 583fa5e71cae ("cxl/mem: Add basic IOCTL interface") ^^^^^ 34 days too early; otherwise, that's a damn good contender...