Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
From:   Jeffrey Mitchell <jeffrey.mitchell@starlab.io>
To:     Tyler Hicks <code@tyhicks.com>
Cc:     ecryptfs@vger.kernel.org, linux-kernel@vger.kernel.org,
        Jeffrey Mitchell <jeffrey.mitchell@starlab.io>
Subject: [PATCH] ecryptfs: add rename flag support
Date:   Fri, 26 Feb 2021 15:01:25 -0600
Message-Id: <20210226210125.77692-1-jeffrey.mitchell@starlab.io>
Content-Transfer-Encoding: 8bit
Content-Type: text/plain
MIME-Version: 1.0
X-MS-Exchange-MessageSentRepresentingType: 1
Received: from jeffrey-work-20 (47.218.202.86) by SA0PR11CA0184.namprd11.prod.outlook.com (2603:10b6:806:1bc::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3890.19 via Frontend Transport; Fri, 26 Feb 2021 21:01:30 +0000
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: d0819ca2-1bb5-4756-14b3-08d8da99b0c5
X-MS-TrafficTypeDiagnostic: DM8PR09MB6389:
X-MS-Exchange-Transport-Forked: True
X-Microsoft-Antispam-PRVS: <DM8PR09MB6389B622995BA8492868E795F89D9@DM8PR09MB6389.namprd09.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:6430;
X-MS-Exchange-SenderADCheck: 1
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: aGUBj3gK4e3AWCO5iQkvmxT8S+cLPwMv9H/Qv6W/Yj2Ho0mf+q93V27bdrLI2ztpduZ/dy6rCSQ2DA1CYAB5tKj7a/Ryso41BwNk7nS5UZPzqBlFvBfUzawmSGjFB6B9BnU0EDQJGv5lxF6Ref9oORexcjvsQLXieRMvIXAm5Xb7JkLh8ZtGTGZ3gxnkbU3TGDtzp/TLd42IZprVBgtd24JxB32wrJm7dmCxKv2OcCn4kerPZgJ0hpRmLWKc9O0/dzbeRP6I4LIHdNJVdXP+7mJRkKLR0HRk3E1v3SL/+a0dVJCVXNVhPFBQcShH8CMzIVZx3TDTM5kV2rF+5DdA+rRU/6v7dIaaPjJBmoI45+x7OS4QIHHbs7NlruILghqj3a7cz9MEno8UcDncHgNLb/fMIg6nlBbVgizI5A1AXdpW3ocUXk6e74RkbwrM24TekK9JYlG0ngemo2iag9QdXbLOCUYi34XNZ9Ne1rN3ZH9wRMLawbW44ZmFuRWaZQVmL6qicFrlMHPpVLbZfQ3aUw==
X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DM8PR09MB6997.namprd09.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(376002)(346002)(136003)(39830400003)(366004)(396003)(478600001)(26005)(6486002)(186003)(4326008)(107886003)(66946007)(66476007)(44832011)(86362001)(8676002)(16526019)(83380400001)(6916009)(6496006)(66556008)(8936002)(316002)(1076003)(2616005)(5660300002)(36756003)(2906002)(52116002)(956004)(6666004);DIR:OUT;SFP:1102;
X-MS-Exchange-AntiSpam-MessageData: =?us-ascii?Q?KLQVVRpkNQlZxi6l/0qzVegrDSSw1wVlpD4ey9YcjVCxVYyA+yZDHHYDZa4e?=
 =?us-ascii?Q?tCIAnxciSYTB9p3Z+MOlIuc0s6Ef0lrfIR34m2FEQN4khUCmbSu1dpJ86q9X?=
 =?us-ascii?Q?k5BylmqKwvoA328fbjPiqjTHIj4SCkmlFUqhwYrIIBiAZzlM0IEDSxJu73Uo?=
 =?us-ascii?Q?Aw3v+iXe3zDl7HfTBCFiSD/02jYhLxsK8uvckVHUkdpQ+3vUXtqrVRCF8xFr?=
 =?us-ascii?Q?Fi0lQsmjSAjfOXkTq2EjeqwbnkwSpkXnV0pLaCDZ6CbjvbrwKHQ19UbVc4l/?=
 =?us-ascii?Q?M9mxacWAVPYCTFVAVE8rT9yOBmRepDznmK/SBuGoVIlStYQZkEEkKIIUHmb2?=
 =?us-ascii?Q?vxQm7m/H3o6c78kjM91gX+0t9hx2TVTvhzOYACginykuVNUDLxIUGhDdRiYH?=
 =?us-ascii?Q?CMPFnUcRl7IhHgJ4UU9uJFvacAVyW8wSoYlOn3u/jCRrwB4HodWrp0lWPWiO?=
 =?us-ascii?Q?JWYR1cPUj++JM4wN6yDQJtZf7irP/XV+PnL3DNS1FzXg8xs35eQpU6UvOckB?=
 =?us-ascii?Q?9x86Jzn/tif2a4AIPVZ1jTiEk1oQlErsFqHG/hBynRUZ3EAUyxNlfzX42x2L?=
 =?us-ascii?Q?XZ7BWqDRmdenaHlYK2/XsmRvqLLFC9qL6e2pR0ONN0ZjGYMLMaCczg4NLCSp?=
 =?us-ascii?Q?Y35+lkAc6cLy9Okl2jKUccw1+EN7CDZmkXsfCkpfNlQyZvTEhoP+XQIusePr?=
 =?us-ascii?Q?L+KEf9jr0YAF1YNabsPb75l29EcbJe+nBdYHhTkxYm8xClgZcRBeQP+02Q2L?=
 =?us-ascii?Q?t02i7hU0d8Y11Mp4d2lBjgrst2rkd4CzosTi+Bng98U22WI/IQLTrNfFnIrf?=
 =?us-ascii?Q?slpb/0cMK6j5fvpQqLib5IlxL+KEXnLuxccvPGsN6mGRRjE9G6WDSO0bx056?=
 =?us-ascii?Q?vPwz3UJpB1XN4pejbGU+7scyXSjE1NFszu1AQ08yfrtRLa9EuTMjlB8yXxAJ?=
 =?us-ascii?Q?1NXOEEvklpq8PpW49RgXqXdA6gL+5otymoPGQ6RcQScnjK1gkv47cThwkQLB?=
 =?us-ascii?Q?eXUbx+XgKagH//bHgsGnqx4rPjvPFWNFqFYF/ND9nO8o14rOSFpJehH3IxUh?=
 =?us-ascii?Q?1LV7W6JIn2RadW/I3j+xvuZKaXXVYgtPMowm91o3q24NUbwXOZvq85yeCgMO?=
 =?us-ascii?Q?fXfaI4Fi3YZku0DAjjtQkc/Zj/Jwpd0Sl8F6etc6waKfzlnBTJzUJxB47xdO?=
 =?us-ascii?Q?YQp7gBlDK3ykPfoHFUO7Lp5yPzqdTzwV5v2kxHN9dL3EOBUD2F8nv3E/wuHn?=
 =?us-ascii?Q?C5ESKqz7yMesIXma9TNGRmCT9UENQgwFKUcY6bcloiJaK48zJ9I81ISbG/xC?=
 =?us-ascii?Q?7TTdJF6mrNRuxVpio/XkFs+w?=
X-OriginatorOrg: starlab.io
X-MS-Exchange-CrossTenant-Network-Message-Id: d0819ca2-1bb5-4756-14b3-08d8da99b0c5
X-MS-Exchange-CrossTenant-AuthSource: DM8PR09MB6997.namprd09.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 Feb 2021 21:01:30.4508
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 5e611933-986f-4838-a403-4acb432ce224
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: USBmAccCyW3KOTgD7q8vnUicwCSw+fXCFdSs6KVmwgps6p7Zjw82XabAjHXU1OHT610Bz1FgUuLtMmlkKCFVrT+YPZgyljlRkN5KpquZf8k=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM8PR09MB6389
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Currently, ecryptfs_rename() returns EINVAL if any flags are passed in.
However, if the lower filesystem has support for those flags, it doesn't
require any additional complexity to take advantage of it in eCryptfs.

Add flag support to ecryptfs_rename() by passing them through to the lower
filesystem

Signed-off-by: Jeffrey Mitchell <jeffrey.mitchell@starlab.io>
---
 fs/ecryptfs/inode.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/fs/ecryptfs/inode.c b/fs/ecryptfs/inode.c
index 18e9285fbb4c..647afc2fd754 100644
--- a/fs/ecryptfs/inode.c
+++ b/fs/ecryptfs/inode.c
@@ -601,9 +601,6 @@ ecryptfs_rename(struct user_namespace *mnt_userns, struct inode *old_dir,
 	struct inode *target_inode;
 	struct renamedata rd = {};
 
-	if (flags)
-		return -EINVAL;
-
 	lower_old_dir_dentry = ecryptfs_dentry_to_lower(old_dentry->d_parent);
 	lower_new_dir_dentry = ecryptfs_dentry_to_lower(new_dentry->d_parent);
 
@@ -636,6 +633,7 @@ ecryptfs_rename(struct user_namespace *mnt_userns, struct inode *old_dir,
 	rd.new_mnt_userns	= &init_user_ns;
 	rd.new_dir		= d_inode(lower_new_dir_dentry);
 	rd.new_dentry		= lower_new_dentry;
+	rd.flags		= flags;
 	rc = vfs_rename(&rd);
 	if (rc)
 		goto out_lock;
-- 
2.25.1