Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Fri, 26 Feb 2021 16:28:27 -0500
From:   Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
To:     Brad Larson <brad@pensando.io>
Cc:     hch@lst.de, m.szyprowski@samsung.com, robin.murphy@arm.com,
        iommu@lists.linux-foundation.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] swiotlb: swiotlb_tbl_map_single() kernel BUG in
 iommu-helper.h:30
Message-ID: <YDln+34XyqE22puQ@Konrads-MacBook-Pro.local>
References: <20210226204307.50413-1-brad@pensando.io>
 <YDlhZDgsAZ2j0b1z@Konrads-MacBook-Pro.local>
 <CAK9rFnytTUHFHMshini8Pngfw2tGxuVhtNj2bmqeosOr_ZpQGQ@mail.gmail.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <CAK9rFnytTUHFHMshini8Pngfw2tGxuVhtNj2bmqeosOr_ZpQGQ@mail.gmail.com>
MIME-Version: 1.0
X-MS-Exchange-MessageSentRepresentingType: 1
Received: from Konrads-MacBook-Pro.local (209.6.208.110) by SJ0PR13CA0218.namprd13.prod.outlook.com (2603:10b6:a03:2c1::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3912.9 via Frontend Transport; Fri, 26 Feb 2021 21:28:30 +0000
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 76429678-3516-46e0-b928-08d8da9d76b0
X-MS-TrafficTypeDiagnostic: SJ0PR10MB4685:
X-Microsoft-Antispam-PRVS: <SJ0PR10MB4685B11C6151AEB938DE5F6C899D9@SJ0PR10MB4685.namprd10.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:10000;
X-MS-Exchange-SenderADCheck: 1
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: AItLCxWOV1NhYAHiilRgHBAgwPamXfPiQEnDUyp/jFS7h8sVGrlZahaimajzc8Dt6KFQiBvplThMBCQOCZdwEmLWBO26yzDW9dZp4qMApg35s8u03fJXf3U3K6Ue9+X3RKEJiOHy/eK6zGQPgcjmY9+2jfspzMRDcmqrBhcIipf7nNqiYV1nPJAXju/VcjX+Sk7uwc32KcXgFXq1Wn4RN92HJaEqk/gmVJusIUN/vIF2ut94eVK44Fpg1Ubq3krGT5FKOTJTlSdwjUOqOs55S38zo2QrhY+Z1o3V43H9ITN2znN7UEefDPxwPxO1IkKysQAw/naYgjpm8MQMKAhmgg6vJUASIcz+OLdam/NCPgK554zH0gNFlnWSK+pi8J03tSd23Cpx+/16DqGAneIgUxRQof5oiGm27MvfFQSICAg9nwINCfwXf2fV71zxM8gjN3edPyRzF6btqE+7of6HKrRW3jKQq/Pz8S/so6wLKhrOrXekIL8mj6e4fO5gcTD4vpoaabwRIXRq1o9WKRSglvnXfWibaXiOL8daPMwFPuRSQEWlBEOkTR+T0quPYSAV
X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR10MB2999.namprd10.prod.outlook.com;PTR:;CAT:NONE;SFS:(39860400002)(366004)(346002)(376002)(396003)(136003)(52116002)(6506007)(7696005)(9686003)(316002)(8676002)(6916009)(66476007)(478600001)(86362001)(66556008)(4326008)(6666004)(66946007)(16526019)(186003)(26005)(83380400001)(956004)(55016002)(2906002)(8936002)(5660300002)(67856001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData: =?us-ascii?Q?5Yvid08U26mjST6QxxefmDSC276wVpzOHE1PLlocqf7I5crlup81qWYsip/o?=
 =?us-ascii?Q?SozGA+/zVd5lhtfztPHbo/Aa3kDMpdV2XbTU2QOJ2pq5iUY1NK8iGbfj3z+Z?=
 =?us-ascii?Q?2hqd/9iySeHt4FC+7/U2jwrYp0tAjnTN2AFQsjkiokBYDK9aXq7KL9S7LVI/?=
 =?us-ascii?Q?lMtgfCBldVZnMoUJ74ayANGCnAKVXtgeOETAxlqtQTBIqXWGxNC9Ol0J3xQu?=
 =?us-ascii?Q?bqz02YzLlL10flDy1jMIzJ8ICVKMmwxKXnqHwe6Nzpj5SC/fKNLlry1XGMfX?=
 =?us-ascii?Q?rc7ar/XEgdy1OTr0OpOz9f7Qdt/1uux9ABkGPPqA1pYFgPACiVnU19fuPv42?=
 =?us-ascii?Q?FMtmUlKpTtXE0NHY/ywqZ0erwup3XtuR/QaxurK4iuVmUdDpH+oPcYTX56LJ?=
 =?us-ascii?Q?QeKhUav14WH9TbQBoWJotl8PnDaEhFT0T/h8ImQ+w+XGXSus4i6DDpq2CWrc?=
 =?us-ascii?Q?CBDel/FdmrPROKk95uHl0+DXMZMHc65yRP/oomNnlahtnULrJS5oSArNdvPr?=
 =?us-ascii?Q?troGWtfTIOgMySuLBWr5TZGk5mFtqBByueW+SOONAT2WfMVRDD7o1CpV/Xo6?=
 =?us-ascii?Q?JQLM5o3/dQi2StUenMFo+7SEIb4BN4CikfDf8ZuLIc+gRxhQyBNZ8AnZUzS9?=
 =?us-ascii?Q?sYiZmx/Uw3Au2q1QcY9IAg/L+BeWhQyWVq5Me18RWM61rNxxA1F0QB3P+CfL?=
 =?us-ascii?Q?4v6F6fUj6/Y1rQxw+oPVAzO3VHWThnb4TWPUhn54xyNr32jciejyUHvDLEtU?=
 =?us-ascii?Q?pAqY0FGL3mUuaGIMluWheAdLv2AwNpDjQ1pEfgdFn5aPZvWoaWczWVbX02d2?=
 =?us-ascii?Q?d+JRZdDGo2gQaqKFtxMjpZROKlp8LFA3hHFS4dzNzJOwi4Oe/zYLDz1i+EjP?=
 =?us-ascii?Q?02yNOiA60aNR9QbwQVf1HG6NBucJvQZOIiDpi8KzvYo9g6xpgrGfSIm7IT/H?=
 =?us-ascii?Q?CHqG+nrPJrk+blVFROp34174SmOnDHhj+yUNMHftW8yWOdkHiWpAUdQqhJM/?=
 =?us-ascii?Q?BqAf38sswRXez8vMHkgQeQNZAd2l05PyzmvHdwOBuAg04xHSv3fXAx6KOr9q?=
 =?us-ascii?Q?NYnZa9hQMg4mbfD50StLXSTcoSS/QBIFljMZM50JYNSdEl/mv0pBRFBtL3YE?=
 =?us-ascii?Q?ixCynDc4hryvDdJNVzwcHXBmO4cHmu5Q43Ac6a8pLIZVY2Ew+HruN4q1gfEF?=
 =?us-ascii?Q?dcSNSMXOJ40OzLFDdMxVNa2yCjyfxKkIpjR8nkllhT5wSuTUa0mt0BzmpzZZ?=
 =?us-ascii?Q?Oq/3hX4451DsxNfn87lefc4soVwN0GBh2MeWkMKFDHzcBFk2X1DQJOzr4zEa?=
 =?us-ascii?Q?sE5wIUOCKyTVwPQPukON1Jrx?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 76429678-3516-46e0-b928-08d8da9d76b0
X-MS-Exchange-CrossTenant-AuthSource: BYAPR10MB2999.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 Feb 2021 21:28:31.1337
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: gpSIdizRBYXYNjJ+2SMS/Efg35eW9mFVUBlClh/blDcQlIk01k1HCemq9vTRcjCKlCKHgVLP1iEeaAJNUQnGIw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR10MB4685
X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=9907 signatures=668683
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 mlxlogscore=999 adultscore=0
 phishscore=0 spamscore=0 suspectscore=0 bulkscore=0 malwarescore=0
 mlxscore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2009150000 definitions=main-2102260159
X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=9907 signatures=668683
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 lowpriorityscore=0 clxscore=1015
 malwarescore=0 suspectscore=0 impostorscore=0 phishscore=0 mlxscore=0
 spamscore=0 mlxlogscore=999 bulkscore=0 priorityscore=1501 adultscore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2009150000
 definitions=main-2102260159
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Fri, Feb 26, 2021 at 01:18:14PM -0800, Brad Larson wrote:
>     On Fri, Feb 26, 2021 at 12:43:07PM -0800, Brad Larson wrote:
>     > Kernel Oops introduced in next-20210222 due to get_max_slots return arg
>     size.
>     > In the function find_slots() variable max_slots is zero when
>     boundary_mask is
>     > 0xffffffffffffffff.
> 
>     I am looking at the stable/for-linus-5.12 and what I sent out for
>     a GIT PULL and I believe this is already squashed in:
> 
>     531 static int find_slots(struct device *dev, phys_addr_t orig_addr,       
>             
>     532                 size_t alloc_size)                                     
>             
>     533 {                                                                     
>              
>     534         unsigned long boundary_mask = dma_get_seg_boundary(dev);       
>             
>     535         dma_addr_t tbl_dma_addr =                                     
>              
>     536                 phys_to_dma_unencrypted(dev, io_tlb_start) &
>     boundary_mask;     
>     537         unsigned long max_slots = get_max_slots(boundary_mask);
> 
>     Could you double-check please?
> 
>  
> Yes this is squashed in the snippet you are showing.  The bug was introduced in
> next-20210222 and is still there when I updated to next-20210226 today. 

Duh! It should be fixed now for the next one. Thank you!