Received: by 2002:a05:6a10:8c0a:0:0:0:0 with SMTP id go10csp1699310pxb; Fri, 26 Feb 2021 19:36:01 -0800 (PST) X-Google-Smtp-Source: ABdhPJxgi0qxVv4FQO78MJJ8nAIqpwPesM00cO/jZHalip9ikLyzeQ08TqXSAXaV7gD4RZRYK6sv X-Received: by 2002:a17:906:2795:: with SMTP id j21mr5852393ejc.283.1614396961471; Fri, 26 Feb 2021 19:36:01 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1614396961; cv=none; d=google.com; s=arc-20160816; b=TLiS+VT7O1OLAZ3I4ENhAFtWMvo8mDFdyu2Lo41uH4Qpo2DNAd6n17gubyWbEF6YDi GhSezSobhrUPUh0eyLSXHxfLmiZtnA5V1mTYJY3H24LYrRDWwdELZiZunLkYJm9XPV8k TyJNlongA1dzhpLKPw3I6bRs4hv2eICiPSd6m8k43AGwJ2+SDhy/Rv0y+5LtEHuAiUhF ywPu3DCvechrPN5ojHNXk8ezN+rRP6u2mO7/f8fyJgH5nGO9ZPrdA3MxZMFi3XGlR73o gj6I5Q1JXWss6lun/ot4Q+h2RyWL3F6CU4GwZdxhpFhBz0b5kemxnYIiFBUQ8jE25YBI utug== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:sender:dkim-signature; bh=c5d+9yX8djWzr6OniWWyp1eF0oq4CO81f7/Et4QLr2Y=; b=j7Vt7bwXDEoYN6oTPpIm2yShGX+rMDvRvAsiCR3Gxv61eUgkYhMM7zas384x2zotAV V+OXilFy0VLSqcyPBKR4F9X8I/4YUAAxu2sncuLGxyk3SYSlagtEtfRiNYzIUxw/hYod wFW7igWyFZRZlJORKzQA56AV85geknxS6tL+lm3WmYLpNcZFuIAwAvi0vFoEdL03GUck zNEti2UV6EQ+4rNQGn5XXaZaVRPe1WCzjR6X69JktEmqbUXzq4mEDFV1A4XIjMuXs6Go zyDAlWg1LAwT8SjtPlh74YE2m/8iY12vDyxZnwdNr/0NLtMri4OzKQOJdtkFTSU9ZMUL FG9A== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=lt+8w3C9; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id bi6si5432388edb.419.2021.02.26.19.35.03; Fri, 26 Feb 2021 19:36:01 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=lt+8w3C9; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230012AbhB0Dah (ORCPT + 99 others); Fri, 26 Feb 2021 22:30:37 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49172 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229745AbhB0Dag (ORCPT ); Fri, 26 Feb 2021 22:30:36 -0500 Received: from mail-qk1-x736.google.com (mail-qk1-x736.google.com [IPv6:2607:f8b0:4864:20::736]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 99BFBC06174A; Fri, 26 Feb 2021 19:29:56 -0800 (PST) Received: by mail-qk1-x736.google.com with SMTP id v206so11307059qkb.3; Fri, 26 Feb 2021 19:29:56 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=c5d+9yX8djWzr6OniWWyp1eF0oq4CO81f7/Et4QLr2Y=; b=lt+8w3C9pXrzvS95kNZBSeqac4sFKEV79SA61gYVPpd+Zgg0kUdpI9QBvRc/i9FXBJ v2mhK3D/mRSw/RaJ5/aqssbf8uprSFaUO66u1dU0VGu3SHr4V4U1YEulWysdwd1719b4 C4sRfP4yZQbpT5YTfvlbnPD4cFcD6pAH7aCqHDFMSRSNFZc5sGI7yud2+VWjrz3L1gEu oks/atDPq0FvmDzZmmggVWbUkt8Yf4QtVYAKAq1CoIMny9S8s4/n7M0dlXux3tD71JtY 4YJyCcLaSUu3NDnt1wxPGjduH/jkWvunXhcXkp1lPPykgJKZ+N+ECThZAjRWJtvvJ3EG eq5w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :mime-version:content-transfer-encoding; bh=c5d+9yX8djWzr6OniWWyp1eF0oq4CO81f7/Et4QLr2Y=; b=gY5fksewR3rI6HDOSgodyRKYBpHdrGq2jczq0RbDGiR3mcnkDzz+PBTG4yTHjovq3g KLsXP416nJMUj7FiigwZUtd3NVf+ogeDAexATQWZnXQITuJy7tqK+rNGXuGJEvehNOV4 +OSSEqczF70VkWJyQsjlkp6ocRC3zTdCqzMwb7R2LYt3X439V+tqkv2ptMxvua7B2J7b wBvnJnsoixrRttYVqO4009Cz0fPGCvYXZOcqi8V++9YqkyYTsLq5VihMLnJnq4Xe7UPD d1HJEFyr1+kAYBloWhfnXNEGfZvH0/JIIjqFPadXBIFPXW9c/zDqts810y3fsbap+g6/ igVQ== X-Gm-Message-State: AOAM532Rf1riD8WTD0f0ckW/rdfra9fSZ2ovN0GebrIH3+SDtbgYvrJT SJtDIM+qZs+GFTOayx3zT4Y= X-Received: by 2002:a37:a30c:: with SMTP id m12mr3183549qke.300.1614396595626; Fri, 26 Feb 2021 19:29:55 -0800 (PST) Received: from localhost.localdomain (2603-9001-0308-0800-2fc5-b80d-c946-eeda.inf6.spectrum.com. [2603:9001:308:800:2fc5:b80d:c946:eeda]) by smtp.gmail.com with ESMTPSA id 184sm7979359qki.97.2021.02.26.19.29.54 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 26 Feb 2021 19:29:55 -0800 (PST) Sender: Julian Braha From: Julian Braha To: ardb@kernel.org Cc: linux-efi@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH] drivers: firmware: efi: fix Kconfig dependency on CRYPTO Date: Fri, 26 Feb 2021 22:29:49 -0500 Message-Id: <20210227032949.31977-1-julianbraha@gmail.com> X-Mailer: git-send-email 2.27.0 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org When EFI_EMBEDDED_FIRMWARE is enabled, and CRYPTO is not enabled, Kbuild gives the following warning: WARNING: unmet direct dependencies detected for CRYPTO_LIB_SHA256 Depends on [n]: CRYPTO [=n] Selected by [y]: - EFI_EMBEDDED_FIRMWARE [=y] && EFI [=y] This is because EFI_EMBEDDED_FIRMWARE selects CRYPTO_LIB_SHA256 without selecting or depending on CRYPTO, despite CRYPTO_LIB_SHA256 depending on CRYPTO. Signed-off-by: Julian Braha --- drivers/firmware/efi/Kconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/firmware/efi/Kconfig b/drivers/firmware/efi/Kconfig index 2c3dac5ecb36..f914da9845ac 100644 --- a/drivers/firmware/efi/Kconfig +++ b/drivers/firmware/efi/Kconfig @@ -248,6 +248,7 @@ endmenu config EFI_EMBEDDED_FIRMWARE bool depends on EFI + select CRYPTO select CRYPTO_LIB_SHA256 config UEFI_CPER -- 2.27.0