Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Sat, 27 Feb 2021 11:21:25 +0100
From:   Jiri Olsa <jolsa@redhat.com>
To:     "Jin, Yao" <yao.jin@linux.intel.com>
Cc:     kernel test robot <oliver.sang@intel.com>,
        Chris Wilson <chris@chris-wilson.co.uk>,
        Arnaldo Carvalho de Melo <acme@kernel.org>,
        Jiri Olsa <jolsa@kernel.org>,
        Tvrtko Ursulin <tvrtko.ursulin@intel.com>,
        Matthew Brost <matthew.brost@intel.com>,
        LKML <linux-kernel@vger.kernel.org>, lkp@lists.01.org,
        lkp@intel.com, Andi Kleen <ak@linux.intel.com>,
        Adrian Hunter <adrian.hunter@intel.com>,
        "Liang, Kan" <kan.liang@intel.com>, "Jin, Yao" <yao.jin@intel.com>,
        "Yi, Ammy" <ammy.yi@intel.com>
Subject: Re: [drm/i915/gt] 8c3b1ba0e7:
 perf-sanity-tests.Parse_event_definition_strings.fail
Message-ID: <YDodJb4CXDT8VemG@krava>
References: <20210224074841.GD6114@xsang-OptiPlex-9020>
 <cabd8692-07ca-13c8-efb5-e088b4547f80@linux.intel.com>
 <YDenRVGzh5Dv1pC2@krava>
 <YDfph8b9p8sSk1AF@krava>
 <YDfxgfi5DBDMFgwu@krava>
 <YDf0fP8XmnTrkIT8@krava>
 <d416a908-6a54-5e4c-e377-dc9d2b778941@linux.intel.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <d416a908-6a54-5e4c-e377-dc9d2b778941@linux.intel.com>
Precedence: bulk

On Fri, Feb 26, 2021 at 08:41:26AM +0800, Jin, Yao wrote:

SNIP

> > +				SET_SYMBOL(prefix, PMU_EVENT_SYMBOL);
> >   				len++;
> >   			}
> >   		}
> >   	}
> > +
> > +	/* unlikely, but still.. */
> > +	if (!len)
> > +		goto err;
> > +	perf_pmu_events_list_num = len;
> > +
> >   	qsort(perf_pmu_events_list, len,
> >   		sizeof(struct perf_pmu_event_symbol), comp_pmu);
> > 
> 
> Thanks so much for the patch! It works with my tests.
> 
> # ./perf test 6
>  6: Parse event definition strings                                  : Ok
> 
> # ./perf stat -e software/r1a/ -a -- sleep 1
> 
>  Performance counter stats for 'system wide':
> 
>    <not supported>      software/r1a/
> 
>        1.000940433 seconds time elapsed
> 
> In theory, do we also need to check suffix as well? I think returning
> PMU_EVENT_SYMBOL_SUFFIX may also confuse the parser. But yes, we don't have
> this case now.

yep, let's wait for use case ;-) you can't have suffix
without prefix, and that's the one failing, so I think
we are fine

thanks,
jirka