Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <20210225143727.3912204-1-arnd@kernel.org> <20210225143727.3912204-2-arnd@kernel.org>
 <YDlHSYxayqq5WMt0@rric.localdomain>
In-Reply-To: <YDlHSYxayqq5WMt0@rric.localdomain>
From:   Arnd Bergmann <arnd@kernel.org>
Date:   Sat, 27 Feb 2021 13:31:21 +0100
Message-ID: <CAK8P3a1DMCUPgJ5CMfJv3MnTLV8cmv0BdeyCuRjsL0oEZwaJ+g@mail.gmail.com>
Subject: Re: [PATCH 2/2] PCI: controller: avoid building empty drivers
To:     Robert Richter <rric@kernel.org>
Cc:     Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>,
        Bjorn Helgaas <bhelgaas@google.com>,
        Arnd Bergmann <arnd@arndb.de>, Rob Herring <robh@kernel.org>,
        Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>,
        Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>,
        Bharat Kumar Gogada <bharat.kumar.gogada@xilinx.com>,
        Yicong Yang <yangyicong@hisilicon.com>,
        Jiaxun Yang <jiaxun.yang@flygoat.com>,
        Daire McNamara <daire.mcnamara@microchip.com>,
        Kunihiko Hayashi <hayashi.kunihiko@socionext.com>,
        linux-pci <linux-pci@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Fri, Feb 26, 2021 at 8:08 PM Robert Richter <rric@kernel.org> wrote:
> On 25.02.21 15:37:10, Arnd Bergmann wrote:
>
> A possible double inclusion isn't really nice here, but it should work
> that way.
>
> Also, the menu entry for the driver is in fact only for the OF case,
> as it is always included for ACPI even if the option is disabled (and
> thus the choice is useless). But this is unrelated to this patch.

Yes, I considered doing this using Kconfig syntax by adding another
symbol for each affected driver and selecting those, but the Makefile
hack seemed easier here.

> Reviewed-by: Robert Richter <rric@kernel.org>

Thanks,

        Arnd