Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
IronPort-SDR: yXgbgvc7kNC9CtsPVPBZGNIE5nkE6vap2pTIHU7xVMYJ5ck85Lv3qOqiM8j3NrTOIqghztXB82
 PvbxNso72K6w==
IronPort-SDR: kpP/r/HfVSFaZrc2tHG62vir6vm7OpXqNQYFsuW1UGmI3F2p0yz4dycMaHR5zzqn/tx0rYH0Ns
 +jywudL52gLQ==
From:   "Chen, Mike Ximing" <mike.ximing.chen@intel.com>
To:     Rasmus Villemoes <linux@rasmusvillemoes.dk>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        Rob Herring <robh+dt@kernel.org>
CC:     "devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        Arnd Bergmann <arnd@arndb.de>,
        "linux-clk@vger.kernel.org" <linux-clk@vger.kernel.org>
Subject: RE: [PATCH 2/2] drivers: misc: add ripple counter driver
Thread-Topic: [PATCH 2/2] drivers: misc: add ripple counter driver
Thread-Index: AQHXDEo6dgMIhSeO9UO+cp3T6YCSu6psXLuw
Date:   Sun, 28 Feb 2021 05:47:03 +0000
Message-ID: <BYAPR11MB309522FA78A7A9420CD75A8BD99B9@BYAPR11MB3095.namprd11.prod.outlook.com>
References: <20210226141411.2517368-1-linux@rasmusvillemoes.dk>
 <20210226141411.2517368-3-linux@rasmusvillemoes.dk>
In-Reply-To: <20210226141411.2517368-3-linux@rasmusvillemoes.dk>
Accept-Language: en-US
Content-Language: en-US
dlp-version: 11.5.1.3
dlp-reaction: no-action
dlp-product: dlpe-windows
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-Network-Message-Id: d09014f6-10c9-4057-fc35-08d8dbac46b6
X-MS-Exchange-CrossTenant-originalarrivaltime: 28 Feb 2021 05:47:03.8651
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: X6hx0v+AjYdU84W3SI/7mftvAKXG9LH0WeCAeLwUEQyaO4hCsn3Wci4s5gl3hIeHGBEX7/fPBR7rbehxRoQGYDjizjkR43+YGNSzy2xzvg0=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR11MB3014
X-OriginatorOrg: intel.com
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


> -----Original Message-----
> From: Rasmus Villemoes <linux@rasmusvillemoes.dk>
> Sent: Friday, February 26, 2021 9:14 AM
> To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>; Rob Herring
> <robh+dt@kernel.org>
> Cc: devicetree@vger.kernel.org; linux-kernel@vger.kernel.org; Arnd Bergma=
nn
> <arnd@arndb.de>; linux-clk@vger.kernel.org; Rasmus Villemoes
> <linux@rasmusvillemoes.dk>
> Subject: [PATCH 2/2] drivers: misc: add ripple counter driver
>=20
> The only purpose of this driver is to serve as a consumer of the input
> clock, to prevent it from being disabled by clk_disable_unused().
>=20
> Signed-off-by: Rasmus Villemoes <linux@rasmusvillemoes.dk>
> ---
>  drivers/misc/Kconfig      |  7 +++++++
>  drivers/misc/Makefile     |  1 +
>  drivers/misc/ripple-ctr.c | 31 +++++++++++++++++++++++++++++++
>  3 files changed, 39 insertions(+)
>  create mode 100644 drivers/misc/ripple-ctr.c
>=20
> diff --git a/drivers/misc/Kconfig b/drivers/misc/Kconfig
> index f532c59bb59b..44b0b6ce42df 100644
> --- a/drivers/misc/Kconfig
> +++ b/drivers/misc/Kconfig
> @@ -445,6 +445,13 @@ config HISI_HIKEY_USB
>  	  switching between the dual-role USB-C port and the USB-A host ports
>  	  using only one USB controller.
>=20
> +config RIPPLE_CTR
> +	tristate "Trivial ripple counter driver"
> +	help
> +	  This provides a stub driver for a ripple counter, whose
> +	  only purpose is to request and enable the clock source
> +	  driving the counter.
> +
>  source "drivers/misc/c2port/Kconfig"
>  source "drivers/misc/eeprom/Kconfig"
>  source "drivers/misc/cb710/Kconfig"
> diff --git a/drivers/misc/Makefile b/drivers/misc/Makefile
> index 99b6f15a3c70..d560163068a9 100644
> --- a/drivers/misc/Makefile
> +++ b/drivers/misc/Makefile
> @@ -56,3 +56,4 @@ obj-$(CONFIG_HABANA_AI)		+=3D habanalabs/
>  obj-$(CONFIG_UACCE)		+=3D uacce/
>  obj-$(CONFIG_XILINX_SDFEC)	+=3D xilinx_sdfec.o
>  obj-$(CONFIG_HISI_HIKEY_USB)	+=3D hisi_hikey_usb.o
> +obj-$(CONFIG_RIPPLE_CTR)	+=3D ripple-ctr.o
> diff --git a/drivers/misc/ripple-ctr.c b/drivers/misc/ripple-ctr.c
> new file mode 100644
> index 000000000000..f086eaf335df
> --- /dev/null
> +++ b/drivers/misc/ripple-ctr.c
> @@ -0,0 +1,31 @@
> +// SPDX-License-Identifier: GPL-2.0-or-later
> +#include <linux/clk.h>
> +#include <linux/err.h>
> +#include <linux/mod_devicetable.h>
> +#include <linux/module.h>
> +#include <linux/platform_device.h>
> +
> +static int ripple_ctr_probe(struct platform_device *pdev)
> +{
> +	struct clk *clk;
> +
> +	clk =3D devm_clk_get(&pdev->dev, NULL);
> +	if (IS_ERR(clk))
> +		return PTR_ERR(clk);
> +	return clk_prepare_enable(clk);
> +}
> +
> +static const struct of_device_id ripple_ctr_ids[] =3D {
> +	{ .compatible =3D "linux,ripple-counter", },
> +	{ }
> +};
> +MODULE_DEVICE_TABLE(of, ripple_ctr_ids);
> +
> +static struct platform_driver ripple_ctr_driver =3D {
> +	.driver	=3D {
> +		.name		=3D "ripple-counter",
> +		.of_match_table	=3D ripple_ctr_ids,
> +	},
> +	.probe	=3D ripple_ctr_probe,
> +};
> +module_platform_driver(ripple_ctr_driver);

Missing MODULE_LICENSE() tag?
See https://www.kernel.org/doc/html/latest/process/license-rules.html#licen=
se-identifiers

> --
> 2.29.2