Message-ID: <451BB45C.2050609@t-online.de>
Date: Thu, 28 Sep 2006 13:39:08 +0200
From: Bernd Schmidt <bernds_cb1@t-online.de>
User-Agent: Thunderbird 1.5.0.7 (X11/20060927)
MIME-Version: 1.0
To: Arnd Bergmann <arnd@arndb.de>
CC: Robin Getz <rgetz@blackfin.uclinux.org>, luke Yang <luke.adi@gmail.com>,
       Andrew Morton <akpm@osdl.org>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/4] Blackfin: arch patch for 2.6.18
References: <6.1.1.1.0.20060927121508.01ecea90@ptg1.spd.analog.com> <200609272257.02385.arnd@arndb.de> <451B9675.8070406@t-online.de> <200609281304.31872.arnd@arndb.de>
In-Reply-To: <200609281304.31872.arnd@arndb.de>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 862
Lines: 22

Arnd Bergmann wrote:
>> We want to restore the proper  
>> mask of enabled interrupts with the STI.  That mask is in the global 
>> irq_flags variable (which probably ought to have a different name that 
>> doesn't invite clashes).
> 
> Shouldn't you just use a constant expression here? A global variable
> for it sounds rather strange, especially since the local_irq_disable()
> calls are sometimes nested, not to mention the problems you'd hit on
> SMP?

It's not a constant - there are some {un,}mask_irq functions that may 
change it.  We don't have SMP, obviously it would have to be per-CPU if 
we did.


Bernd
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/