From: Arnd Bergmann <arnd@arndb.de>
To: Bernd Schmidt <bernds_cb1@t-online.de>
Subject: Re: [PATCH 1/4] Blackfin: arch patch for 2.6.18
Date: Thu, 28 Sep 2006 14:35:01 +0200
User-Agent: KMail/1.9.4
Cc: Robin Getz <rgetz@blackfin.uclinux.org>, luke Yang <luke.adi@gmail.com>,
       Andrew Morton <akpm@osdl.org>, linux-kernel@vger.kernel.org
References: <6.1.1.1.0.20060927121508.01ecea90@ptg1.spd.analog.com> <200609281304.31872.arnd@arndb.de> <451BB45C.2050609@t-online.de>
In-Reply-To: <451BB45C.2050609@t-online.de>
MIME-Version: 1.0
Content-Type: text/plain;
  charset="iso-8859-1"
Content-Transfer-Encoding: 8BIT
Content-Disposition: inline
Message-Id: <200609281435.02847.arnd@arndb.de>
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 845
Lines: 20

On Thursday 28 September 2006 13:39, Bernd Schmidt wrote:
> 
> > Shouldn't you just use a constant expression here? A global variable
> > for it sounds rather strange, especially since the local_irq_disable()
> > calls are sometimes nested, not to mention the problems you'd hit on
> > SMP?
> 
> It's not a constant - there are some {un,}mask_irq functions that may 
> change it. ?We don't have SMP, obviously it would have to be per-CPU if 
> we did.
> 
Ok, got it now. I did not realize that you use the same register
for global irq enable and for specific interrupts that can be masked.

	Arnd <><
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/