Received: by 2002:a05:6a10:8c0a:0:0:0:0 with SMTP id go10csp2599240pxb; Sun, 28 Feb 2021 06:43:43 -0800 (PST) X-Google-Smtp-Source: ABdhPJxqjnr0RlykadV1Sj0hN+0ZnW0fIl+4IjRhZ89iy4Jmz0lVp/Vcw+A9rYmyEGdZlab5r2/9 X-Received: by 2002:a17:906:b102:: with SMTP id u2mr11957337ejy.303.1614523422844; Sun, 28 Feb 2021 06:43:42 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1614523422; cv=none; d=google.com; s=arc-20160816; b=EfX7dtqzNHxCv8wDY3011x62kpjE/NEs3TPVNmg7+bdC/53cRc4Ik5+bJFtpqu/5zM WVPfZmHI7/KSbYS1Fw3IA3ATQL155jc60kt4WfMF4cUBjRzmMAmtemk2dYZ2Y0Ku4qf8 SHkz5iIIppkJVFb5m5qpKOXXBCGCEeXrkWJGUKy3YFbG7LQ8sJrKp1fLMaLHz1O2iSk8 NrEN1HNXm+VoZO5518PDjjmxP/1/HDL00QatVMqnS9CfcQjoCetIZPcuY1a9w2JTdwiC 2Wl0b6phLNApgXKFfcp5CjfM9cOa43djQv8+c8mevpZAPtFKAmFv6r1yjEwYBVzkycPr 3y2g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :organization:references:in-reply-to:message-id:subject:cc:to:from :date; bh=yTJxLU4RqPYJcDme+rqUixEKVA8xelnL7jxz2pZhoeA=; b=V7ZXuvSfvDYc5snKTI1uP7ZGbnTwvRFf2EQT2IjKW799nEtuL8PXxL+GocbRdNeID1 Pnxd/be1kNSl3D12LLeEWTlA0AKHZhFMNbzXxzpy1+t84yXdAEIANssxwHNkPd4OmvBb E9Wj5xiwEmyE7CI1osTjue7AJpKLNV0DGDS0seqmLZy2pf/8j7ykTRF/Br9P9TNvoHdJ yJ5ef7pECkWgZMREyL3v7+z0ygMzfAegHQez0GddL1iML0TJR+a9G5II4+BnIVNjRYAg AZsC3Gj6Fa+8amt434hwH91XEK3MTYmRGJslwol9lXbFlCwKYhEGgnD6y/vadXL4/cqb dABw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id eb13si10164094edb.8.2021.02.28.06.43.20; Sun, 28 Feb 2021 06:43:42 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230063AbhB1OkK convert rfc822-to-8bit (ORCPT + 99 others); Sun, 28 Feb 2021 09:40:10 -0500 Received: from frasgout.his.huawei.com ([185.176.79.56]:2611 "EHLO frasgout.his.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229715AbhB1OkJ (ORCPT ); Sun, 28 Feb 2021 09:40:09 -0500 Received: from fraeml737-chm.china.huawei.com (unknown [172.18.147.226]) by frasgout.his.huawei.com (SkyGuard) with ESMTP id 4DpQqz6BDPz67XZl; Sun, 28 Feb 2021 22:33:51 +0800 (CST) Received: from lhreml710-chm.china.huawei.com (10.201.108.61) by fraeml737-chm.china.huawei.com (10.206.15.218) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2106.2; Sun, 28 Feb 2021 15:39:28 +0100 Received: from localhost (10.47.88.221) by lhreml710-chm.china.huawei.com (10.201.108.61) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2106.2; Sun, 28 Feb 2021 14:39:27 +0000 Date: Sun, 28 Feb 2021 14:38:19 +0000 From: Jonathan Cameron To: Ronald =?ISO-8859-1?Q?Tschal=E4r?= CC: Jiri Kosina , Benjamin Tissoires , Jonathan Cameron , Srinivas Pandruvada , "Lars-Peter Clausen" , Peter Meerwald-Stadler , , , Subject: Re: [PATCH 0/5] Touch Bar and ALS support for MacBook Pro's Message-ID: <20210228143819.00003f10@Huawei.com> In-Reply-To: <20210228012643.69944-1-ronald@innovation.ch> References: <20210228012643.69944-1-ronald@innovation.ch> Organization: Huawei Technologies Research and Development (UK) Ltd. X-Mailer: Claws Mail 3.17.4 (GTK+ 2.24.32; i686-w64-mingw32) MIME-Version: 1.0 Content-Type: text/plain; charset="ISO-8859-1" Content-Transfer-Encoding: 8BIT X-Originating-IP: [10.47.88.221] X-ClientProxiedBy: lhreml718-chm.china.huawei.com (10.201.108.69) To lhreml710-chm.china.huawei.com (10.201.108.61) X-CFilter-Loop: Reflected Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, 27 Feb 2021 17:26:38 -0800 Ronald Tschal?r wrote: > This patch set provides Touch Bar and ALS support on MacBook Pro's > 13,*, 14,*, and 15,*. > > Some time a go an earlier version of these were posted to the list; > all code comments from there have been incorporated. In addition the > approach has been cleaned up, especially given that we now know how > the 15,* models are implemented, so that the ibridge driver is only > needed for the pre-15,* models and the ALS and Touch Bar drivers work > unchanged for all models. Please keep the version numbering increasing (even if the series has been restructured like here) or at very least include a link to the archive on lore.kernel.org (I think this is the latest earlier version) https://lore.kernel.org/linux-iio/20190612083400.1015-1-ronald@innovation.ch/ Thanks, Jonathan > > Ronald Tschal?r (5): > HID: Recognize sensors with application collections too. > iio: hid-sensor-als: Support change sensitivity in illuminance too. > HID: core: Export some report item parsing functions. > HID: apple-ibridge: Add Apple iBridge HID driver for T1 chip. > HID: apple-touchbar - Add driver for the Touch Bar on MacBook Pro's. > > drivers/hid/Kconfig | 26 + > drivers/hid/Makefile | 2 + > drivers/hid/apple-ibridge.c | 682 +++++++++++++ > drivers/hid/apple-ibridge.h | 15 + > drivers/hid/apple-touchbar.c | 1523 ++++++++++++++++++++++++++++ > drivers/hid/hid-core.c | 57 +- > drivers/hid/hid-ids.h | 1 + > drivers/hid/hid-quirks.c | 3 + > drivers/hid/hid-sensor-hub.c | 6 +- > drivers/iio/light/hid-sensor-als.c | 8 + > include/linux/hid.h | 4 + > 11 files changed, 2302 insertions(+), 25 deletions(-) > create mode 100644 drivers/hid/apple-ibridge.c > create mode 100644 drivers/hid/apple-ibridge.h > create mode 100644 drivers/hid/apple-touchbar.c >