Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <20210215104043.91251-1-alexandru.ardelean@analog.com>
 <20210215104043.91251-3-alexandru.ardelean@analog.com> <2e6f90be-5dbf-1356-d1ac-22a4273c87ee@metafoo.de>
In-Reply-To: <2e6f90be-5dbf-1356-d1ac-22a4273c87ee@metafoo.de>
From:   Alexandru Ardelean <ardeleanalex@gmail.com>
Date:   Sun, 28 Feb 2021 19:45:55 +0200
Message-ID: <CA+U=Dso2PePbTMCmLGeN2eZ4spQd8gM91-w+kDnik0QMb0ikcA@mail.gmail.com>
Subject: Re: [PATCH v6 02/24] iio: kfifo: add devm_iio_kfifo_buffer_setup() helper
To:     Lars-Peter Clausen <lars@metafoo.de>
Cc:     Alexandru Ardelean <alexandru.ardelean@analog.com>,
        LKML <linux-kernel@vger.kernel.org>,
        linux-iio <linux-iio@vger.kernel.org>,
        "Hennerich, Michael" <Michael.Hennerich@analog.com>,
        Jonathan Cameron <jic23@kernel.org>,
        =?UTF-8?B?TnVubyBTw6E=?= <nuno.sa@analog.com>,
        "Bogdan, Dragos" <dragos.bogdan@analog.com>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Sun, Feb 28, 2021 at 10:08 AM Lars-Peter Clausen <lars@metafoo.de> wrote:
>
> On 2/15/21 11:40 AM, Alexandru Ardelean wrote:
> > +int devm_iio_kfifo_buffer_setup(struct device *dev,
> > +                             struct iio_dev *indio_dev,
> > +                             int mode_flags,
> > +                             const struct iio_buffer_setup_ops *setup_ops)
> > +{
> > +     struct iio_buffer *buffer;
> > +
> > +     if (mode_flags)
> > +             mode_flags &= kfifo_access_funcs.modes;
>
> The if seems unnecessary. If it is 0 and we AND it with something it is
> still 0.

Makes sense.
Will send an update for this.

>