Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
IronPort-SDR: 0ggdj6rVea6U+aUCUmummPWbnzOktGNPV/SZ0dQFyyhyC1YiZ9XIgQySLuFXSwO3Z3M5mT0aJ3
 K1fWHEMMfGiA==
IronPort-SDR: 5HC3zik/quD32H4ibWBQ4yKpyxV+op7mbsAS3fkEtDdSrJX7t2CuFWB76niUEmGp3ouIYpCkiO
 lDnuWH3Th+iA==
From:   "Chen, Mike Ximing" <mike.ximing.chen@intel.com>
To:     Mauro Carvalho Chehab <mchehab+huawei@kernel.org>,
        Johan Hovold <johan@kernel.org>
CC:     Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "linux-usb@vger.kernel.org" <linux-usb@vger.kernel.org>
Subject: RE: [PATCH 2/7] USB: serial: xr: use a table for device-specific
 settings
Thread-Topic: [PATCH 2/7] USB: serial: xr: use a table for device-specific
 settings
Thread-Index: AQHXDEOYbtWRQarFBk+AqpuOf7CZt6pt/lFw
Date:   Sun, 28 Feb 2021 20:06:44 +0000
Message-ID: <SN6PR11MB31032B4182769288DC5F5A0ED99B9@SN6PR11MB3103.namprd11.prod.outlook.com>
References: <cover.1614345081.git.mchehab+huawei@kernel.org>
 <7277c90d546f63b9ca69e6381a2f342e7054befd.1614345081.git.mchehab+huawei@kernel.org>
In-Reply-To: <7277c90d546f63b9ca69e6381a2f342e7054befd.1614345081.git.mchehab+huawei@kernel.org>
Accept-Language: en-US
Content-Language: en-US
dlp-version: 11.5.1.3
dlp-reaction: no-action
dlp-product: dlpe-windows
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-Network-Message-Id: be964cb4-ef8d-45a4-ddc7-08d8dc245ef3
X-MS-Exchange-CrossTenant-originalarrivaltime: 28 Feb 2021 20:06:44.2109
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: CUqYbGPb+KCNKRi9e35XYgb45A4xU89AjVqBDUs3ara9xcOie3CbBEgc8DPZYranm8IuScfWJvdJ9/hCAUZ0+MipXuaQ8nxBCUAN7RDM+LE=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA2PR11MB5116
X-OriginatorOrg: intel.com
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


> -----Original Message-----
> From: Mauro Carvalho Chehab <mchehab@kernel.org> On Behalf Of Mauro
> Carvalho Chehab
>=20
>  static int xr_probe(struct usb_serial *serial, const struct usb_device_i=
d *id)
>  {
> +	struct xr_port_private *port_priv;
> +
>  	/* Don't bind to control interface */
>  	if (serial->interface->cur_altsetting->desc.bInterfaceNumber =3D=3D 0)
>  		return -ENODEV;
>=20
> +	port_priv =3D kzalloc(sizeof(*port_priv), GFP_KERNEL);
> +	if (!port_priv)
> +		return -ENOMEM;
> +
> +	port_priv->model =3D id->driver_info;
> +
> +	usb_set_serial_data(serial, port_priv);
> +
>  	return 0;
>  }
>=20
> +static void xr_disconnect(struct usb_serial *serial)
> +{
> +	struct xr_port_private *port_priv =3D usb_get_serial_data(serial);
> +
> +	kfree(port_priv);
> +	usb_set_serial_data(serial, 0);

Probably a nitpick, but shouldn't usb_set_serral_data() be called before kf=
ree()?

> +}
> +
>  static const struct usb_device_id id_table[] =3D {
> -	{ USB_DEVICE(0x04e2, 0x1410) }, /* XR21V141X */
> +	{ USB_DEVICE(0x04e2, 0x1410), .driver_info =3D XR21V141X},
>  	{ }
>  };
>  MODULE_DEVICE_TABLE(usb, id_table);
> @@ -566,6 +640,7 @@ static struct usb_serial_driver xr_device =3D {
>  	.id_table		=3D id_table,
>  	.num_ports		=3D 1,
>  	.probe			=3D xr_probe,
> +	.disconnect		=3D xr_disconnect,
>  	.open			=3D xr_open,
>  	.close			=3D xr_close,
>  	.break_ctl		=3D xr_break_ctl,
> --
> 2.29.2