Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <1614071544-130951-1-git-send-email-yang.lee@linux.alibaba.com>
In-Reply-To: <1614071544-130951-1-git-send-email-yang.lee@linux.alibaba.com>
From:   Oded Gabbay <oded.gabbay@gmail.com>
Date:   Sun, 28 Feb 2021 22:13:11 +0200
Message-ID: <CAFCwf12mapgw=dFkqHr__P4ur6R3D=fyCVW2KSzMLL0qu0t3HQ@mail.gmail.com>
Subject: Re: [PATCH] banalabs: Switch to using the new API kobj_to_dev()
To:     Yang Li <yang.lee@linux.alibaba.com>
Cc:     Oded Gabbay <ogabbay@kernel.org>, Arnd Bergmann <arnd@arndb.de>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        "Linux-Kernel@Vger. Kernel. Org" <linux-kernel@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Tue, Feb 23, 2021 at 11:12 AM Yang Li <yang.lee@linux.alibaba.com> wrote:
>
> fixed the following coccicheck:
> ./drivers/misc/habanalabs/common/sysfs.c:347:60-61: WARNING opportunity
> for kobj_to_dev()
>
> Reported-by: Abaci Robot <abaci@linux.alibaba.com>
> Signed-off-by: Yang Li <yang.lee@linux.alibaba.com>
> ---
>  drivers/misc/habanalabs/common/sysfs.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/misc/habanalabs/common/sysfs.c b/drivers/misc/habanalabs/common/sysfs.c
> index 4366d8f..79c1ddf 100644
> --- a/drivers/misc/habanalabs/common/sysfs.c
> +++ b/drivers/misc/habanalabs/common/sysfs.c
> @@ -344,7 +344,7 @@ static ssize_t eeprom_read_handler(struct file *filp, struct kobject *kobj,
>                         struct bin_attribute *attr, char *buf, loff_t offset,
>                         size_t max_size)
>  {
> -       struct device *dev = container_of(kobj, struct device, kobj);
> +       struct device *dev = kobj_to_dev(kobj);
>         struct hl_device *hdev = dev_get_drvdata(dev);
>         char *data;
>         int rc;
> --
> 1.8.3.1
>

Reviewed-by: Oded Gabbay <ogabbay@kernel.org>
Applied to -next.

Thanks,
Oded