Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
From:   Wang Qing <wangqing@vivo.com>
To:     Thomas Bogendoerfer <tsbogend@alpha.franken.de>,
        Wang Qing <wangqing@vivo.com>, linux-mips@vger.kernel.org,
        linux-kernel@vger.kernel.org
Subject: [PATCH] arch: mips: sibyte: Return -EFAULT if copy_to_user() fails
Date:   Mon,  1 Mar 2021 14:33:56 +0800
Message-Id: <1614580437-19660-1-git-send-email-wangqing@vivo.com>
Precedence: bulk

The copy_to_user() function returns the number of bytes remaining to be
copied, but we want to return -EFAULT if the copy doesn't complete.

Signed-off-by: Wang Qing <wangqing@vivo.com>
---
 arch/mips/sibyte/common/sb_tbprof.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/mips/sibyte/common/sb_tbprof.c b/arch/mips/sibyte/common/sb_tbprof.c
index f80d7a7..eac125f
--- a/arch/mips/sibyte/common/sb_tbprof.c
+++ b/arch/mips/sibyte/common/sb_tbprof.c
@@ -465,7 +465,7 @@ static ssize_t sbprof_tb_read(struct file *filp, char *buf,
 		if (err) {
 			*offp = cur_off + cur_count - err;
 			mutex_unlock(&sbp.lock);
-			return err;
+			return -EFAULT;
 		}
 		pr_debug(DEVNAME ": read from sample %d, %d bytes\n",
 			 cur_sample, cur_count);
-- 
2.7.4