Received: by 2002:a05:6a10:8c0a:0:0:0:0 with SMTP id go10csp3138592pxb;
        Mon, 1 Mar 2021 02:35:32 -0800 (PST)
X-Google-Smtp-Source: ABdhPJyJJlxE3LecqR1dTMz2XS3vt0lph7ZfrcNBDJSphhoWiLxiPnJeNU9zKP+/QzGjzUaAUU6r
X-Received: by 2002:a17:906:170a:: with SMTP id c10mr9935326eje.349.1614594931974;
        Mon, 01 Mar 2021 02:35:31 -0800 (PST)
ARC-Seal: i=1; a=rsa-sha256; t=1614594931; cv=none;
        d=google.com; s=arc-20160816;
        b=up6/XM62qnX4HO0mQ1Ap9fGdRBhMwMQt/yyWhG0k7PwSzuckk8Dv0p+zP2bqdjl87n
         +WVJ07ChGS4qze3BAPQ6LzGgc8CR1puNKAap7kFQKVeDiukR7JzpejyWNLqK2W+l/fjW
         FhFqerM7uAmijn9vfpAwnKLvQ2y4im/Sijyc2Tu80mx/NqIzn55hlBEuQRjaT3ZUTkAJ
         usq7hqPDz97EvXWvZ22wWDau/uV55xqBf+OyCWg/gKFZICQFs5x6uAPpuuiQfWmHo50G
         z19trYtkph0rq/TEZac+Uqa7oeaZIzPgBwh/hEFV7fB8CwccXKcq0mcCuMaCqKELn/J4
         6J9g==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816;
        h=list-id:precedence:cc:to:subject:message-id:date:from:in-reply-to
         :references:mime-version:dkim-signature;
        bh=2/ii7K4CtnMMku2yGlI81G6YB1hYSHxfV70UcG0v9D4=;
        b=fKw4nfUJYK4eJeWd7ooNSHuAOxxSkZ5yweznD6TC5PZ6vPj8yA1y9Im6gAQCdR6G1O
         kska7mZAEYTaBvOgvLGvrvh9uyrX03N+8P4BTwv2Q9d83EL8iKVvefsrSmod1nM7bMLl
         iADoRv6aAlNuDlm2VDzamteB0PR415TytJw9ya165iVP/s1gLIg+UzO8f5R8jMzOyyXg
         LlDlsGwDoaqef4tAWdlSn+HcPxDNYdR9vXt9teNcenht0ABwNc5nEW3fxqFq/Gg6Ekeu
         ffn4vi8iCt5dLvZF5oiN/IbsCAQDAFhSGJEDgu7cOgWvgrRPJanWe0D4st7Z8ZY5zhg8
         VoPQ==
ARC-Authentication-Results: i=1; mx.google.com;
       dkim=pass header.i=@gmail.com header.s=20161025 header.b=cifhlWed;
       spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org;
       dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18])
        by mx.google.com with ESMTP id j1si11589171eja.96.2021.03.01.02.35.09;
        Mon, 01 Mar 2021 02:35:31 -0800 (PST)
Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Authentication-Results: mx.google.com;
       dkim=pass header.i=@gmail.com header.s=20161025 header.b=cifhlWed;
       spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org;
       dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S234505AbhCAKdG (ORCPT <rfc822;luc.vanoostenryck.ml@gmail.com>
        + 99 others); Mon, 1 Mar 2021 05:33:06 -0500
Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44808 "EHLO
        lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S234493AbhCAKcp (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Mon, 1 Mar 2021 05:32:45 -0500
Received: from mail-pl1-x62b.google.com (mail-pl1-x62b.google.com [IPv6:2607:f8b0:4864:20::62b])
        by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2B038C061756;
        Mon,  1 Mar 2021 02:32:05 -0800 (PST)
Received: by mail-pl1-x62b.google.com with SMTP id c16so106775ply.0;
        Mon, 01 Mar 2021 02:32:05 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20161025;
        h=mime-version:references:in-reply-to:from:date:message-id:subject:to
         :cc;
        bh=2/ii7K4CtnMMku2yGlI81G6YB1hYSHxfV70UcG0v9D4=;
        b=cifhlWedUyZA6JAWkJBiJG1dYI5BrIhpbIq9Or5VYQF5EEb+H9k5SMvppbgLP1Th9R
         rL5j9c3X2ZOvejbvztv30eZzy4E0L82SiXZWlC4ozL7ie4lrVtKeGoUxo/PLCdz9OsNV
         lTFrNAW4f065+QyRSDRBMddlk+2GjonLFq6xVlQ4mkC6yWxSieoKkWqQCFWSk74Kj5T5
         WxGHve8w27c8aBsKhLnvU4QMcdAs3kQWVP5T2Vt+PQ/PG8kmecg83UR6kGKnnFT7ecyo
         SoNwG2Jum9bXDRWWYWDQNdZqQsoUXjIHKU2L9u4oSCfWqae58dZDxKqrpVkqEb7Rk0Vf
         InRA==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20161025;
        h=x-gm-message-state:mime-version:references:in-reply-to:from:date
         :message-id:subject:to:cc;
        bh=2/ii7K4CtnMMku2yGlI81G6YB1hYSHxfV70UcG0v9D4=;
        b=LtxnpFDcqybTuGxhTBU4ElzI6VYG5Z06aJmheI57vewTk0hfdSR24+JAI+sw2cIVPN
         Vbz9Upxdx7hQR1NOeDPcby3ryOIcyXa+YZpbDhKin2eSarAh075crg1KxvGUBpL4NmZ4
         cegOBIOrKYWGAuQ0z98wKzO3a37jC8OtuUBQB7wCqMKkZGWBSfFt9Uz4YtzNma7HNBfq
         DfhyOrqQvOS0jhcZ0yIWHd1w85mKa5nfeECoWClecc9AGxV5M2xyb32r2ZdN+chA75SH
         3JkzefJOvgG6SmRFBGqU50XwYoq+EAiwC3R5KMrkQb6lnIny2x7aapxYRFlWpYIaUz50
         quRQ==
X-Gm-Message-State: AOAM530M490w7gz3pcwexsMU4WsRRz8x/HmJ4QsabO+RT96ZAG5k2uqH
        ycrQSui8gQbQ9K4B/ExLCTgnHxlA4o0LQI0JivM=
X-Received: by 2002:a17:90a:4fc1:: with SMTP id q59mr17543267pjh.129.1614594724659;
 Mon, 01 Mar 2021 02:32:04 -0800 (PST)
MIME-Version: 1.0
References: <20210301072842.7410-1-dinghao.liu@zju.edu.cn>
In-Reply-To: <20210301072842.7410-1-dinghao.liu@zju.edu.cn>
From:   Andy Shevchenko <andy.shevchenko@gmail.com>
Date:   Mon, 1 Mar 2021 12:31:48 +0200
Message-ID: <CAHp75Vf86_Ccs7wqzbpWbLDZSSJLbMwZ1TX3dwru9JvXUTMR_Q@mail.gmail.com>
Subject: Re: [PATCH] sata_dwc_460ex: Fix missing check in sata_dwc_isr
To:     Dinghao Liu <dinghao.liu@zju.edu.cn>
Cc:     Kangjie Lu <kjlu@umn.edu>, Jens Axboe <axboe@kernel.dk>,
        linux-ide@vger.kernel.org,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Mon, Mar 1, 2021 at 9:44 AM Dinghao Liu <dinghao.liu@zju.edu.cn> wrote:
>
> ata_qc_from_tag() may return a null pointer and further lead to
> null-pointer-dereference. Add a return value check to avoid such case.

Can you elaborate more on this? Is it a real case?
I have a hardware, how can I reproduce this?

-- 
With Best Regards,
Andy Shevchenko