Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
IronPort-SDR: fk5kOmRKRTwaBC8fX2U9bnclwt99r/R6N4t4xtSg0vzdA8CMfPhEWHiiZ0xpOEFI6caU2HXe/8
 gIRXtCXetDYg==
IronPort-SDR: 4Ic0AvbGoMFVDN83zbyg91KXTaFhUAvBKkobvKwwrg7oQiljIpGcNd6CJEfKGDbrFwIzwODY76
 oEWe3tq34KOw==
References: <20210216160525.5028-1-maciej.kwapulinski@linux.intel.com> <20210216160525.5028-2-maciej.kwapulinski@linux.intel.com> <CAHp75Vep0Fm1k_7gJcozk4t316QmUgt5Qe3PauwDg=py5VnHfQ@mail.gmail.com> <85ft1fjhws.fsf@linux.intel.com> <YDzAY8j6R87BFFI/@kroah.com>
User-agent: mu4e 1.4.13; emacs 26.3
From:   Maciej Kwapulinski <maciej.kwapulinski@linux.intel.com>
To:     Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc:     Andy Shevchenko <andy.shevchenko@gmail.com>,
        Arnd Bergmann <arnd@arndb.de>,
        Jonathan Corbet <corbet@lwn.net>,
        Derek Kiernan <derek.kiernan@xilinx.com>,
        Dragan Cvetic <dragan.cvetic@xilinx.com>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        Linux Documentation List <linux-doc@vger.kernel.org>,
        Tomasz Jankowski <tomasz1.jankowski@intel.com>,
        Savo Novakovic <savox.novakovic@intel.com>,
        Jianxun Zhang <jianxun.zhang@linux.intel.com>
Subject: Re: [PATCH v1 01/12] gna: add driver module
In-reply-to: <YDzAY8j6R87BFFI/@kroah.com>
Date:   Mon, 01 Mar 2021 11:36:40 +0100
Message-ID: <85czwjjh3b.fsf@linux.intel.com>
MIME-Version: 1.0
Content-Type: text/plain
Precedence: bulk


Greg Kroah-Hartman <gregkh@linuxfoundation.org> writes:

> On Mon, Mar 01, 2021 at 11:18:59AM +0100, Maciej Kwapulinski wrote:
>> 
>> Andy Shevchenko <andy.shevchenko@gmail.com> writes:
>> 
>> > On Tue, Feb 16, 2021 at 6:11 PM Maciej Kwapulinski
>> > <maciej.kwapulinski@linux.intel.com> wrote:
>> >>
>> ....
>> >> +static int __init gna_drv_init(void)
>> >> +{
>> >> +       int ret;
>> >> +
>> >> +       mutex_init(&gna_drv_priv.lock);
>> >> +
>> >> +       gna_class = class_create(THIS_MODULE, "gna");
>> >> +       if (IS_ERR(gna_class)) {
>> >> +               pr_err("class device create failed\n");
>> >> +               return PTR_ERR(gna_class);
>> >> +       }
>> >> +       gna_class->devnode = gna_devnode;
>> >> +
>> >> +       ret = pci_register_driver(&gna_driver);
>> >
>> > Is it possible to decouple a PCI glue driver from the class as many
>> > other existing examples are doing?
>> >
>> 
>> I see many pci drivers (including staging) that do have it glued though.
>> 
>> Examples are:
>> 1. "static int __init kp2000_pcie_init(void)" (commit on May 20 09:34:11
>> 2019)
>> 2. "static int __init hl_init(void)" (commit on Mon Feb 18 09:46:43 2019)
>> 
>> Please give me more details.
>
> Never use a staging driver for any type of example, _EXECPT_ for a bad
> one.  There's a reason the code is in staging and not in the "real" part
> of the kernel.

ok.

another one (1) is not staging..