Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Mon, 1 Mar 2021 12:36:12 +0100
From:   Marc Kleine-Budde <mkl@pengutronix.de>
To:     Dario Binacchi <dariobin@libero.it>
Cc:     linux-kernel@vger.kernel.org,
        Federico Vaga <federico.vaga@gmail.com>,
        Oliver Hartkopp <socketcan@hartkopp.net>,
        Vincent Mailhol <mailhol.vincent@wanadoo.fr>,
        YueHaibing <yuehaibing@huawei.com>,
        Zhang Qilong <zhangqilong3@huawei.com>,
        linux-can@vger.kernel.org, netdev@vger.kernel.org
Subject: Re: [PATCH v2 3/6] can: c_can: fix control interface used by
 c_can_do_tx
Message-ID: <20210301113612.rvbjnqacqstseokm@pengutronix.de>
References: <20210225215155.30509-1-dariobin@libero.it>
 <20210225215155.30509-4-dariobin@libero.it>
 <20210226084456.l2oztlesjzl6t2nm@pengutronix.de>
 <942251933.544595.1614508531322@mail1.libero.it>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="yq2w6x3aott2pfwm"
Content-Disposition: inline
In-Reply-To: <942251933.544595.1614508531322@mail1.libero.it>
Precedence: bulk


--yq2w6x3aott2pfwm
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On 28.02.2021 11:35:31, Dario Binacchi wrote:
> > On 25.02.2021 22:51:52, Dario Binacchi wrote:
> > > According to commit 640916db2bf7 ("can: c_can: Make it SMP safe") let=
 RX use
> > > IF1 (i.e. IF_RX) and TX use IF2 (i.e. IF_TX).
> >=20
> > Is this a fix?
> >=20
>=20
> I think that If I consider what is described in the 640916db2bf7
> commit, using the IF_RX interface in a tx routine is wrong.

Yes, IF_RX is used in c_can_do_tx(), but that's called from
c_can_poll(), which runs ins NAPI.

As far as I understand 640916db2bf7 ("can: c_can: Make it SMP safe")
fixes the race condition that c_can_poll() and c_can_start_xmit() both
access the same IF. See again the patch description:

| The hardware has two message control interfaces, but the code only uses t=
he
| first one. So on SMP the following can be observed:
|=20
| CPU0            CPU1
| rx_poll()
|   write IF1     xmit()
|                 write IF1
|   write IF1

It's not 100% accurate, as the race condition is not just
c_can_do_rx_poll() against the c_can_start_xmit(), but the whole
c_can_poll() against c_can_start_xmit().

If you think my analysis is correct, please update the patch and add a
comment to clarify why IF_RX is used instead of changing it to IF_TX.

regards,
Marc

--=20
Pengutronix e.K.                 | Marc Kleine-Budde           |
Embedded Linux                   | https://www.pengutronix.de  |
Vertretung West/Dortmund         | Phone: +49-231-2826-924     |
Amtsgericht Hildesheim, HRA 2686 | Fax:   +49-5121-206917-5555 |

--yq2w6x3aott2pfwm
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQEzBAABCgAdFiEEK3kIWJt9yTYMP3ehqclaivrt76kFAmA80akACgkQqclaivrt
76lmNAf+K8+BpPxNctjZO/WLuktbWGjezyM/yhftX3gPoo8YBrpACGQ4/HBs1mIn
7QYXMJMM2H3JI3HzAQ5YTKhQRvMamAm71SgcrbCZ+72cVwUkOpRd7PhxUNTsAOyG
1txJpZI9Na/bP7RiaRk3vk11wPB2oIiJz/FhT1By27U7j1rOoK+xBaU0+LpVIAJB
+ZhK+P/RoxCN+8/LQSW0M6sOxfyPeuj3E88tMW+vzutJ/puwsuFJhXhYt9I/d8JA
J04LcyV5m6Mv1omeykP6x6+dTmyar/VJMgQMm1PiOcimRCLNtJV8YAIK9nN5p1ok
hnj2rndapVwoSy6tLJ6kJ2aCgVCOlA==
=YGWX
-----END PGP SIGNATURE-----

--yq2w6x3aott2pfwm--