Received: by 2002:a05:6a10:8c0a:0:0:0:0 with SMTP id go10csp3185932pxb; Mon, 1 Mar 2021 03:58:57 -0800 (PST) X-Google-Smtp-Source: ABdhPJwMnfnhvLqZq0UPcE/6fTLQi12KIHYl2mzDHXND+HboA/9Dum+rqiiio2+rBnEFR+lLaD/5 X-Received: by 2002:aa7:cc8b:: with SMTP id p11mr16167432edt.284.1614599936924; Mon, 01 Mar 2021 03:58:56 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1614599936; cv=none; d=google.com; s=arc-20160816; b=H9c1pVpiQ/vQ4sgnILhfa4G/HUshyhuQU3B+qVRP6KQu/HyBi197TddNtP4zgU6qrE ULKkbYrewOsBqcnA2UM/SjVx0vgbXIVZHKuk4esawkvzjH6omzVduGdKs11uqPof60dO vsL294sD4c56Wfd4iKSt+tzEuU6qPOkEWpzhvLEWRQxCid7JxzQ15dfbdSSg12A80dyj /eD88yBxUaDARsipZRd5yEyMtkvl7LqhjDNUpwxii0m+Np7tFk4teWcduvPOJkuR9IFP 8AO3Kz5i0TcW9Uotg936bKIfjyH3YHRtNioiN89WHe/kxWxIOStqfN8OICUM4mR8vEsS oJRg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date; bh=/GIPBJRhMO2mfWR3SuK19mxRtHFK+PuMuQfBbbCg26Y=; b=KGJ3FtiAmA5dly+sXH6kwT1+OqEOPl5UPaQ2sCxzju4CwI44cNZHZ0biG8WN7TGFSJ wMWSuD7oE0KVSKT5Tl2meuGkllV/LsGY1pfL7Zu7EPolESUSjX7R1lFMPkZuo3o4BK+f /VoKPpBY+M0e4Szv/ga96mcVqCtgFWiB5G2oBQTLCUmnBx/Akq9HS5wEd9K9Zd3sQMBi kxpUkFwG/BkS4BDnV7+wZWDq5D4gKJPmSFtsrMandRfsFV/s67ORYtMUW/IlmVHtFhrM khlmbYw/F0XXIc6y51Hkx7W/YV3ytKbOgeZkqhfZ0Nec6SGSz73CA9t+YHjJFZ6Gllzn RC1g== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id o9si10903371eju.695.2021.03.01.03.58.34; Mon, 01 Mar 2021 03:58:56 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234930AbhCAL5K (ORCPT + 99 others); Mon, 1 Mar 2021 06:57:10 -0500 Received: from youngberry.canonical.com ([91.189.89.112]:40593 "EHLO youngberry.canonical.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234917AbhCALz2 (ORCPT ); Mon, 1 Mar 2021 06:55:28 -0500 Received: from ip5f5af0a0.dynamic.kabel-deutschland.de ([95.90.240.160] helo=wittgenstein) by youngberry.canonical.com with esmtpsa (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.86_2) (envelope-from ) id 1lGh8K-0002xh-4B; Mon, 01 Mar 2021 11:54:40 +0000 Date: Mon, 1 Mar 2021 12:54:39 +0100 From: Christian Brauner To: Christoph Hellwig Cc: Randy Dunlap , linux-kernel@vger.kernel.org, David Howells , Al Viro , linux-fsdevel@vger.kernel.org, "David P . Quigley" , James Morris Subject: Re: [PATCH -next] fs: libfs: fix kernel-doc for mnt_userns Message-ID: <20210301115439.2edodjidbi6kes2j@wittgenstein> References: <20210216042929.8931-1-rdunlap@infradead.org> <20210216042929.8931-2-rdunlap@infradead.org> <20210216084825.GA23845@lst.de> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20210216084825.GA23845@lst.de> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Feb 16, 2021 at 09:48:25AM +0100, Christoph Hellwig wrote: > On Mon, Feb 15, 2021 at 08:29:27PM -0800, Randy Dunlap wrote: > > Fix kernel-doc warning in libfs.c. > > > > ../fs/libfs.c:498: warning: Function parameter or member 'mnt_userns' not described in 'simple_setattr' > > Shouldn't the subject say simple_setattr instead of mnt_userns? > > Otherwise looks good: > > Reviewed-by: Christoph Hellwig So I've picked this up but just as an fyi b4 fell all over its face on this series always giving me partial patches or prefixing it with v2 or v3 or sm. Really strange, I'll report this to Konstantin. Christian