Received: by 2002:a05:6a10:8c0a:0:0:0:0 with SMTP id go10csp3265455pxb; Mon, 1 Mar 2021 06:02:17 -0800 (PST) X-Google-Smtp-Source: ABdhPJzJxHkzIYtefu2LWwzb57BJDqlciqphtOjbbQVv+7EEdt867kzvPLYjmr+yZC3ALc+in+C6 X-Received: by 2002:a17:906:be9:: with SMTP id z9mr15761969ejg.35.1614607336822; Mon, 01 Mar 2021 06:02:16 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1614607336; cv=none; d=google.com; s=arc-20160816; b=dvOMb2LMIhvVm+YzR5yIdRCA2wzK7nzaqNA1VtzlLr+f/Kh1qZIVajFMl6BTSid34U aHlj+HqYmD836NF8jqhQBRdDrzh+AQliLNx2sn5ydHT9Z7BD1h51K5G0PTr7zLJV2NeP VT5v/E+O2blHL55lPt/Puo7UsOghtc2ylXwZ4Pv4KBF+o8Vv6ag0DWgEUpfXN6xdLFYh 5E+tYIHtJ6tLr9/M3Qb2McY5tejFba6ftABDNTZxWl8Qe/rmUtYDlpTCdUHvHXyQ5NNh 2lQsTB121RTAFBhV2tAJXI/ckgrUrCQvGPcqoU3gd4eT17jpLuHoFh8VTcBcelKp2wM8 3oEQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:cc:to:subject:message-id:date:from:in-reply-to :references:mime-version:dkim-signature; bh=nKuWC3rVV9sra+4DDgdLnle85IT4vlB1n7DPoNwpayo=; b=adhQFFXs7OnU/pQHZK0xG2vbJYJdwuRGFrm6EprCn+VixvRhOSP02zGx12eAeJo0Kb ZAdy5RgFuiyX1vjBzro1xVYFqiZqIO36WmGGIHRVHsHmRDW9X+VywCr+NndVs46Sb4Oh t7FEC+aawyyxz15891tdaf7E0puoj8yIMDjuIu8KISdFo55+L9W1LxHSznGziYGd8fat MYKux+390G46CmajU4jxsRlqz8IlG0d+sa++9GXfWU9mVnKvgCB69eq/YguF3GXtWNQb IRSmEkyf/s0KDx6gqIR9bbBUHxEm9VltSzxui7dpYA9MSIXidpwOsXA3+qL6GRT9gRkW S9IQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@baylibre-com.20150623.gappssmtp.com header.s=20150623 header.b=STgKjcbb; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id gz5si8539571ejb.19.2021.03.01.06.01.45; Mon, 01 Mar 2021 06:02:16 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@baylibre-com.20150623.gappssmtp.com header.s=20150623 header.b=STgKjcbb; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236121AbhCAN6s (ORCPT + 99 others); Mon, 1 Mar 2021 08:58:48 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60934 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236122AbhCAN6q (ORCPT ); Mon, 1 Mar 2021 08:58:46 -0500 Received: from mail-ed1-x533.google.com (mail-ed1-x533.google.com [IPv6:2a00:1450:4864:20::533]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 34D39C06178A for ; Mon, 1 Mar 2021 05:58:05 -0800 (PST) Received: by mail-ed1-x533.google.com with SMTP id v13so4375996edw.9 for ; Mon, 01 Mar 2021 05:58:05 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=nKuWC3rVV9sra+4DDgdLnle85IT4vlB1n7DPoNwpayo=; b=STgKjcbbPqlcVj+Yg1do/AfuQIj/wmBwy56Kj0C4VQoXnZHFAiF79BD5kiIcPWzgDB /ZXT0GpsZgkfB8E5WMMZcT285MlbPXod+cZrK1EXjwzKrhy35bATHm0CPmObm0oq2iwE oEI+69fCBlum8d1WP/UXUJFU4vArguEIHlK4IC8nudxpjtvVAcAyL0j06R8Zfiu+2jag SuVppZD1+mT0+pC3MHTdWLPRlXomrKYGro0wq7F2vycFK/G5nxbDhmwfPKJpv0RT4Ihn 5eUckBWRXm8wdtgsfsoDYYpwSvGKOLFIDSToQdvRq+F7T+vF6H2YKs+tBmUrTssHgTFq mByg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=nKuWC3rVV9sra+4DDgdLnle85IT4vlB1n7DPoNwpayo=; b=OVv48Ote3LINxMSoijMmbuHvP8vQb0CWCTY5yPLH/Gdq0XAngOzitbPCSl70dEH+s9 H1MKwNbX82mvVRhxN5hx7PKb/O7aCWEQDApCG6Bgc1GDxuaUveqnjZLHLROWvE8fvDKt Ppt4qe4pLdmpmG4x5B3GhVjyFGf91MUryYbaYh0C49Jt6dOGNTpOBskmF/sBbI64Xhx6 3ebU1yu0qWDgTaAe5CzpSWjDXYkNelYtfBsf6unLsndWSrbdEMKGQa6lDXMjKUNhrf04 iDE+aUDivbYcUF28wMmkLpEBJn/NG/bKq2GjwRRVOhaPTBAmA4reMZON/xy7jm9IGVLy fosw== X-Gm-Message-State: AOAM530ZNU1xiipyNoTKf2NpadRMt7HrdmpW1PDsHuwNQgBAZM5/F2LF rAhYrVBafJ5tVdmdRsDaj3Cd7X7438Tc1lTZg15pFw== X-Received: by 2002:a05:6402:35c8:: with SMTP id z8mr3291764edc.341.1614607083797; Mon, 01 Mar 2021 05:58:03 -0800 (PST) MIME-Version: 1.0 References: <1614069358-50943-1-git-send-email-yang.lee@linux.alibaba.com> In-Reply-To: From: Bartosz Golaszewski Date: Mon, 1 Mar 2021 14:57:53 +0100 Message-ID: Subject: Re: [PATCH] gpiolib: acpi: Add missing IRQF_ONESHOT To: Andy Shevchenko Cc: Yang Li , Mika Westerberg , Linus Walleij , linux-gpio , ACPI Devel Maling List , LKML Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Feb 25, 2021 at 4:07 PM Andy Shevchenko wrote: > > On Tue, Feb 23, 2021 at 01:51:53PM +0200, Andy Shevchenko wrote: > > On Tue, Feb 23, 2021 at 04:35:58PM +0800, Yang Li wrote: > > > fixed the following coccicheck: > > > ./drivers/gpio/gpiolib-acpi.c:176:7-27: ERROR: Threaded IRQ with no > > > primary handler requested without IRQF_ONESHOT > > > > > > Make sure threaded IRQs without a primary handler are always request > > > with IRQF_ONESHOT > > > > Acked-by: Andy Shevchenko > > Bart, I guess I will collect this in my branch and send you a PR. > I have more fixes to that file anyway. > > -- > With Best Regards, > Andy Shevchenko > > Fine with me!