Received: by 2002:a05:6a10:8c0a:0:0:0:0 with SMTP id go10csp3366066pxb; Mon, 1 Mar 2021 08:15:34 -0800 (PST) X-Google-Smtp-Source: ABdhPJy9WlGkSaPpCS0yd6ZbzgzEELpStYNs62o+zaWDU12g+Lfg9Mbx/Z4dAYSjP6ULP0LkVRV6 X-Received: by 2002:a05:6402:cb8:: with SMTP id cn24mr4643927edb.105.1614615334486; Mon, 01 Mar 2021 08:15:34 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1614615334; cv=none; d=google.com; s=arc-20160816; b=RDYy+XS9mZElFCd2iLgRBLY3fHywbSBLV9s/Rfe1PE482O83NXtP7MWkcR/GIUP3LG 3gKw7qLfOKtRl/b1XY8q5sGVO8No20AQudmISEyviAFSTELNfLemVC4hBeRfItW3yyop d2uoYupIWQkedhztddbPM2ognpL2M0k2pPFiSII9lWaFn5gsSsRL6PME7JLDWxtlk0iz y2qRzi8wNFkIkAYzh0+y/VJHlHa4Yfsk4AFvXRNRmUBkOsxeFIMXPE4L7neP2N5znCwZ 3nylwtY+XHipKc44W6TW94sC/SV5YvEuYUCU5mZ24lUwor8Kft1Q4VZJEKf6q/MD2fMo KwOw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:message-id:date:subject:cc:to:from:dmarc-filter :sender:dkim-signature; bh=o09V222UbtF+m7URYAndN7kvp3AxBbab4TCWrtmYtDo=; b=TeTRo9BHpmfCByJ1HMhE5Xc1r/Tl9VuXDQL153VCm4KlAaFk7D1OQCEzPxkFoUb8eM 5eGwEKoUK0qFovcabJbr0q7gapDIJxvKl6jsGaJUq+O86hg23ETbIkV41ufvOyuDYCCW D7g3sc7pD0RHxjNb5xx6gy5PcWLPpkXt9rQ6pB/sgxuFR3Q/Wi0hQr6lOhFbj/XFRLqf pdb7OanfukTgFoBFyOafO0Pd5W1xx3yG/1U5RnqWMN2OZqMG0DYq2Wr1uvkogy4+BF80 1HbdY87Y1rV6yFFQ/7TRYYCdkv88FR5CZIMQNVbSCwGN+1YvA8MAJyBs9smge++Vzbnx d7Gw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@mg.codeaurora.org header.s=smtp header.b="bQO/X5hM"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id i2si13658749edb.432.2021.03.01.08.15.03; Mon, 01 Mar 2021 08:15:34 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@mg.codeaurora.org header.s=smtp header.b="bQO/X5hM"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237532AbhCAQOW (ORCPT + 99 others); Mon, 1 Mar 2021 11:14:22 -0500 Received: from m42-2.mailgun.net ([69.72.42.2]:59935 "EHLO m42-2.mailgun.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S237503AbhCAQLg (ORCPT ); Mon, 1 Mar 2021 11:11:36 -0500 DKIM-Signature: a=rsa-sha256; v=1; c=relaxed/relaxed; d=mg.codeaurora.org; q=dns/txt; s=smtp; t=1614615076; h=Message-Id: Date: Subject: Cc: To: From: Sender; bh=o09V222UbtF+m7URYAndN7kvp3AxBbab4TCWrtmYtDo=; b=bQO/X5hM0zm3ZzZ2v2QXWJYwa9uP5yNBGiRgCrczl8mdhqTFB/qGIKzF8nDC+WImfjXyC4c/ FtXQ/zrgXPAKU7h1Z1mYyrlTbsAbwLLkmfRRVoWoqW3Cpa8KdiuOErcVV+CI5l6U5ftqAWl6 PF+KNIWEw4W5KwucMB2aj8ju7Oo= X-Mailgun-Sending-Ip: 69.72.42.2 X-Mailgun-Sid: WyI0MWYwYSIsICJsaW51eC1rZXJuZWxAdmdlci5rZXJuZWwub3JnIiwgImJlOWU0YSJd Received: from smtp.codeaurora.org (ec2-35-166-182-171.us-west-2.compute.amazonaws.com [35.166.182.171]) by smtp-out-n02.prod.us-west-2.postgun.com with SMTP id 603d12076bfdd67a00fd4ebc (version=TLS1.2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256); Mon, 01 Mar 2021 16:10:47 GMT Sender: kgunda=codeaurora.org@mg.codeaurora.org Received: by smtp.codeaurora.org (Postfix, from userid 1001) id 34096C43466; Mon, 1 Mar 2021 16:10:47 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-caf-mail-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.9 required=2.0 tests=ALL_TRUSTED,BAYES_00,SPF_FAIL autolearn=no autolearn_force=no version=3.4.0 Received: from kgunda-linux.qualcomm.com (unknown [202.46.22.19]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: kgunda) by smtp.codeaurora.org (Postfix) with ESMTPSA id E958AC433C6; Mon, 1 Mar 2021 16:10:41 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org E958AC433C6 Authentication-Results: aws-us-west-2-caf-mail-1.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: aws-us-west-2-caf-mail-1.web.codeaurora.org; spf=fail smtp.mailfrom=kgunda@codeaurora.org From: Kiran Gunda To: bjorn.andersson@linaro.org, jingoohan1@gmail.com, lee.jones@linaro.org, b.zolnierkie@samsung.com, dri-devel@lists.freedesktop.org, daniel.thompson@linaro.org, jacek.anaszewski@gmail.com, pavel@ucw.cz, robh+dt@kernel.org, mark.rutland@arm.com, linux-leds@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Cc: linux-arm-msm@vger.kernel.org, phone-devel@vger.kernel.org, Kiran Gunda Subject: [PATCH V4 0/2] Fix WLED FSC Sync and brightness Sync settings Date: Mon, 1 Mar 2021 21:40:28 +0530 Message-Id: <1614615030-12703-1-git-send-email-kgunda@codeaurora.org> X-Mailer: git-send-email 2.7.4 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org This patch series has the following two WLED fixes 1. As per the current implementation, for WLED5, after the FSC (Full Scale Current) update the driver is incorrectly toggling the MOD_SYNC register instead of toggling the SYNC register. The patch 1/2 fixes this by toggling the SYNC register after FSC update. 2. Currently, the sync bits are set-then-cleared after FSC and brightness update. As per hardware team recommendation the FSC and brightness sync takes place from clear-then-set transition of the sync bits. The patch 2/2 fies this issue. Changes from V3: 1. Updated the patch description as per Daneil's suggestion. 2. Added Daniel's "Reviewed-by" tag for patch 2/2. 3. Updated the cover letter to use "set" and "clear" properly. Changes from V2: 1. Added Daniel's "Reviewed-by" tag for patch 1/2. 2. Updated the patch 2/2 description with "set" and "clear" terminology instead of "1" and "0". 3. Updated the cover letter with "set" and "clear" terminology instead of "1" and "0". Changes from V1: 1. Updated the cover letter. 2. Updated the description of the patches as per Daniel's suggestion. Kiran Gunda (2): backlight: qcom-wled: Fix FSC update issue for WLED5 backlight: qcom-wled: Correct the sync_toggle sequence drivers/video/backlight/qcom-wled.c | 37 +++++++++++++++++++++++++------------ 1 file changed, 25 insertions(+), 12 deletions(-) -- The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, a Linux Foundation Collaborative Project