Received: by 2002:a05:6a10:8c0a:0:0:0:0 with SMTP id go10csp3553824pxb; Mon, 1 Mar 2021 13:10:14 -0800 (PST) X-Google-Smtp-Source: ABdhPJy+70+WMR95UzOOSGco26jnT2Ab93ruO+acldJIBGxqn4lSmXUFDPNKor/GGRJges6ufZJy X-Received: by 2002:a17:906:3052:: with SMTP id d18mr18054190ejd.530.1614633014669; Mon, 01 Mar 2021 13:10:14 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1614633014; cv=none; d=google.com; s=arc-20160816; b=wOF1ELdFAGfkPejdz+OdIed3KyW+mNjpl0+wEjyn8r1fns/bjKOI4ccVdHjzn40dFO g/Tfd4CcX2vDXMU1nn2I+RDHQMIBcGNdmofiwQXvMeUROf02McVI8w1NpbJWS23T9CPO 5NyC4Bkx59nIATKpcrRjxiOT4xHpvdju8jJr7p5c5p39TyygfYf7aYyKP6CoOuP/SlHY 3owI7OuJMq1BKAozHGhI1DWuEe4UBdheotcm4a+/XhSREYScW46L+Y1VR2mhz4d86IQe L/lPtL0WqP18iKT4ylzYRiMkjr4NdNZEw8CUuFyg3t8JpdRSDlCtvX7sSDe4pqJeqEHQ /FOA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=+7fQgi+MRI3CCwaafeehK1AJaZVHQAHole1WglWLv8A=; b=IXXgccN3tS+8iBbldkCgs5gJ6tYQKC/BT7GcA8N7Kd9Iz2abGuK+kaNuRoXndYbXvl li4kkJWXHVtPzAyQg0v1Hmy8rME4EEVRCDggTvAvtbqVMTlxYJ1YXEbprpbKZx2ROmXr BkMs9Byf3nSpm2Ss1S5PKjxsXVCCeRjpdCXmCeZntqnyBmdDIdHiENuJ7MICQNrOZ0Hl 5SMAXPTIa2ENSl/3yfnmPBvy6Y9MpqZ+mQs1q9Kq3tadTuy4i20PPzgT/sy1QKvxA2B8 pmOuFmCd6GiMeP/OqGn9RTFBrI4bO+QJL0ZDwIsGRKvXpqucKJq58IorSNzmxFA3rcjC a6yQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=GQOvT4R8; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id a20si12026126ejg.492.2021.03.01.13.09.51; Mon, 01 Mar 2021 13:10:14 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=GQOvT4R8; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S239345AbhCAVGu (ORCPT + 99 others); Mon, 1 Mar 2021 16:06:50 -0500 Received: from mail.kernel.org ([198.145.29.99]:47630 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S237728AbhCARNI (ORCPT ); Mon, 1 Mar 2021 12:13:08 -0500 Received: by mail.kernel.org (Postfix) with ESMTPSA id 5848964EE7; Mon, 1 Mar 2021 16:43:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1614617029; bh=EM+Wqcb0VfnGORtrM6ZqObuFYdx4JuuV92yGw2kEbpc=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=GQOvT4R8VBqzRL50+t8qcvf0yCnG/F3qajc3OMn1nBbqRBS9pCiMEsVcV6I3ehaJn YxduQ6+d/m7049Y/xCXI1cuCN2Vz1hjvnAP9dkSEiSdzxRIZmbquyfFAVi2wFTLLFW AlYM02yUqQBsDQp8vZjvdn1KkGw3Ycdpwb8bSNqI= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Saurav Kashyap , Javed Hasan , GR-QLogic-Storage-Upstream@marvell.com, "James E.J. Bottomley" , "Martin K. Petersen" , linux-scsi@vger.kernel.org, kernel test robot , Randy Dunlap , Sasha Levin Subject: [PATCH 4.19 177/247] scsi: bnx2fc: Fix Kconfig warning & CNIC build errors Date: Mon, 1 Mar 2021 17:13:17 +0100 Message-Id: <20210301161040.317469047@linuxfoundation.org> X-Mailer: git-send-email 2.30.1 In-Reply-To: <20210301161031.684018251@linuxfoundation.org> References: <20210301161031.684018251@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Randy Dunlap [ Upstream commit eefb816acb0162e94a85a857f3a55148f671d5a5 ] CNIC depends on MMU, but since 'select' does not follow any dependency chains, SCSI_BNX2X_FCOE also needs to depend on MMU, so that erroneous configs are not generated, which cause build errors in cnic. WARNING: unmet direct dependencies detected for CNIC Depends on [n]: NETDEVICES [=y] && ETHERNET [=y] && NET_VENDOR_BROADCOM [=y] && PCI [=y] && (IPV6 [=n] || IPV6 [=n]=n) && MMU [=n] Selected by [y]: - SCSI_BNX2X_FCOE [=y] && SCSI_LOWLEVEL [=y] && SCSI [=y] && PCI [=y] && (IPV6 [=n] || IPV6 [=n]=n) && LIBFC [=y] && LIBFCOE [=y] riscv64-linux-ld: drivers/net/ethernet/broadcom/cnic.o: in function `.L154': cnic.c:(.text+0x1094): undefined reference to `uio_event_notify' riscv64-linux-ld: cnic.c:(.text+0x10bc): undefined reference to `uio_event_notify' riscv64-linux-ld: drivers/net/ethernet/broadcom/cnic.o: in function `.L1442': cnic.c:(.text+0x96a8): undefined reference to `__uio_register_device' riscv64-linux-ld: drivers/net/ethernet/broadcom/cnic.o: in function `.L0 ': cnic.c:(.text.unlikely+0x68): undefined reference to `uio_unregister_device' Link: https://lore.kernel.org/r/20210213192428.22537-1-rdunlap@infradead.org Fixes: 853e2bd2103a ("[SCSI] bnx2fc: Broadcom FCoE offload driver") Cc: Saurav Kashyap Cc: Javed Hasan Cc: GR-QLogic-Storage-Upstream@marvell.com Cc: "James E.J. Bottomley" Cc: "Martin K. Petersen" Cc: linux-scsi@vger.kernel.org Reported-by: kernel test robot Signed-off-by: Randy Dunlap Signed-off-by: Martin K. Petersen Signed-off-by: Sasha Levin --- drivers/scsi/bnx2fc/Kconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/scsi/bnx2fc/Kconfig b/drivers/scsi/bnx2fc/Kconfig index d401a096dfc7e..2eb2476852b11 100644 --- a/drivers/scsi/bnx2fc/Kconfig +++ b/drivers/scsi/bnx2fc/Kconfig @@ -4,6 +4,7 @@ config SCSI_BNX2X_FCOE depends on (IPV6 || IPV6=n) depends on LIBFC depends on LIBFCOE + depends on MMU select NETDEVICES select ETHERNET select NET_VENDOR_BROADCOM -- 2.27.0