Received: by 2002:a05:6a10:8c0a:0:0:0:0 with SMTP id go10csp3932130pxb; Tue, 2 Mar 2021 02:12:21 -0800 (PST) X-Google-Smtp-Source: ABdhPJztPfjdq1G2aJfCKwrnM0iRNXPvlDKxVtVkaiYT5o62ErDVRad12wVqPtTrH2pRrGbT4WCI X-Received: by 2002:a50:f38f:: with SMTP id g15mr12110441edm.262.1614679940901; Tue, 02 Mar 2021 02:12:20 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1614679940; cv=none; d=google.com; s=arc-20160816; b=Q7jWEevCIEvxkipHeqKE3I0JGHpR2DbOmVEQKG7GriIAf1mevE9J/rqYLTADO2hss7 z9GA1aVNlqh4q/a+6DVZzJPnbbH0hHEkDmFDfOiuD9/0+Pq2ZT8yxramojmChhgIFetX hW40awGL7BI9tZX7wvonZd2yoKy3L91LO1nC8EeM5zwOs1RbsyD3hNE9EbCYvSTeMsFv xAcoaItIkND/0RYnzygPl6XOVYODzrDXtOs4+bRIpbA9QvNItVPawJYik+t0AdMXVJG6 Gsghjj+4WVXyejBCP1l7bMnH7qocpoGrNLHFuCum899EBaEoB7Rbk26FSPhYhYIyUkem 5aVA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=KpoRGfZZXuOaFfiURiABBjIPNduMPyiCt0Og0JHYcLE=; b=EmnrmLiHkDco8fQ7mH87Ag6a7WNdH+MWRHYBHyI+4ZH0t5idnTrnYOLr5a/iiMNi/e 06igm3SbmSGooAwZU0nnzUElHVxi8WR3obHUIfUiqJam47+HoVCKobnlhz8G5Jhi1Y5c gKV76GJONHHM2nr2F0CwzU3VQjDbmlP7W7afKx36Yo3fCC5qpfsY9QJV84QNKW6EoGTw 6TgjaTFJDNjF70tit0bVuSynnHhPkOzzBlsNIbDI+xHYLxDbOZkOzWFPZcgeiqZZqvEW qLpveUuALLfuQmfZcadhxHY5+wUnLzCZR4AJJOzb6X/euiA7o5Sh0fgjKFp3vzjUs8TY zVQw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=lfwxogrm; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id m2si1905601edr.104.2021.03.02.02.11.58; Tue, 02 Mar 2021 02:12:20 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=lfwxogrm; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1379542AbhCBB3b (ORCPT + 99 others); Mon, 1 Mar 2021 20:29:31 -0500 Received: from mail.kernel.org ([198.145.29.99]:43898 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S241335AbhCATRl (ORCPT ); Mon, 1 Mar 2021 14:17:41 -0500 Received: by mail.kernel.org (Postfix) with ESMTPSA id 0993165256; Mon, 1 Mar 2021 17:28:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1614619697; bh=/FSxBGnA2Olc9paa9qY+7DY8GR4LqnorU27kcoDcJFc=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=lfwxogrm1i5dHVllos8v8peSmLc0tR9xsHF2PQ1NMohoryiQBu74Sdy8l1aRtgxbJ S4hXzskrWnGgjaYYCu1Ub3t0nG+8G456hfzYvG6QMcYC62Kwj8C5aJAZo21s2csoXV uTZa1sabekM/WHSVWSdSMj5P0yJAuEHeyWmNaB+M= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Corentin Labbe , Herbert Xu Subject: [PATCH 5.10 548/663] crypto: sun4i-ss - initialize need_fallback Date: Mon, 1 Mar 2021 17:13:16 +0100 Message-Id: <20210301161208.985907212@linuxfoundation.org> X-Mailer: git-send-email 2.30.1 In-Reply-To: <20210301161141.760350206@linuxfoundation.org> References: <20210301161141.760350206@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Corentin Labbe commit 4ec8977b921fd9d512701e009ce8082cb94b5c1c upstream. The need_fallback is never initialized and seem to be always true at runtime. So all hardware operations are always bypassed. Fixes: 0ae1f46c55f87 ("crypto: sun4i-ss - fallback when length is not multiple of blocksize") Cc: Signed-off-by: Corentin Labbe Signed-off-by: Herbert Xu Signed-off-by: Greg Kroah-Hartman --- drivers/crypto/allwinner/sun4i-ss/sun4i-ss-cipher.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- a/drivers/crypto/allwinner/sun4i-ss/sun4i-ss-cipher.c +++ b/drivers/crypto/allwinner/sun4i-ss/sun4i-ss-cipher.c @@ -194,7 +194,7 @@ static int sun4i_ss_cipher_poll(struct s unsigned int obo = 0; /* offset in bufo*/ unsigned int obl = 0; /* length of data in bufo */ unsigned long flags; - bool need_fallback; + bool need_fallback = false; if (!areq->cryptlen) return 0;