Received: by 2002:a05:6a10:8c0a:0:0:0:0 with SMTP id go10csp3950710pxb; Tue, 2 Mar 2021 02:50:40 -0800 (PST) X-Google-Smtp-Source: ABdhPJw9D88IgNh/axmBlrzefbGF4HIYQG0DtiollinDVuAcsntiwDiA9cLqZsa8GtapLD6qmU35 X-Received: by 2002:a17:906:5797:: with SMTP id k23mr4079529ejq.515.1614682240461; Tue, 02 Mar 2021 02:50:40 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1614682240; cv=none; d=google.com; s=arc-20160816; b=Rxnt/dWap8jLJPX6dsX5ho1Z/qJU8AKJvDW7tpZ1KSCHPUPlY7LRgXlhxVdjWw5NH9 LuERDA2weVAPdxdxXQwGQaQxRYatBEXSYESEI6Utymws1W3VXcc+FTHh7qFDcnUs09mG hfiiZb+wngLzZVyrXSO76AHw09C+nzOEoyuKhhhWd4vo86RAHUxt+ReKPvasa3jaRfbv wZ8+hdFJ3JDhWIU653B6BUv1VyS2pUGbWk9j0oRzcljcKwL/o2b8svK2dTmK47DvBylS 74LYjna1lZ75MnpcMy0SOcA1HYwBXoQu3pC3m4tphx8VgjBlfadLNWYfRRowcreZrheX JGDw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=aDoRO5hHNqUuVFg7kTtqjf4H1kwXIN9FAphoAy5JTVg=; b=nuwNI44aMLipupWo8Id8/PrBCLpSVSHyzxityyq4ikmtTlVrvQjh0wU+YmAD90vcEN BKqSa4j+FXZyIT75ase+m8ATpPOmqtwwsbynmYb5K33Wu/hypob11h1qM33TDhKzqpL4 bqXN9WKQs6QBTg7wdt0VWaQbC1AcZKfC0tIBWzH7UplSoxiXn8C/3z8EwiNNZoZdVHl9 jZdKVavt4WLQ1hMNaMaG/pTMzWhbT+qslELeSbpMtkC77cWRH0efpPxB+5HD8JU9FXVw vck4WH+wv5sjPgxg8HaehQrYn8fHlITocSidNlpgEDRjUafliF0bIna6D42u3oFK6HUI KVcQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=PHEtYTXd; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id a1si13678706edx.487.2021.03.02.02.50.17; Tue, 02 Mar 2021 02:50:40 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=PHEtYTXd; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1380201AbhCBBtJ (ORCPT + 99 others); Mon, 1 Mar 2021 20:49:09 -0500 Received: from mail.kernel.org ([198.145.29.99]:48602 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S241402AbhCAT0p (ORCPT ); Mon, 1 Mar 2021 14:26:45 -0500 Received: by mail.kernel.org (Postfix) with ESMTPSA id 073B96522E; Mon, 1 Mar 2021 17:25:42 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1614619543; bh=7G2YAo0+hoEmD0oZPxqeoM7qiu2sKVdSt7j5BaCJlT8=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=PHEtYTXd+UXAKUNyoLEmp7SrWLRvAgr05XBlFf+q+vVn82P6+/sM84vTGexDCEfzM 89sNLM+b32penwShzYt751GhJNWrq6lvemy5ZrhMoZCwPu2iiZ+IBvgE2/q867lC4g HjyhwQE5MrwURkeaBdH/kT8KQoI5+lmxTKhAxoyE= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, =?UTF-8?q?Josef=20O=C5=A1kera?= , Heiner Kallweit , Jakub Kicinski , Sasha Levin Subject: [PATCH 5.10 462/663] r8169: fix jumbo packet handling on RTL8168e Date: Mon, 1 Mar 2021 17:11:50 +0100 Message-Id: <20210301161204.732324686@linuxfoundation.org> X-Mailer: git-send-email 2.30.1 In-Reply-To: <20210301161141.760350206@linuxfoundation.org> References: <20210301161141.760350206@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Heiner Kallweit [ Upstream commit 6cf739131a15e4177e58a1b4f2bede9d5da78552 ] Josef reported [0] that using jumbo packets fails on RTL8168e. Aligning the values for register MaxTxPacketSize with the vendor driver fixes the problem. [0] https://bugzilla.kernel.org/show_bug.cgi?id=211827 Fixes: d58d46b5d851 ("r8169: jumbo fixes.") Reported-by: Josef Oškera Tested-by: Josef Oškera Signed-off-by: Heiner Kallweit Link: https://lore.kernel.org/r/b15ddef7-0d50-4320-18f4-6a3f86fbfd3e@gmail.com Signed-off-by: Jakub Kicinski Signed-off-by: Sasha Levin --- drivers/net/ethernet/realtek/r8169_main.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/ethernet/realtek/r8169_main.c b/drivers/net/ethernet/realtek/r8169_main.c index 75f774347f6d1..cfcc3ac613189 100644 --- a/drivers/net/ethernet/realtek/r8169_main.c +++ b/drivers/net/ethernet/realtek/r8169_main.c @@ -2351,14 +2351,14 @@ static void r8168dp_hw_jumbo_disable(struct rtl8169_private *tp) static void r8168e_hw_jumbo_enable(struct rtl8169_private *tp) { - RTL_W8(tp, MaxTxPacketSize, 0x3f); + RTL_W8(tp, MaxTxPacketSize, 0x24); RTL_W8(tp, Config3, RTL_R8(tp, Config3) | Jumbo_En0); RTL_W8(tp, Config4, RTL_R8(tp, Config4) | 0x01); } static void r8168e_hw_jumbo_disable(struct rtl8169_private *tp) { - RTL_W8(tp, MaxTxPacketSize, 0x0c); + RTL_W8(tp, MaxTxPacketSize, 0x3f); RTL_W8(tp, Config3, RTL_R8(tp, Config3) & ~Jumbo_En0); RTL_W8(tp, Config4, RTL_R8(tp, Config4) & ~0x01); } -- 2.27.0