Received: by 2002:a05:6a10:8c0a:0:0:0:0 with SMTP id go10csp4004206pxb; Tue, 2 Mar 2021 04:26:57 -0800 (PST) X-Google-Smtp-Source: ABdhPJzcOyEu+/IW5gRVJFN7zR8/SkHMWBXUJt1U0aFrO65CSzZtHRd+gABUqj6o7K/4XjvKoJea X-Received: by 2002:a17:906:1a4b:: with SMTP id j11mr20806096ejf.55.1614688017534; Tue, 02 Mar 2021 04:26:57 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1614688017; cv=none; d=google.com; s=arc-20160816; b=MzxY9VMbtIUowNlpGIpYIHqb7blw9ro3QqCD8vEUGGjYC+UYmNit9Com/2yUtMKKqZ cQ47tXy/BoLJlPjo+XGVDfVWetzEmM3/WPSmgKY1eFCtzzyKrI5+JYMQN5/zgmLSEXhP qpWqorz7llzk5jQUV/ortys2UnW5TbkBiv+U4Uo+rNVFtuakNxc5d/Hd1dURU8GPFwPZ 5npTf9pVMheaa8+7nwRv86j+x/aT21BPmLHlyP3TTjlB11jA2aG0IjLTkh67F/y4psro 4wWBYI9cBBhXZE5M6V8nHDebgFp+9ZWshE95noxFQICSPXytpD7Pbyp0ojazBRIjxI1F T4YA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=D7kC0TU8t3v4yTqk0zffkH8yCMPz+8mWgd4xfG24fUg=; b=P0yMFVvIc2oSDTl6tFYyCuCjoW6sSpi/agAu61AnLlcYTo1nf8EssIIz1Pnt6Yrt4p Dg3UVkR/IjzCT76wS2ot8WEOHAsXGXlIiB5Y+4aSmDjIP6U6kMUepgxR9T9yu0PYyRWC 2GnLutApuHayGCFWb0E6cSBZmuHEG+BlNxKvmAXRWbE7Fc0tIDXzesAU6Y5un99Ir75J t8dEMCRXYpxqOAL41am1mwoBjx0ZyAYlr6SmkBL8H3JbelH2YOTA8oJHk6r8oQp3XtHs 0/OmH3G8EjMj5V8DDyNnj5McDRGeAuzB/lxE8/nezPnHIL1LgcKN9CMR3Ly66mpoi1hS znyw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=UEkzQL0t; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id c11si15325871ejz.595.2021.03.02.04.26.31; Tue, 02 Mar 2021 04:26:57 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=UEkzQL0t; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1442754AbhCBCQA (ORCPT + 99 others); Mon, 1 Mar 2021 21:16:00 -0500 Received: from mail.kernel.org ([198.145.29.99]:55168 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S242175AbhCAToB (ORCPT ); Mon, 1 Mar 2021 14:44:01 -0500 Received: by mail.kernel.org (Postfix) with ESMTPSA id 1B38B64FEB; Mon, 1 Mar 2021 16:38:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1614616686; bh=E7Tk0i72pvfouaq8NlhVnHw3nG/pHQV2A2PUJiC/pGE=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=UEkzQL0t0cVRVQsM1X8dOv/l6XA6Irbps7bM0Jbn13QhOIzwTYELh2D8y5MWXPuZG WjcTI4mr/rFMnQjqfK43sLDwbDVtsndMvmjHtxYYeQC4W/Wr94ckilQhXd9WNqGloI R1YnagUUrImopiOpAgjqCcKp0qjXdqfCy6Cld4dA= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Krzysztof Kozlowski , Sasha Levin Subject: [PATCH 4.19 030/247] ARM: dts: exynos: correct PMIC interrupt trigger level on Spring Date: Mon, 1 Mar 2021 17:10:50 +0100 Message-Id: <20210301161033.173466136@linuxfoundation.org> X-Mailer: git-send-email 2.30.1 In-Reply-To: <20210301161031.684018251@linuxfoundation.org> References: <20210301161031.684018251@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Krzysztof Kozlowski [ Upstream commit 77e6a5467cb8657cf8b5e610a30a4c502085e4f9 ] The Samsung PMIC datasheets describe the interrupt line as active low with a requirement of acknowledge from the CPU. Without specifying the interrupt type in Devicetree, kernel might apply some fixed configuration, not necessarily working for this hardware. Fixes: 53dd4138bb0a ("ARM: dts: Add exynos5250-spring device tree") Signed-off-by: Krzysztof Kozlowski Link: https://lore.kernel.org/r/20201210212903.216728-4-krzk@kernel.org Signed-off-by: Sasha Levin --- arch/arm/boot/dts/exynos5250-spring.dts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/arm/boot/dts/exynos5250-spring.dts b/arch/arm/boot/dts/exynos5250-spring.dts index 3d501926c2278..2355c53164840 100644 --- a/arch/arm/boot/dts/exynos5250-spring.dts +++ b/arch/arm/boot/dts/exynos5250-spring.dts @@ -108,7 +108,7 @@ compatible = "samsung,s5m8767-pmic"; reg = <0x66>; interrupt-parent = <&gpx3>; - interrupts = <2 IRQ_TYPE_NONE>; + interrupts = <2 IRQ_TYPE_LEVEL_LOW>; pinctrl-names = "default"; pinctrl-0 = <&s5m8767_irq &s5m8767_dvs &s5m8767_ds>; wakeup-source; -- 2.27.0