Received: by 2002:a05:6a10:8c0a:0:0:0:0 with SMTP id go10csp4235142pxb; Tue, 2 Mar 2021 09:49:49 -0800 (PST) X-Google-Smtp-Source: ABdhPJy6ns1hIyvVFDqKQTGdiQbeqFkb/HypDzVwRgOvXOI2sTQNVFtKWojxz6UsDM1q1X8vOs3B X-Received: by 2002:a17:907:3fa3:: with SMTP id hr35mr22069951ejc.418.1614707388810; Tue, 02 Mar 2021 09:49:48 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1614707388; cv=none; d=google.com; s=arc-20160816; b=dmjGdoOa9FPMvO2SjtBET1jAw1Uv0ks6xWAdQhleJBTNBM9wdDpo5JlqtIW3d4Tdxq jL8NJVjo/qFmpmfJwhK2UtFg6fdaZU/adNU41NZi31s4Jo5w4uijBjjh1ALlNt2GwCC9 dcb50uyIjqIyG2iL2JmrsiPPJPGJTkRckOGlqzABgBZ+FkbrJvIJP4i5N0iHTZcRrarY RI0yv4zP/dWW0U0bPMQ1E/uiYB5mt8VNs3rcB9zGiizWYaEU84hi4V0+r8Yky8FMBk2v orqozOAtfU8ODdFfGtfuZDPQVreSAR/BqDeenSTLpQalnK07gqQE/tBSRMWdZsreVskA XGpA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date; bh=UqWHRXhMZe7NjwkRc366sTU7H4Rhc+SWdyMdAGvjm+0=; b=aM/xhs8wZoTbmNR7BMIGZi86F38vOwBfuAfZOSBBYuHu/60zcKr2W3FpBecKk6Sstd SgtDzaHjkYbq/OyJMi8qPY4A7Gs47kwbEd3tbouiJ4KVgvW/9aBDhxmHQtCTaspCeSID Zp2qPve1mqL34wpoqQe6LG0k49oNsAWJj19EsWwaChsVjVYVA18gleHxARWo0qhO78Yq +UFPeJ370mMow5498elUmrinHtGewGtR8x+1maM7OiwSh1RFw0akat7qEGwOaW6dAa+P EZXR79jUtfn1acbKjFd7ElXuFRtbY7BCHu01orgI3hViWR1O+WrnxoJ6QkN5wG9eEjtI AzmQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id x6si4351285ejb.380.2021.03.02.09.49.25; Tue, 02 Mar 2021 09:49:48 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1575268AbhCBDy4 (ORCPT + 99 others); Mon, 1 Mar 2021 22:54:56 -0500 Received: from mx2.suse.de ([195.135.220.15]:38150 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S245292AbhCAWTb (ORCPT ); Mon, 1 Mar 2021 17:19:31 -0500 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id B108EAD29; Mon, 1 Mar 2021 22:18:48 +0000 (UTC) Date: Mon, 1 Mar 2021 23:18:46 +0100 From: Oscar Salvador To: David Hildenbrand Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, kernel test robot , Andrew Morton , Michal Simek , Mike Rapoport , Thomas Gleixner , Arvind Sankar , Ira Weiny , Randy Dunlap , Anshuman Khandual Subject: Re: [PATCH v1] microblaze: tag highmem_setup() with __meminit Message-ID: <20210301221846.GA4744@localhost.localdomain> References: <20210301114749.47914-1-david@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210301114749.47914-1-david@redhat.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Mar 01, 2021 at 12:47:49PM +0100, David Hildenbrand wrote: > With commit a0cd7a7c4bc0 ("mm: simplify free_highmem_page() and > free_reserved_page()") the kernel test robot complains about a warning: > > WARNING: modpost: vmlinux.o(.text.unlikely+0x23ac): Section mismatch in > reference from the function highmem_setup() to the function > .meminit.text:memblock_is_reserved() > > This has been broken ever since microblaze added highmem support, > because memblock_is_reserved() was already tagged with "__init" back then - > most probably the function always got inlined, so we never stumbled over > it. It might be good to point out that we need __meminit instead of __init because microblaze platform does not define CONFIG_ARCH_KEEP_MEMBLOCK, and __init_memblock fallsback to that. (I had to go and look as I was puzzled :-) ) Reviewed-by: Oscar Salvador > > Reported-by: kernel test robot > Fixes: 2f2f371f8907 ("microblaze: Highmem support") > Cc: Andrew Morton > Cc: Michal Simek > Cc: Mike Rapoport > Cc: Andrew Morton > Cc: Thomas Gleixner > Cc: Arvind Sankar > Cc: Ira Weiny > Cc: Randy Dunlap > Cc: Oscar Salvador > Cc: Anshuman Khandual > Signed-off-by: David Hildenbrand > --- > arch/microblaze/mm/init.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/microblaze/mm/init.c b/arch/microblaze/mm/init.c > index 181e48782e6c..05cf1fb3f5ff 100644 > --- a/arch/microblaze/mm/init.c > +++ b/arch/microblaze/mm/init.c > @@ -52,7 +52,7 @@ static void __init highmem_init(void) > pkmap_page_table = virt_to_kpte(PKMAP_BASE); > } > > -static void highmem_setup(void) > +static void __meminit highmem_setup(void) > { > unsigned long pfn; > > -- > 2.29.2 > > -- Oscar Salvador SUSE L3