Received: by 2002:a05:6a10:8c0a:0:0:0:0 with SMTP id go10csp4238550pxb; Tue, 2 Mar 2021 09:56:06 -0800 (PST) X-Google-Smtp-Source: ABdhPJz7Y8mlXR0JgB7NTa2ieYms472V2aWBdcypT4nIhHLueERa8QB+LfWkBbh4GQF9PM0L2/xF X-Received: by 2002:a17:906:fcb2:: with SMTP id qw18mr4908348ejb.434.1614707766565; Tue, 02 Mar 2021 09:56:06 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1614707766; cv=none; d=google.com; s=arc-20160816; b=BfNJK1FzLQiQSPUY7pIXcpe90qrZ0qSRNmLRBwKi2MZwBOpuhR/or728FMf/YWVWl5 yJam1Kq4nbBqJ/yvuNo2OH14heK0a7DEqPNRJV8Ur5DUO75gM3CcYZHfCl+KMpZPK/LM 4g8zeVDfjKmqsliF72NXfbtWXZFA7POyvEcJFlYnIPJQGLhZq+KpV69RHG8tr6fmBnE1 R4JFOytS/sTf4Tld4g20+gvJ6Tv5YH1DCSsNHNgOp5m4CiFsHOCZmMyT951gsGS3kuSV Z1tq964J9b57qgl7LvF7BC/5buGMCnlN8vFUhwFPf+G92TRdQiQCF0M2ddKzp3x6doIs nV3w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:cc:to:subject:message-id:date:from:in-reply-to :references:mime-version:dkim-signature; bh=AzzIj5aXFsgrkphFlIHeCI3vQXWdAnZoI6CShbhF4Vo=; b=YrHdZ60Tgn0nih5iM2vsaP6O+3bdaUSeU8tkVEc+3c1WL/PJk5Eyrb8rEWEaFp533v Djj0xldlfYsPIVwsAAvN5Y3QQOl5zRbIIRtCHmwOh5PzNQZD6ojeWnGkbb2qQmTxclX+ GWDvXwAoclJjD86s5ufbft1sbyDhvpNP+CYxYVL0fsvCbTLVYBbhKU1Bq6Mm7o93FgJ0 6iKESv+rKA1YDPwMp+/tWnFI/lakevriSQi1R+YDtGV658HdCYPXlfvlyou1wOLvwlgm Pak7zcNhRyV+CWKhsn24g8qyhJOZy1k+ufR9AaRwzqMqjoAI9KJ6nSGXEhUqJeWMtBDF v5kA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b=Itin81SJ; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id hd35si9624961ejc.526.2021.03.02.09.55.43; Tue, 02 Mar 2021 09:56:06 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b=Itin81SJ; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1575425AbhCBD4H (ORCPT + 99 others); Mon, 1 Mar 2021 22:56:07 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60966 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S240254AbhCAWp6 (ORCPT ); Mon, 1 Mar 2021 17:45:58 -0500 Received: from mail-qv1-xf2a.google.com (mail-qv1-xf2a.google.com [IPv6:2607:f8b0:4864:20::f2a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E8D58C061794 for ; Mon, 1 Mar 2021 14:44:05 -0800 (PST) Received: by mail-qv1-xf2a.google.com with SMTP id n4so6692927qvl.4 for ; Mon, 01 Mar 2021 14:44:05 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=AzzIj5aXFsgrkphFlIHeCI3vQXWdAnZoI6CShbhF4Vo=; b=Itin81SJQEhNJ7dXF6KO+tiNUxKJEzvX+O6McEL/dyKDNhpHQ/fuA1LkfIefVMVNi/ ODqe3iKylQgrFGzuM2rvf+jtYzStxuQnaYL1ZOe8sGAwLG9ePX7yzwlNEndT1XwP/eyL cRIAVI6Ni4Ot21KmYjvQc/1L51r6WBjHCjgfc= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=AzzIj5aXFsgrkphFlIHeCI3vQXWdAnZoI6CShbhF4Vo=; b=eHY8zdPIASbCwRGSGcfXS7Jz42IBxk8QPorIjBf+TPt/kjdN6p2I+VlgKFUPJg7g2y 9ZQYo9XNeXhmMAoVckVwQuw0YEcRbEszgVqMQSiqad+N5TJ5MSzIvMMXoqErr63RsNg2 Af+qQOdDCpi3fOq3U5DFcRgW2UD6xfHgAHQqfanPrNr0dpjQi1213lrSWt9xHBvJhSzK BA9/BppO0yEbfg1rlS5/w/oC/o9WlEcjb6EqW0l5MwmljTzAMXQ7j1basKy2hZq1DHxm /FKrpb6BcmrGY23/Wq9PNOM4QyHF+bF5+b0d2jol6r66FBxEsw93HbJilhv5EKxL+pGq Aigw== X-Gm-Message-State: AOAM530D+q9tD8g6+f489LSPC91Q1daFA3+DSLqt/AKKdzeK49/5KXIp KWvwXTyT7oL9hTRmzkfqoCPDhEVcwRAvNA== X-Received: by 2002:a0c:90ae:: with SMTP id p43mr1082900qvp.47.1614638644982; Mon, 01 Mar 2021 14:44:04 -0800 (PST) Received: from mail-yb1-f177.google.com (mail-yb1-f177.google.com. [209.85.219.177]) by smtp.gmail.com with ESMTPSA id v2sm348449qkp.119.2021.03.01.14.44.03 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 01 Mar 2021 14:44:04 -0800 (PST) Received: by mail-yb1-f177.google.com with SMTP id x19so18702125ybe.0 for ; Mon, 01 Mar 2021 14:44:03 -0800 (PST) X-Received: by 2002:a25:cf88:: with SMTP id f130mr26716305ybg.476.1614638643440; Mon, 01 Mar 2021 14:44:03 -0800 (PST) MIME-Version: 1.0 References: <0b165b2608eed1a61240539f4b812bd80b6ad1bd.1614624041.git.saiprakash.ranjan@codeaurora.org> In-Reply-To: <0b165b2608eed1a61240539f4b812bd80b6ad1bd.1614624041.git.saiprakash.ranjan@codeaurora.org> From: Doug Anderson Date: Mon, 1 Mar 2021 14:43:52 -0800 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCHv2 4/4] coresight: etm3x: Add support to exclude kernel mode tracing To: Sai Prakash Ranjan Cc: Mathieu Poirier , Suzuki K Poulose , Mike Leach , Peter Zijlstra , Ingo Molnar , Arnaldo Carvalho de Melo , Mark Rutland , Alexander Shishkin , Leo Yan , Jiri Olsa , Namhyung Kim , coresight@lists.linaro.org, Stephen Boyd , Denis Nikitin , Mattias Nissler , Al Grant , linux-arm-msm , LKML , Linux ARM Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, On Mon, Mar 1, 2021 at 11:05 AM Sai Prakash Ranjan wrote: > > On production systems with ETMs enabled, it is preferred to exclude > kernel mode(NS EL1) tracing for security concerns and support only > userspace(NS EL0) tracing. Perf subsystem interface uses the newly > introduced kernel config CONFIG_EXCLUDE_KERNEL_PMU_TRACE to exclude > kernel mode tracing, but there is an additional interface > via sysfs for ETMs which also needs to be handled to exclude kernel > mode tracing. So we use this same generic kernel config to handle > the sysfs mode of tracing. This config is disabled by default and > would not affect the current configuration which has both kernel and > userspace tracing enabled by default. > > Signed-off-by: Sai Prakash Ranjan > --- > drivers/hwtracing/coresight/coresight-etm3x-core.c | 3 +++ > drivers/hwtracing/coresight/coresight-etm3x-sysfs.c | 6 ++++++ > 2 files changed, 9 insertions(+) Reviewed-by: Douglas Anderson > diff --git a/drivers/hwtracing/coresight/coresight-etm3x-sysfs.c b/drivers/hwtracing/coresight/coresight-etm3x-sysfs.c > index e8c7649f123e..f522fc2e01b3 100644 > --- a/drivers/hwtracing/coresight/coresight-etm3x-sysfs.c > +++ b/drivers/hwtracing/coresight/coresight-etm3x-sysfs.c > @@ -116,6 +116,12 @@ static ssize_t mode_store(struct device *dev, > if (ret) > return ret; > > + if (IS_ENABLED(CONFIG_EXCLUDE_KERNEL_PMU_TRACE) && (!(val & ETM_MODE_EXCL_KERN))) { > + dev_warn(dev, > + "Kernel mode tracing is not allowed, check your kernel config\n"); Same nit as in patch #3 that the above string should be indented by 1 more space.