Received: by 2002:a05:6a10:8c0a:0:0:0:0 with SMTP id go10csp4303908pxb; Tue, 2 Mar 2021 11:32:31 -0800 (PST) X-Google-Smtp-Source: ABdhPJwUOMdoM8Xy5jnVyjBKIA8E9l1cIfM/wWw6/0c8xVh3lZbTqFrAB9bNsPX9KgpCXW8mlGT/ X-Received: by 2002:a05:6402:8d7:: with SMTP id d23mr2095636edz.256.1614713550986; Tue, 02 Mar 2021 11:32:30 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1614713550; cv=none; d=google.com; s=arc-20160816; b=pSo6OfjK+cqmpVfbMi5u5k2TLUagijjze7D5JVaYf3NxWf2ExTWn+PZRA5dtqlLkWN ioGST1JboRC+sDaJN0acIY1a0zjREY3csxX0boLzvh5RMUbpRbh1k1TcBXLjtvAiBouB wKBtW6yBc1GWyrkIwdQ9GtPut4qzso1PXBUoq13LaShaaZAWup9hPb2aVi7kExHzn0CS UvCAtDtlDY9N71rITvG1S06ohRcGDzzW/rr8i75KJ43XwYW87O2NE8NnCO4i1hVjd+fV ivG89781JB6g5wLYc9MDvXFBOCb0CQuXXyTk4EID2GvCfCDFQ6FxjUcZ3HIn2giLHxzq T2Zg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-language:content-transfer-encoding :in-reply-to:mime-version:user-agent:date:message-id:from:references :cc:to:subject:ironport-sdr:ironport-sdr; bh=6oXaSL8Dj4E9lp5zcza4Z2oshdTa6VIJRKFKNlKcHXM=; b=swkEP2DDUE8E7JQ3vh3sp7uF/X3yN48hFxcc+/voXh91qw3bxTvH5KhRsWjv+oBVu2 87noli7dtJH4Np5KdO9FWoWuKoKZxn7lhEFWelB9E6UfpPBJc7inLnaY+aF+L+2Jot/M ONqyrrVbiCv36uXPbTZPWHPUBo8Udd5lUE+qwx9hZbROJO0jZ8M8NQFqSvGopVNu0DEE oxzbcAln3DK0DQtUXpwhAMCeGIFDZgijU9etPpjMX1m5Ia84PMcHTbM7DoJh19VwrMVd CljjsGGMR8qoDgOded6pe3vLyuQWguFt/h57pvsRkf9IsnrOJU7zU+OQFLfBUKxcY5rz Dj5A== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id e4si13826464ejd.689.2021.03.02.11.32.07; Tue, 02 Mar 2021 11:32:30 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1349011AbhCBG5Y (ORCPT + 99 others); Tue, 2 Mar 2021 01:57:24 -0500 Received: from mga02.intel.com ([134.134.136.20]:34287 "EHLO mga02.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1381343AbhCBFWj (ORCPT ); Tue, 2 Mar 2021 00:22:39 -0500 IronPort-SDR: aqnAryx1AyDuXxrXT4VqFwO3befy0lFWYFvPPMdsxkR41OyKomzqeAFGufp+AjR7IrUZDPwBG5 NvWyeDftTbfg== X-IronPort-AV: E=McAfee;i="6000,8403,9910"; a="173828724" X-IronPort-AV: E=Sophos;i="5.81,216,1610438400"; d="scan'208";a="173828724" Received: from orsmga001.jf.intel.com ([10.7.209.18]) by orsmga101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 01 Mar 2021 21:21:33 -0800 IronPort-SDR: 1EAGgABchDoQBsjqVttpRTIyffgxjTAGDkWJIWlE4zbkJhWrOJZDD6zxar6Xys55wm46zHlLaW vK286rABsECQ== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.81,216,1610438400"; d="scan'208";a="444594676" Received: from unknown (HELO [10.239.154.55]) ([10.239.154.55]) by orsmga001.jf.intel.com with ESMTP; 01 Mar 2021 21:21:26 -0800 Subject: Re: [PATCH v5] i2c: virtio: add a virtio i2c frontend driver To: Viresh Kumar Cc: linux-i2c@vger.kernel.org, virtualization@lists.linux-foundation.org, linux-kernel@vger.kernel.org, mst@redhat.com, wsa@kernel.org, jasowang@redhat.com, wsa+renesas@sang-engineering.com, andriy.shevchenko@linux.intel.com, conghui.chen@intel.com, arnd@arndb.de, kblaiech@mellanox.com, jarkko.nikula@linux.intel.com, Sergey.Semin@baikalelectronics.ru, rppt@kernel.org, loic.poulain@linaro.org, tali.perry1@gmail.com, u.kleine-koenig@pengutronix.de, bjorn.andersson@linaro.org, yu1.wang@intel.com, shuo.a.liu@intel.com References: <00f826ffe1b6b4f5fb41de2b55ad6b8783b7ff45.1614579846.git.jie.deng@intel.com> <20210302044214.gnnce5ptwehrsnpc@vireshk-i7> From: Jie Deng Message-ID: <1e01448f-52f6-3d39-6794-d140637fdcc3@intel.com> Date: Tue, 2 Mar 2021 13:21:25 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Firefox/78.0 Thunderbird/78.7.0 MIME-Version: 1.0 In-Reply-To: <20210302044214.gnnce5ptwehrsnpc@vireshk-i7> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-US Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2021/3/2 12:42, Viresh Kumar wrote: > On 01-03-21, 14:41, Jie Deng wrote: >> +static int virtio_i2c_send_reqs(struct virtqueue *vq, >> + struct virtio_i2c_req *reqs, >> + struct i2c_msg *msgs, int nr) >> +{ >> + struct scatterlist *sgs[3], out_hdr, msg_buf, in_hdr; >> + int i, outcnt, incnt, err = 0; >> + u8 *buf; >> + >> + for (i = 0; i < nr; i++) { >> + if (!msgs[i].len) >> + break; >> + >> + reqs[i].out_hdr.addr = cpu_to_le16(msgs[i].addr << 1); > And this won't work for 10 bit addressing right? Don't we support that > in kernel ? > > From Spec: > > \begin{tabular}{ |l||l|l|l|l|l|l|l|l|l|l|l|l|l|l|l|l| } > \hline > Bits & 15 & 14 & 13 & 12 & 11 & 10 & 9 & 8 & 7 & 6 & 5 & 4 & 3 & 2 & 1 & 0 \\ > \hline > 7-bit address & 0 & 0 & 0 & 0 & 0 & 0 & 0 & 0 & A6 & A5 & A4 & A3 & A2 & A1 & A0 & 0 \\ > \hline > 10-bit address & A7 & A6 & A5 & A4 & A3 & A2 & A1 & A0 & 1 & 1 & 1 & 1 & 0 & A9 & A8 & 0 \\ > \hline > \end{tabular} Currently, to make things simple, this driver only supports 7 bit mode. It doesn't declare "I2C_FUNC_10BIT_ADDR" in the functionality. We may add in the future according to the need.