Received: by 2002:a05:6a10:8c0a:0:0:0:0 with SMTP id go10csp4324646pxb; Tue, 2 Mar 2021 12:06:34 -0800 (PST) X-Google-Smtp-Source: ABdhPJxLNLH0kx/+fZZCqDdxiJNyWoxy3yhzgwd4rchG1KYf+DmmNxq8j2gA7g45MNfdwgH1cRq8 X-Received: by 2002:aa7:ca57:: with SMTP id j23mr22547159edt.293.1614715594151; Tue, 02 Mar 2021 12:06:34 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1614715594; cv=none; d=google.com; s=arc-20160816; b=owgCBULucEtbNgfmaYNIdbDFZZ/LoblyJvz5UietAL68DufXxedOP7s309PGo4bQLW f+jBkVhkfahpSCgZAQkxEjKgB+Lmt9ekNRtiQ0i176ORXZIZc70pRkPIMOlK02aTNEHS xxuX0pAMWVWLc9vefLh/LGuS/y3Fb+aHxx6vjTq3axrzrspdY4MEL7CbTznz5ZhaYVhV HgXBNKS/9G1Is+xKAkFA+BX6oRqIWsH9h4j2XnUY6TzFijjDcmvvr0KZhKYzuNlSn/ee +it8HuAOHhs2bvw9XZaS5Ztbi19mjTPt9XP+n5BaJTbT5UGyYikdorVOwDj404iM50ab qhng== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from; bh=Ctfi8Q2WhaeHxniQDasczOyf0vPcHdBdAsdJXgBR6G8=; b=P3PpfS4s6W5HFyRvAqYnB6ppicBjcjvE86SLRzJVB6IpCjzPf8KGDPtvxM1kcfXmvX iQBi3ZD8dm37BweOod9YjKGKoNRinjEiBs7CetRHLPMiEACGEFZvGV0CZORGZUEVgBWl whAP+JSJx+vZUTF5L5qBfkSo10+vj7gvurE55qQUVs+6dVeFQz+m1Xp1HfwJAlSyqP3u 7sq9gUtkZDdG3/jYaAXdOe2L05bc2fFAS2ofnonePLbskX0jrbt8x6uVAfok04nXz+oS 6cBiA0pZmFb9IRTmsSNyb7vhOPeu+PhlvfoXE7Zzh5cfj7wVjPrfuEJXGC6dJ344b+gd Hl9A== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id m12si10105790ejx.720.2021.03.02.12.06.02; Tue, 02 Mar 2021 12:06:34 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1836622AbhCBHTF (ORCPT + 99 others); Tue, 2 Mar 2021 02:19:05 -0500 Received: from mx2.suse.de ([195.135.220.15]:39970 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1835906AbhCBGZf (ORCPT ); Tue, 2 Mar 2021 01:25:35 -0500 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 54BE3B03F; Tue, 2 Mar 2021 06:22:22 +0000 (UTC) From: Jiri Slaby To: gregkh@linuxfoundation.org Cc: linux-serial@vger.kernel.org, linux-kernel@vger.kernel.org, Jiri Slaby , linuxppc-dev@lists.ozlabs.org Subject: [PATCH 40/44] tty: hvc, drop unneeded forward declarations Date: Tue, 2 Mar 2021 07:22:10 +0100 Message-Id: <20210302062214.29627-40-jslaby@suse.cz> X-Mailer: git-send-email 2.30.1 In-Reply-To: <20210302062214.29627-1-jslaby@suse.cz> References: <20210302062214.29627-1-jslaby@suse.cz> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Forward declarations make the code larger and rewrites harder. Harder as they are often omitted from global changes. Remove forward declarations which are not really needed, i.e. the definition of the function is before its first use. Signed-off-by: Jiri Slaby Cc: linuxppc-dev@lists.ozlabs.org --- drivers/tty/hvc/hvcs.c | 25 ------------------------- 1 file changed, 25 deletions(-) diff --git a/drivers/tty/hvc/hvcs.c b/drivers/tty/hvc/hvcs.c index c90848919644..0b89d878a108 100644 --- a/drivers/tty/hvc/hvcs.c +++ b/drivers/tty/hvc/hvcs.c @@ -290,36 +290,11 @@ static LIST_HEAD(hvcs_structs); static DEFINE_SPINLOCK(hvcs_structs_lock); static DEFINE_MUTEX(hvcs_init_mutex); -static void hvcs_unthrottle(struct tty_struct *tty); -static void hvcs_throttle(struct tty_struct *tty); -static irqreturn_t hvcs_handle_interrupt(int irq, void *dev_instance); - -static int hvcs_write(struct tty_struct *tty, - const unsigned char *buf, int count); -static int hvcs_write_room(struct tty_struct *tty); -static int hvcs_chars_in_buffer(struct tty_struct *tty); - -static int hvcs_has_pi(struct hvcs_struct *hvcsd); -static void hvcs_set_pi(struct hvcs_partner_info *pi, - struct hvcs_struct *hvcsd); static int hvcs_get_pi(struct hvcs_struct *hvcsd); static int hvcs_rescan_devices_list(void); -static int hvcs_partner_connect(struct hvcs_struct *hvcsd); static void hvcs_partner_free(struct hvcs_struct *hvcsd); -static int hvcs_enable_device(struct hvcs_struct *hvcsd, - uint32_t unit_address, unsigned int irq, struct vio_dev *dev); - -static int hvcs_open(struct tty_struct *tty, struct file *filp); -static void hvcs_close(struct tty_struct *tty, struct file *filp); -static void hvcs_hangup(struct tty_struct * tty); - -static int hvcs_probe(struct vio_dev *dev, - const struct vio_device_id *id); -static int hvcs_remove(struct vio_dev *dev); -static int __init hvcs_module_init(void); -static void __exit hvcs_module_exit(void); static int hvcs_initialize(void); #define HVCS_SCHED_READ 0x00000001 -- 2.30.1