Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [PATCH] exfat: fix erroneous discard when clear cluster bit
To:     Sungjong Seo <sj1557.seo@samsung.com>, namjae.jeon@samsung.com
Cc:     linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org
References: <CGME20210225093351epcas1p40377b00fb3532e734e4a7a1233ee72e1@epcas1p4.samsung.com>
 <20210225093333.144829-1-hyeongseok@gmail.com>
 <000001d70f0d$8e882ec0$ab988c40$@samsung.com>
From:   Hyeongseok Kim <hyeongseok@gmail.com>
Message-ID: <206deada-bb28-e19a-d79a-1075501bbfe3@gmail.com>
Date:   Tue, 2 Mar 2021 15:28:49 +0900
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101
 Thunderbird/60.7.0
MIME-Version: 1.0
In-Reply-To: <000001d70f0d$8e882ec0$ab988c40$@samsung.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 7bit
Content-Language: ko-KR
Precedence: bulk

On 3/2/21 11:41 AM, Sungjong Seo wrote:
>> Subject: [PATCH] exfat: fix erroneous discard when clear cluster bit
>>
>> If mounted with discard option, exFAT issues discard command when clear
>> cluster bit to remove file. But the input parameter of cluster-to-sector
>> calculation is abnormally adds reserved cluster size which is 2, leading
>> to discard unrelated sectors included in target+2 cluster.
>>
>> Fixes: 1e49a94cf707 ("exfat: add bitmap operations")
>> Signed-off-by: Hyeongseok Kim <hyeongseok@gmail.com>
>> ---
>>   fs/exfat/balloc.c | 3 +--
>>   1 file changed, 1 insertion(+), 2 deletions(-)
> Looks good.
>
> Acked-by: Sungjong Seo <sj1557.seo@samsung.com>
>
> Thanks for your work!
> Could you remove the wrong comments above set/clear/find bitmap functions
> together?
>
Done, in V2.
Thanks for the review.