Received: by 2002:a05:6a10:8c0a:0:0:0:0 with SMTP id go10csp4347234pxb; Tue, 2 Mar 2021 12:45:39 -0800 (PST) X-Google-Smtp-Source: ABdhPJwTwqwt2XYGLHRT9gpZLVbJQkSzJz0ds4uTnC6o1OhvrBv1aIM9tqArxyheZTyxanITdmQB X-Received: by 2002:a17:906:af84:: with SMTP id mj4mr22997019ejb.84.1614717939170; Tue, 02 Mar 2021 12:45:39 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1614717939; cv=none; d=google.com; s=arc-20160816; b=0A3Kgt8ZJEuYQfSPafsFd1cybdzMfUH13tvjp/LBYNCkCYU81r1tqV8x8YyNtwqH/U 1Pcnv8shQ61OGolJgORP05+eULxmmIJonSk3S9oq4iPrABBinEwshNHoAi/6I3XtwtCk 0RxZzwIb/FkhGiCmc9uepdGU6zvtotyt4/f4PvgKVYnl1Qhko36gIejxg0A5gjI5Zc04 SW10XzWnkVgx7x/Dn+0Q8D8zR7SSDmBQKZ9GZCAqNU1T3iD2RCsXInG4x72Hz8st2gJF cmO4885yEMnDAWxK/lbbmqVhiW9xykvnNTH7qagQTKd3srzdaOnTrThTCymBPDRSo4vs OMYw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:mime-version:references:in-reply-to:message-id :date:subject:cc:to:from; bh=FnULdKQHdmufeM0cZra2zHq3W3nvZpYGhjDyobbNS90=; b=q70E0KWhyH2SWbNubnposmCoyU5Xg/8H1Vtdsd9xGjp42zgWktGftsDzLIvo/dk/SP IoUyKGBym3tb5Y7e+/DHFB8W1TKDz1+6vn76VW/5II9Xn1e4efBgpk2TaunU53HIjTTd 0F65vD1hIudUSmcc+IIA7QLd7ClCB4GwKza0P1PnICmt0RmvE0gk89gU6BjlNxCz2x5R 0Ql2zBVBKBk0Vu5+Zot3yqJfeexOSTLhtHuYtca5golKVxLp52tx1J2z6DW6Lr9W+Pa7 vQnKfBFj6i135tvLgAvLK/OV2jutPCCL+enlgzmqS2XPy0wJsc8ZaBRXYHz93EDNGgiV ZS/A== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=mediatek.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id dp16si13797892ejc.228.2021.03.02.12.45.15; Tue, 02 Mar 2021 12:45:39 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=mediatek.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1376780AbhCBHwE (ORCPT + 99 others); Tue, 2 Mar 2021 02:52:04 -0500 Received: from Mailgw01.mediatek.com ([1.203.163.78]:4963 "EHLO mailgw01.mediatek.com" rhost-flags-OK-FAIL-OK-FAIL) by vger.kernel.org with ESMTP id S1381414AbhCBH3z (ORCPT ); Tue, 2 Mar 2021 02:29:55 -0500 X-UUID: 76d0209ee1464206b27c386ce0aeb4d4-20210302 X-UUID: 76d0209ee1464206b27c386ce0aeb4d4-20210302 Received: from mtkcas35.mediatek.inc [(172.27.4.253)] by mailgw01.mediatek.com (envelope-from ) (mailgw01.mediatek.com ESMTP with TLSv1.2 ECDHE-RSA-AES256-SHA384 256/256) with ESMTP id 1680210667; Tue, 02 Mar 2021 15:28:36 +0800 Received: from mtkcas07.mediatek.inc (172.21.101.84) by MTKMBS31N1.mediatek.inc (172.27.4.69) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Tue, 2 Mar 2021 15:28:33 +0800 Received: from localhost.localdomain (10.17.3.153) by mtkcas07.mediatek.inc (172.21.101.73) with Microsoft SMTP Server id 15.0.1497.2 via Frontend Transport; Tue, 2 Mar 2021 15:28:32 +0800 From: Fengquan Chen To: Daniel Lezcano , Thomas Gleixner , Matthias Brugger , , , CC: , , Fengquan Chen Subject: [PATCH] clocksource/drivers/timer-mediatek: optimize systimer irq clear flow on Mediatek Socs Date: Tue, 2 Mar 2021 15:28:05 +0800 Message-ID: <1614670085-26229-2-git-send-email-Fengquan.Chen@mediatek.com> X-Mailer: git-send-email 1.8.1.1.dirty In-Reply-To: <1614670085-26229-1-git-send-email-Fengquan.Chen@mediatek.com> References: <1614670085-26229-1-git-send-email-Fengquan.Chen@mediatek.com> MIME-Version: 1.0 Content-Type: text/plain X-TM-SNTS-SMTP: C6A9DD39B665283DEC9F409682BFD9C5E80DCE98BCB2721AA6A68ACDD4DE829B2000:8 X-MTK: N Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org 1)ensure systimer is enabled before clear and disable interrupt, which only for systimer in Mediatek Socs. 2)clear any pending timer-irq when shutdown to keep suspend flow clean, when use systimer as tick-broadcast timer Change-Id: Ia3eda83324af2fdaf5cbb3569a9bf020a11f8009 Signed-off-by: Fengquan Chen --- drivers/clocksource/timer-mediatek.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/drivers/clocksource/timer-mediatek.c b/drivers/clocksource/timer-mediatek.c index 9318edc..9f1f095dc 100644 --- a/drivers/clocksource/timer-mediatek.c +++ b/drivers/clocksource/timer-mediatek.c @@ -75,6 +75,7 @@ static void mtk_syst_ack_irq(struct timer_of *to) { /* Clear and disable interrupt */ + writel(SYST_CON_EN, SYST_CON_REG(to)); writel(SYST_CON_IRQ_CLR | SYST_CON_EN, SYST_CON_REG(to)); } @@ -111,6 +112,9 @@ static int mtk_syst_clkevt_next_event(unsigned long ticks, static int mtk_syst_clkevt_shutdown(struct clock_event_device *clkevt) { + /* Clear any irq */ + mtk_syst_ack_irq(to_timer_of(clkevt)); + /* Disable timer */ writel(0, SYST_CON_REG(to_timer_of(clkevt))); -- 1.8.1.1.dirty