Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Tue, 2 Mar 2021 10:14:14 +0100
From:   Maxime Ripard <maxime@cerno.tech>
To:     Tobias Schramm <t.schramm@manjaro.org>
Cc:     Chen-Yu Tsai <wens@csie.org>, Rob Herring <robh+dt@kernel.org>,
        Jernej Skrabec <jernej.skrabec@siol.net>,
        devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH 3/3] ARM: dts: sun8i: V3/S3: add i2s peripheral
Message-ID: <20210302091414.ueqgrrb6fnkev423@gilmour>
References: <20210226103028.729172-1-t.schramm@manjaro.org>
 <20210226103028.729172-4-t.schramm@manjaro.org>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha256;
        protocol="application/pgp-signature"; boundary="xz7e52sol4iuhn2p"
Content-Disposition: inline
In-Reply-To: <20210226103028.729172-4-t.schramm@manjaro.org>
Precedence: bulk


--xz7e52sol4iuhn2p
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

Hi,

On Fri, Feb 26, 2021 at 11:30:28AM +0100, Tobias Schramm wrote:
> The V3 and S3 SoCs feature an i2s peripheral identical to that of the H3.
> Add it to the dts.
>=20
> Signed-off-by: Tobias Schramm <t.schramm@manjaro.org>

Why is it added to the v3 DTSI and not the global one?

> ---
>  arch/arm/boot/dts/sun8i-v3.dtsi | 15 +++++++++++++++
>  1 file changed, 15 insertions(+)
>=20
> diff --git a/arch/arm/boot/dts/sun8i-v3.dtsi b/arch/arm/boot/dts/sun8i-v3=
=2Edtsi
> index c279e13583ba..17ea6b8f091f 100644
> --- a/arch/arm/boot/dts/sun8i-v3.dtsi
> +++ b/arch/arm/boot/dts/sun8i-v3.dtsi
> @@ -30,3 +30,18 @@ uart1_pg_pins: uart1-pg-pins {
>  		function =3D "uart1";
>  	};
>  };
> +
> +&soc {

You don't need a label for that, you can just put it under / { soc {

> +		i2s0: i2s@1c22000 {
> +			#sound-dai-cells =3D <0>;
> +			compatible =3D "allwinner,sun8i-h3-i2s";

We should also have a v3 specific compatible here in addition to the H3
(and document it in the bindings).

Maxime

--xz7e52sol4iuhn2p
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iHUEABYIAB0WIQRcEzekXsqa64kGDp7j7w1vZxhRxQUCYD4B5gAKCRDj7w1vZxhR
xUu/AQCuOWEK7caX1VDLjoJIm0vhVD4eR1diftDPaIkE/qnDvgD/QeIJImkxu0FR
vBYEx/1tkyYo8qzFb5WXZ5Bsj6SYOAI=
=JV2a
-----END PGP SIGNATURE-----

--xz7e52sol4iuhn2p--