Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Tue, 2 Mar 2021 17:22:06 +0800
From:   Jisheng Zhang <Jisheng.Zhang@synaptics.com>
To:     Dominique Martinet <asmadeus@codewreck.org>
Cc:     Eric Van Hensbergen <ericvh@gmail.com>,
        Latchesar Ionkov <lucho@ionkov.net>,
        "David S. Miller" <davem@davemloft.net>,
        Jakub Kicinski <kuba@kernel.org>,
        v9fs-developer@lists.sourceforge.net, netdev@vger.kernel.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH] net: 9p: free what was emitted when read count is 0
Message-ID: <20210302172206.40db2f0a@xhacker.debian>
In-Reply-To: <YD3ybcx1i8Rtbvkp@codewreck.org>
References: <20210301103336.2e29da13@xhacker.debian>
        <YDxWrB8AoxJOmScE@odin>
        <20210301110157.19d9ad4e@xhacker.debian>
        <YD3BMLuZXIcETtzp@codewreck.org>
        <20210302153940.64332d11@xhacker.debian>
        <YD3ybcx1i8Rtbvkp@codewreck.org>
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-MessageSentRepresentingType: 1
Received: from xhacker.debian (192.147.44.204) by BY3PR05CA0016.namprd05.prod.outlook.com (2603:10b6:a03:254::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3912.9 via Frontend Transport; Tue, 2 Mar 2021 09:22:12 +0000
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 2f5dff96-e82a-4120-37f9-08d8dd5cab57
X-MS-TrafficTypeDiagnostic: BN8PR03MB5074:
X-Microsoft-Antispam-PRVS: <BN8PR03MB5074FCAA490D53CE55EF0180ED999@BN8PR03MB5074.namprd03.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:9508;
X-MS-Exchange-SenderADCheck: 1
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: ZB9iW0CrP1GC9Zh2eSEt5HX7+4RzmmfcZvECw9YxEcRAM3Aezwcl7xvTgh2N7sB7sYpMIEWQWuQIB78Vc0D4+WpqxqX9L5TisRkBwpDFSncw+0q+XOFnS4NXSL8aeHCDaqXiomUvz5YLcrTw7WOg72kPmAdXB+eWpS+gNv/0cMRIMlepK8dWOL0SIuUk81YMe7DPUyVziAcntaYg4x/jf495G8jnRKb1cv0iaQkKN1o7zkOsnkwU+qKd2eD84JpNYdseYNxp3dezjTjmXr/unvqnzshQbpk5Fe1Vpgr0SCp9RSKn+NSoInYyNHA4smXeDPUhxPwhgDy33/MT+qwqwgzlDPyham/71g7EgyrEDdNgFSiBOnv+ylZj/u1aXWY8iiimSwjJ6oZDQsVjyZwLAunu7McMrciao61B6bE83nviEjKbrwRwpdhYpfxPQpbcZexle0MLWJJxiH2ATeeVR5QTKgFe+xZdFv8u8LpilhAuGzyMGc+k/EAPX8cf6GfMR/fkMV9gO7ttUsx8nU/6bQ==
X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BN3PR03MB2307.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(136003)(376002)(396003)(366004)(39860400002)(346002)(55016002)(186003)(478600001)(6916009)(5660300002)(6506007)(2906002)(4326008)(6666004)(4744005)(16526019)(9686003)(66556008)(8676002)(86362001)(8936002)(316002)(7696005)(956004)(66476007)(52116002)(1076003)(26005)(54906003)(66946007);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData: =?us-ascii?Q?KxsNb5/+JytUZGnTfND7pr/vm77LCIUxPVIlPASqSk5C7RmGN/CGmwuA84Xe?=
 =?us-ascii?Q?+r4sQ308KLsczcFSdRl3+7Zf4eG4eBvfqlka/y79H13yyM8YUxYitL0kWjqN?=
 =?us-ascii?Q?Vlpc8ng7NQunWBfDBm/DHv1VpKWEsolGkmgm/IQH1cLCl4rLXcluu9s+cm/d?=
 =?us-ascii?Q?2eLzdAr98iuReG+gK/irU6RFHWL24FKMIuCKOg5HAhdEuMZsMAIv7uVjPkpF?=
 =?us-ascii?Q?RHrhWPx4RU+59rv2zneqaAH9/H451SKhM5x/OTcHin9OBTnMGpcDtHWzd5Zy?=
 =?us-ascii?Q?Vz0Z66FW20YXvM+xa12GKhMIvSjI5Ejikb1/g01VnIg1FeuPgek1Dfj/va0X?=
 =?us-ascii?Q?rLisQBFFYfDqCJ8mq8352EZevFgwgQmlmtx5rJtF4or61lGDQaXEBUHyT2QO?=
 =?us-ascii?Q?7X2n4BeUp5mUrQ/kxSGSPsH1GjQ7K7yZ1pQ2Bm3bf/28byX6BUgp861zwx2s?=
 =?us-ascii?Q?kgil+vGuTymwTlABOUMZUPO+6rnFCNT8kyH0euU8tVbgxcuT/nSKhd7vCDJj?=
 =?us-ascii?Q?2q1l/HgiuHiFEfQo9gt6+634vUth84Kt3+FIzGsOVLDOB+ccIL1wQNVN/JII?=
 =?us-ascii?Q?AB27naoE0RI6lmEDXLzLB6q5/hZZ+ZewHDilL/vf9Rnd7PIGPSz2PmgfyNuK?=
 =?us-ascii?Q?KaP8cgwffDOEDXO4wBIAzU0/wOB7hWrHSD2hwVTD6h1fZRFnQas9Rj0lpoK9?=
 =?us-ascii?Q?wAj6FPjZNKqSPhqPClp9HQ2hxWZVlSNNbYTGVFPF9i5qca7iYyZKdTncmC2W?=
 =?us-ascii?Q?0ujFeQEx80OmxxzMO2wO46Kl18NP8vNUyESgEg14IJJCNe1nqKjvdrdc+gQg?=
 =?us-ascii?Q?kX9BNDWfZZ75zjMB6oIFqJIhNcnzvx22jf25ED64V6+xWE3BzIptgQRBOhYH?=
 =?us-ascii?Q?5ZID5WFXDlcTPzyUE+5mgEPbLsktAlzRCzb1FPtuwRfeYyMMGZaDF0aPEPUx?=
 =?us-ascii?Q?GuE8GjoirhDvCIk6Q2kbatw9VcXOV9RiO6YJy1A2clkYeYmUQ+k04qF0X8Uv?=
 =?us-ascii?Q?90CBdodaf8X+sirCsl5UFl3drsJ8oxDda6zFwetJwTZ8FBuvSeQKOww9R9zV?=
 =?us-ascii?Q?eXmPkSLPdD/JbanIKNWRWZaYKGqck4dQom8cxuqxBW6lPVAzHLJgdHhrZt/B?=
 =?us-ascii?Q?AaqdjnsTipb4Dtc5PST0raWgj3stD9Ff2rfdy+8j9LM4+Gd2QqadMORhqKkY?=
 =?us-ascii?Q?98PRqipWXlokyidUXA4M8XfSWrMVloHz71OEEy2mdl42PWXswrSjrZcUiZqE?=
 =?us-ascii?Q?HWVaj6AO2bPwkTrNaGee8HQF11ao5nF9NhedUQkYdpHSQed1O7wq4kSBby/L?=
 =?us-ascii?Q?Q0iDX+j5gyTPH94Agg7l9iro?=
X-OriginatorOrg: synaptics.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 2f5dff96-e82a-4120-37f9-08d8dd5cab57
X-MS-Exchange-CrossTenant-AuthSource: BN3PR03MB2307.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 Mar 2021 09:22:15.6423
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 335d1fbc-2124-4173-9863-17e7051a2a0e
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 4TZ0ZwLYpwzz1ayiM9zhrGckXqUMCczIdRxlUrUTYIC1hIsFEj6J5DAzcEF2ceVJVsSVXw+DCos7EjaiF7dL+w==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN8PR03MB5074
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Tue, 2 Mar 2021 17:08:13 +0900 Dominique Martinet wrote:


> 
> 
> Jisheng Zhang wrote on Tue, Mar 02, 2021 at 03:39:40PM +0800:
> > > Rather than make an exception for 0, how about just removing the if as
> > > follow ?  
> >
> > IMHO, we may need to keep the "if" in current logic. When count
> > reaches zero, we need to break the "while(iov_iter_count(to))" loop, so removing
> > the "if" modifying the logic.  
> 
> We're not looking at the same loop, the break will happen properly

I was reading the old code because I switched to linux-5.4 longterm tree
for other development ;)

> without the if because it's the return value of p9_client_read_once()
> now.
> 
> In the old code I remember what you're saying and it makes sense, I
> guess that was the reason for the special case.
> It's not longer required, let's remove it.

Thank you. patch v2 is sent out.