Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
From:   LI Qingwu <qing-wu.li@leica-geosystems.com.cn>
To:     LI Qingwu <qing-wu.li@leica-geosystems.com.cn>,
        "sre@kernel.org" <sre@kernel.org>,
        "robh+dt@kernel.org" <robh+dt@kernel.org>,
        "dmurphy@ti.com" <dmurphy@ti.com>,
        "pali@kernel.org" <pali@kernel.org>,
        "krzk@kernel.org" <krzk@kernel.org>,
        "linux-pm@vger.kernel.org" <linux-pm@vger.kernel.org>,
        "devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
CC:     TERTYCHNYI Grygorii <grygorii.tertychnyi@leica-geosystems.com>,
        ZHIZHIKIN Andrey <andrey.zhizhikin@leica-geosystems.com>
Subject: RE: [PATCH V4 2/2] power: supply: bq27xxx: Add support for BQ78Z100
Thread-Topic: [PATCH V4 2/2] power: supply: bq27xxx: Add support for BQ78Z100
Thread-Index: AQHW+43zF4rTN+6HvEyXTT7OkSUGsKpwoHFQ
Date:   Tue, 2 Mar 2021 10:07:44 +0000
Message-ID: <DB7PR06MB4571F60314A7B11154E5B5F2D7999@DB7PR06MB4571.eurprd06.prod.outlook.com>
References: <20210205071004.26317-1-Qing-wu.Li@leica-geosystems.com.cn>
 <20210205071004.26317-3-Qing-wu.Li@leica-geosystems.com.cn>
In-Reply-To: <20210205071004.26317-3-Qing-wu.Li@leica-geosystems.com.cn>
Accept-Language: zh-CN, en-US
Content-Language: zh-CN
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-Network-Message-Id: 22e74009-9e03-4da1-b6d5-08d8dd6305fd
X-MS-Exchange-CrossTenant-originalarrivaltime: 02 Mar 2021 10:07:44.3690
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 1b16ab3e-b8f6-4fe3-9f3e-2db7fe549f6a
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: pwEtm/p9YRn8+UMOvaIcFdYHa3/LDSMYibx9eLLyn6YLFMZzCfFSv6W5taOk8e3ZCKT4tkd71Fj05rrnN91DHXrdM4rg0DGrqqIL7yoF7aSGdQpWqz1xFWfICOxJhBah
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB9PR06MB7722
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

this is a friendly reminder.


Best Regards

**********************************************
Li Qingwu (Terry)
Senior Embedded Software Engineer=20
Leica Geosystems(Shanghai)Co.,Limited
(Tel): +86 21 61061036
(FAX): +86 21 61061008
(Mobile): +86 187 0185 9600
E-mail: Qing-wu.Li@leica-geosystems.com.cn
Http: www.leica-geosystems.com.cn
**********************************************

-----Original Message-----
From: LI Qingwu <Qing-wu.Li@leica-geosystems.com.cn>=20
Sent: Friday, February 5, 2021 3:10 PM
To: sre@kernel.org; robh+dt@kernel.org; dmurphy@ti.com; pali@kernel.org; kr=
zk@kernel.org; linux-pm@vger.kernel.org; devicetree@vger.kernel.org; linux-=
kernel@vger.kernel.org
Cc: TERTYCHNYI Grygorii <grygorii.tertychnyi@leica-geosystems.com>; ZHIZHIK=
IN Andrey <andrey.zhizhikin@leica-geosystems.com>; LI Qingwu <qing-wu.li@le=
ica-geosystems.com.cn>
Subject: [PATCH V4 2/2] power: supply: bq27xxx: Add support for BQ78Z100

Add support for TI BQ78Z100, I2C interface gas gauge.
It provides a fully integrated safety protection and authentication for 1 t=
o 2-series cell Li-Ion and Li-Polymer battery packs.

The patch was tested with BQ78Z100 equipment.

Reviewed-by: Krzysztof Kozlowski <krzk@kernel.org>
Signed-off-by: LI Qingwu <Qing-wu.Li@leica-geosystems.com.cn>
---
 drivers/power/supply/bq27xxx_battery.c     | 46 +++++++++++++++++++++-
 drivers/power/supply/bq27xxx_battery_i2c.c |  2 +
 include/linux/power/bq27xxx_battery.h      |  1 +
 3 files changed, 48 insertions(+), 1 deletion(-)

diff --git a/drivers/power/supply/bq27xxx_battery.c b/drivers/power/supply/=
bq27xxx_battery.c
index 315e0909e6a4..c8579ec7a4f8 100644
--- a/drivers/power/supply/bq27xxx_battery.c
+++ b/drivers/power/supply/bq27xxx_battery.c
@@ -39,6 +39,7 @@
  * https://eur02.safelinks.protection.outlook.com/?url=3Dhttps%3A%2F%2Fwww=
.ti.com%2Fproduct%2Fbq27z561&amp;data=3D04%7C01%7C%7C9f9bd80e6c4c48b21f0208=
d8c9a5158b%7C1b16ab3eb8f64fe39f3e2db7fe549f6a%7C0%7C0%7C637481058152484173%=
7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWw=
iLCJXVCI6Mn0%3D%7C1000&amp;sdata=3Dm28d%2BWIxG3uVVBiA1GIYbahvhxe%2BqFFXHC9x=
Fum17wc%3D&amp;reserved=3D0
  * https://eur02.safelinks.protection.outlook.com/?url=3Dhttps%3A%2F%2Fwww=
.ti.com%2Fproduct%2Fbq28z610&amp;data=3D04%7C01%7C%7C9f9bd80e6c4c48b21f0208=
d8c9a5158b%7C1b16ab3eb8f64fe39f3e2db7fe549f6a%7C0%7C0%7C637481058152484173%=
7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWw=
iLCJXVCI6Mn0%3D%7C1000&amp;sdata=3D5f7FlqKszetEP3Uq2rZFIvHAbSsVV%2FUAWS7gOK=
tdzts%3D&amp;reserved=3D0
  * https://eur02.safelinks.protection.outlook.com/?url=3Dhttps%3A%2F%2Fwww=
.ti.com%2Fproduct%2Fbq34z100-g1&amp;data=3D04%7C01%7C%7C9f9bd80e6c4c48b21f0=
208d8c9a5158b%7C1b16ab3eb8f64fe39f3e2db7fe549f6a%7C0%7C0%7C6374810581524841=
73%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1h=
aWwiLCJXVCI6Mn0%3D%7C1000&amp;sdata=3DIK%2Bfiq2ga7dciCQHO5%2FBqKRgRZDgNoM0N=
eVpjmT9YtY%3D&amp;reserved=3D0
+ *=20
+ https://eur02.safelinks.protection.outlook.com/?url=3Dhttps%3A%2F%2Fwww.
+ ti.com%2Fproduct%2Fbq78z100&amp;data=3D04%7C01%7C%7C9f9bd80e6c4c48b21f02
+ 08d8c9a5158b%7C1b16ab3eb8f64fe39f3e2db7fe549f6a%7C0%7C0%7C637481058152
+ 484173%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJ
+ BTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&amp;sdata=3DewaB4hkn%2Bx7EJPXIA5Uux0P
+ MolDcgFqTHYKCslVYDFs%3D&amp;reserved=3D0
  */
=20
 #include <linux/device.h>
@@ -497,7 +498,27 @@ static u8
 		[BQ27XXX_REG_DCAP] =3D 0x3c,
 		[BQ27XXX_REG_AP] =3D 0x22,
 		BQ27XXX_DM_REG_ROWS,
-	};
+	},
+	bq78z100_regs[BQ27XXX_REG_MAX] =3D {
+		[BQ27XXX_REG_CTRL] =3D 0x00,
+		[BQ27XXX_REG_TEMP] =3D 0x06,
+		[BQ27XXX_REG_INT_TEMP] =3D 0x28,
+		[BQ27XXX_REG_VOLT] =3D 0x08,
+		[BQ27XXX_REG_AI] =3D 0x14,
+		[BQ27XXX_REG_FLAGS] =3D 0x0a,
+		[BQ27XXX_REG_TTE] =3D 0x16,
+		[BQ27XXX_REG_TTF] =3D 0x18,
+		[BQ27XXX_REG_TTES] =3D INVALID_REG_ADDR,
+		[BQ27XXX_REG_TTECP] =3D INVALID_REG_ADDR,
+		[BQ27XXX_REG_NAC] =3D INVALID_REG_ADDR,
+		[BQ27XXX_REG_FCC] =3D 0x12,
+		[BQ27XXX_REG_CYCT] =3D 0x2a,
+		[BQ27XXX_REG_AE] =3D 0x22,
+		[BQ27XXX_REG_SOC] =3D 0x2c,
+		[BQ27XXX_REG_DCAP] =3D 0x3c,
+		[BQ27XXX_REG_AP] =3D 0x22,
+		BQ27XXX_DM_REG_ROWS,
+};
=20
 static enum power_supply_property bq27000_props[] =3D {
 	POWER_SUPPLY_PROP_STATUS,
@@ -792,6 +813,27 @@ static enum power_supply_property bq34z100_props[] =3D=
 {
 	POWER_SUPPLY_PROP_MANUFACTURER,
 };
=20
+static enum power_supply_property bq78z100_props[] =3D {
+	POWER_SUPPLY_PROP_STATUS,
+	POWER_SUPPLY_PROP_PRESENT,
+	POWER_SUPPLY_PROP_VOLTAGE_NOW,
+	POWER_SUPPLY_PROP_CURRENT_NOW,
+	POWER_SUPPLY_PROP_CAPACITY,
+	POWER_SUPPLY_PROP_CAPACITY_LEVEL,
+	POWER_SUPPLY_PROP_TEMP,
+	POWER_SUPPLY_PROP_TIME_TO_EMPTY_NOW,
+	POWER_SUPPLY_PROP_TIME_TO_EMPTY_AVG,
+	POWER_SUPPLY_PROP_TIME_TO_FULL_NOW,
+	POWER_SUPPLY_PROP_TECHNOLOGY,
+	POWER_SUPPLY_PROP_CHARGE_FULL,
+	POWER_SUPPLY_PROP_CHARGE_FULL_DESIGN,
+	POWER_SUPPLY_PROP_CYCLE_COUNT,
+	POWER_SUPPLY_PROP_ENERGY_NOW,
+	POWER_SUPPLY_PROP_POWER_AVG,
+	POWER_SUPPLY_PROP_HEALTH,
+	POWER_SUPPLY_PROP_MANUFACTURER,
+};
+
 struct bq27xxx_dm_reg {
 	u8 subclass_id;
 	u8 offset;
@@ -890,6 +932,7 @@ static struct bq27xxx_dm_reg bq27621_dm_regs[] =3D {  #=
define bq27z561_dm_regs 0  #define bq28z610_dm_regs 0  #define bq34z100_dm_=
regs 0
+#define bq78z100_dm_regs 0
=20
 #define BQ27XXX_O_ZERO		BIT(0)
 #define BQ27XXX_O_OTDC		BIT(1) /* has OTC/OTD overtemperature flags */
@@ -948,6 +991,7 @@ static struct {
 	[BQ28Z610]  =3D BQ27XXX_DATA(bq28z610,  0         , BQ27Z561_O_BITS),
 	[BQ34Z100]  =3D BQ27XXX_DATA(bq34z100,  0         , BQ27XXX_O_OTDC | BQ27=
XXX_O_SOC_SI | \
 							  BQ27XXX_O_HAS_CI | BQ27XXX_O_MUL_CHEM),
+	[BQ78Z100]  =3D BQ27XXX_DATA(bq78z100,  0x00000000, BQ27Z561_O_BITS),
 };
=20
 static DEFINE_MUTEX(bq27xxx_list_lock); diff --git a/drivers/power/supply/=
bq27xxx_battery_i2c.c b/drivers/power/supply/bq27xxx_battery_i2c.c
index eb4f4284982f..46f078350fd3 100644
--- a/drivers/power/supply/bq27xxx_battery_i2c.c
+++ b/drivers/power/supply/bq27xxx_battery_i2c.c
@@ -248,6 +248,7 @@ static const struct i2c_device_id bq27xxx_i2c_id_table[=
] =3D {
 	{ "bq27z561", BQ27Z561 },
 	{ "bq28z610", BQ28Z610 },
 	{ "bq34z100", BQ34Z100 },
+	{ "bq78z100", BQ78Z100 },
 	{},
 };
 MODULE_DEVICE_TABLE(i2c, bq27xxx_i2c_id_table); @@ -284,6 +285,7 @@ static=
 const struct of_device_id bq27xxx_battery_i2c_of_match_table[] =3D {
 	{ .compatible =3D "ti,bq27z561" },
 	{ .compatible =3D "ti,bq28z610" },
 	{ .compatible =3D "ti,bq34z100" },
+	{ .compatible =3D "ti,bq78z100" },
 	{},
 };
 MODULE_DEVICE_TABLE(of, bq27xxx_battery_i2c_of_match_table);
diff --git a/include/linux/power/bq27xxx_battery.h b/include/linux/power/bq=
27xxx_battery.h
index 111a40d0d3d5..ac17618043b1 100644
--- a/include/linux/power/bq27xxx_battery.h
+++ b/include/linux/power/bq27xxx_battery.h
@@ -33,6 +33,7 @@ enum bq27xxx_chip {
 	BQ27Z561,
 	BQ28Z610,
 	BQ34Z100,
+	BQ78Z100,
 };
=20
 struct bq27xxx_device_info;
--
2.17.1