Received: by 2002:a05:6a10:8c0a:0:0:0:0 with SMTP id go10csp4469092pxb; Tue, 2 Mar 2021 16:40:25 -0800 (PST) X-Google-Smtp-Source: ABdhPJzS4Ne6aARbz5Ckc4tUpdy9DjfTbo6KkOpd1eG3bvsEIK9tXivxPHQhJpRcTc7aeqhnuT3J X-Received: by 2002:a05:6402:1398:: with SMTP id b24mr22167205edv.108.1614732025356; Tue, 02 Mar 2021 16:40:25 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1614732025; cv=none; d=google.com; s=arc-20160816; b=G+duDU8oKmSDvkVUi1JN+Qn9gPnpS2g2B0Ns3YDQbdq4mC8mDxShzsFgbXUt7GFGXi lejri5M8tiigSD6xYzcLSMmyNbcqr2C9uuqdJaEPfArZG2whOyyptmwhsY9TKsiQTzFU +1p1Mo8EALQOYRCH3C+UzJdm3TUpaiAKHoZA5MxNfq9kAQ22dliVcGQ5oRi7dw3sgiD/ sKTJt+btcFYsxiax4ncbBHqhqn0aRTYRWlKyua193q0sAAl54CB600e2mN1dI5eJraGv W8U/Dr/Q57gn/Hf84sP6bcEDywCp+VoqR1MFLJvyXCHe8uRaqGI/DcZSGnQmSvVKEmvs OJcg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:message-id:date:subject:cc:to:from; bh=i1UqRfxwcWri2whGMP0nz1CUMWdxqDfKJReV0VO3YTo=; b=BEnhjwo5/yqf75UL2ycxN/bVG7W24r4NaBe4tfqeFfHQK5rpljdxf96V/yixbYbGWw jatEfCEbcHQ2OlxMr3CRo+P76Tf89UWg5un8EqTaigSuX7c4emZ0KUfEFy6IUY87wzEg EhCah3Uu5uHWbHtoJEG5OIoiFa4BJuhpqlWIb6+FN3ehLU/MBYkdIzmJVGU4vEjXLYxp us3qHRFhjlQ/Kur/z28aOOARRH12CbJluZtDnehXgqOhTIWZ9Vb60R5GP4RbFmzVxQ6Q BP8MG/ze5sEIYW3aaaMuuCnA+moAKPQrp5X4Ebuv6PovzRdS37OC2/PQhTySxOyNLu/n JZXg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id e16si11115625edj.182.2021.03.02.16.40.01; Tue, 02 Mar 2021 16:40:25 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232724AbhCAIGI (ORCPT + 99 others); Mon, 1 Mar 2021 03:06:08 -0500 Received: from mail.zju.edu.cn ([61.164.42.155]:27836 "EHLO zju.edu.cn" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S232718AbhCAIF1 (ORCPT ); Mon, 1 Mar 2021 03:05:27 -0500 Received: from localhost.localdomain (unknown [10.192.85.18]) by mail-app3 (Coremail) with SMTP id cC_KCgDnPSQFoDxgCuLgAQ--.21092S4; Mon, 01 Mar 2021 16:04:25 +0800 (CST) From: Dinghao Liu To: dinghao.liu@zju.edu.cn, kjlu@umn.edu Cc: Linus Walleij , Jonathan Cameron , Lars-Peter Clausen , Peter Meerwald-Stadler , linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH] iio: gyro: mpu3050: Fix error handling in mpu3050_trigger_handler Date: Mon, 1 Mar 2021 16:04:21 +0800 Message-Id: <20210301080421.13436-1-dinghao.liu@zju.edu.cn> X-Mailer: git-send-email 2.17.1 X-CM-TRANSID: cC_KCgDnPSQFoDxgCuLgAQ--.21092S4 X-Coremail-Antispam: 1UD129KBjvdXoW7JF13WF4kWr1xXFyxKr15Jwb_yoWfJrb_W3 4UZas7W34IvFnrCr42yayfXr9FyF95ur95Wrn2qF9IkFyxCas5WryUZrnxGr43Wr48CFy3 Wr1ruF1xCF43KjkaLaAFLSUrUUUUUb8apTn2vfkv8UJUUUU8Yxn0WfASr-VFAUDa7-sFnT 9fnUUIcSsGvfJTRUUUbc8Fc2x0x2IEx4CE42xK8VAvwI8IcIk0rVWrJVCq3wAFIxvE14AK wVWUJVWUGwA2ocxC64kIII0Yj41l84x0c7CEw4AK67xGY2AK021l84ACjcxK6xIIjxv20x vE14v26w1j6s0DM28EF7xvwVC0I7IYx2IY6xkF7I0E14v26F4UJVW0owA2z4x0Y4vEx4A2 jsIE14v26rxl6s0DM28EF7xvwVC2z280aVCY1x0267AKxVW0oVCq3wAS0I0E0xvYzxvE52 x082IY62kv0487Mc02F40EFcxC0VAKzVAqx4xG6I80ewAv7VC0I7IYx2IY67AKxVWUJVWU GwAv7VC2z280aVAFwI0_Jr0_Gr1lOx8S6xCaFVCjc4AY6r1j6r4UM4x0Y48IcxkI7VAKI4 8JM4x0x7Aq67IIx4CEVc8vx2IErcIFxwCF04k20xvY0x0EwIxGrwCF04k20xvE74AGY7Cv 6cx26r4fKr1UJr1l4I8I3I0E4IkC6x0Yz7v_Jr0_Gr1lx2IqxVAqx4xG67AKxVWUJVWUGw C20s026x8GjcxK67AKxVWUGVWUWwC2zVAF1VAY17CE14v26r1q6r43MIIYrxkI7VAKI48J MIIF0xvE2Ix0cI8IcVAFwI0_Jr0_JF4lIxAIcVC0I7IYx2IY6xkF7I0E14v26r1j6r4UMI IF0xvE42xK8VAvwI8IcIk0rVWrJr0_WFyUJwCI42IY6I8E87Iv67AKxVWUJVW8JwCI42IY 6I8E87Iv6xkF7I0E14v26r4j6r4UJbIYCTnIWIevJa73UjIFyTuYvjfUoOJ5UUUUU X-CM-SenderInfo: qrrzjiaqtzq6lmxovvfxof0/1tbiAgcLBlZdtSjMQAABsT Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org There is one regmap_bulk_read() call in mpu3050_trigger_handler that we have caught its return value bug lack further handling. Check and terminate the execution flow just like the other three regmap_bulk_read() calls in this function. Signed-off-by: Dinghao Liu --- drivers/iio/gyro/mpu3050-core.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/iio/gyro/mpu3050-core.c b/drivers/iio/gyro/mpu3050-core.c index dfa31a23500f..ac90be03332a 100644 --- a/drivers/iio/gyro/mpu3050-core.c +++ b/drivers/iio/gyro/mpu3050-core.c @@ -551,6 +551,8 @@ static irqreturn_t mpu3050_trigger_handler(int irq, void *p) MPU3050_FIFO_R, &fifo_values[offset], toread); + if (ret) + goto out_trigger_unlock; dev_dbg(mpu3050->dev, "%04x %04x %04x %04x %04x\n", -- 2.17.1