Received: by 2002:a05:6a10:8c0a:0:0:0:0 with SMTP id go10csp16841pxb; Tue, 2 Mar 2021 17:31:48 -0800 (PST) X-Google-Smtp-Source: ABdhPJx6Zn/D4vy83ZTx4nozL23KB5ztqRkMPlKgNQy++fxswqs9eptRzDroHEbG9NKrJNiM77FL X-Received: by 2002:a17:907:2112:: with SMTP id qn18mr14658061ejb.220.1614735107792; Tue, 02 Mar 2021 17:31:47 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1614735107; cv=none; d=google.com; s=arc-20160816; b=MEx0EWYLScu9a+QF2JGzvYRCKo6O47iRzUZx0BqDigD+BGyVllAIyRM5BJG7jIVY3I L36PNNYpechn7FR33EXYg//uxEdGQSckWDEHMwNaVtihr88v9d0c9slheRld1Z3yXNo2 vpqOmSv3TyB4vbABrOKFF7kpUj3M36LBdNqUobWNuehu5OtMkBBdL46xttNz+HM6smi4 1dS9z2gbe2Mxmp/PQml75jJUfhwAN4VyLGQdoSWgAs/ovmPi0ezgWcL6pEjnVZMwuPm+ j29m80RW9ZXubnugjEh28M+NK5PBWC/8bHXV8X7oa9kti5VYySSpF6Z5nZcLYazjP0z4 0erA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:message-id:date:subject:cc:to:from:dmarc-filter :sender:dkim-signature; bh=s7t0/4jzbs7RJXuMvu1UkUefI1l0Bhq3QL5gw1WsNsY=; b=NpLwRlTugORb/M6gOr77uI9HkdLQ+8wezOAKiCEGX3lWRwPqzuwIkWz9bPQ+j+yWEY 4eyiv1TlWNhumbHLGkMQ1dFfA9J9W+gjfz2HAn/dry7LKbYIbjLU+27Ej81/iXDDD+IV AxSM4RpIQ4mMynnrV2xXERPrCCHS15xymtkNCjkocqGQTzOrm/+mXIltNBmR0gsgKpF6 SoxAcPyVpjLW2SORpZTiHZ32PsGA1wrEGdZdOXHZVbseUJ6wM0oauUJ7Izn5QLjxbHqA TxIFrVVZoKbqgeZgPtrN5RTHv+PKWzFyse4w38W6XoeegcM0iFw8oa5dWmemkQ7cTJWL JcBA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@mg.codeaurora.org header.s=smtp header.b=rehcTnz1; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id 17si14894353ejv.562.2021.03.02.17.31.24; Tue, 02 Mar 2021 17:31:47 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@mg.codeaurora.org header.s=smtp header.b=rehcTnz1; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233896AbhCAJ3q (ORCPT + 99 others); Mon, 1 Mar 2021 04:29:46 -0500 Received: from m42-2.mailgun.net ([69.72.42.2]:39964 "EHLO m42-2.mailgun.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233861AbhCAJ3p (ORCPT ); Mon, 1 Mar 2021 04:29:45 -0500 DKIM-Signature: a=rsa-sha256; v=1; c=relaxed/relaxed; d=mg.codeaurora.org; q=dns/txt; s=smtp; t=1614590960; h=Message-Id: Date: Subject: Cc: To: From: Sender; bh=s7t0/4jzbs7RJXuMvu1UkUefI1l0Bhq3QL5gw1WsNsY=; b=rehcTnz1wVzM+UUWJI8GO5WcbUjmiNoCT9PL0WLiHUuB749W0tzLEzH3Y8KsK9ELL71kPvzJ aIWTJZaYlUSHXoIxRQ8U5siRyejySTA9Vpy8euIEHLOKkqSQaxtmVshcj1vuN0qxWeBZz8Jc HahW+R+E0pw8EFHU8PqgiLWg7m4= X-Mailgun-Sending-Ip: 69.72.42.2 X-Mailgun-Sid: WyI0MWYwYSIsICJsaW51eC1rZXJuZWxAdmdlci5rZXJuZWwub3JnIiwgImJlOWU0YSJd Received: from smtp.codeaurora.org (ec2-35-166-182-171.us-west-2.compute.amazonaws.com [35.166.182.171]) by smtp-out-n01.prod.us-east-1.postgun.com with SMTP id 603cb3d6007a80f0f4e2a11f (version=TLS1.2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256); Mon, 01 Mar 2021 09:28:54 GMT Sender: kgunda=codeaurora.org@mg.codeaurora.org Received: by smtp.codeaurora.org (Postfix, from userid 1001) id 69350C43465; Mon, 1 Mar 2021 09:28:53 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-caf-mail-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.9 required=2.0 tests=ALL_TRUSTED,BAYES_00,SPF_FAIL autolearn=no autolearn_force=no version=3.4.0 Received: from kgunda-linux.qualcomm.com (unknown [202.46.22.19]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: kgunda) by smtp.codeaurora.org (Postfix) with ESMTPSA id 67A1CC433CA; Mon, 1 Mar 2021 09:28:48 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org 67A1CC433CA Authentication-Results: aws-us-west-2-caf-mail-1.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: aws-us-west-2-caf-mail-1.web.codeaurora.org; spf=fail smtp.mailfrom=kgunda@codeaurora.org From: Kiran Gunda To: bjorn.andersson@linaro.org, jingoohan1@gmail.com, lee.jones@linaro.org, b.zolnierkie@samsung.com, dri-devel@lists.freedesktop.org, daniel.thompson@linaro.org, jacek.anaszewski@gmail.com, pavel@ucw.cz, robh+dt@kernel.org, mark.rutland@arm.com, linux-leds@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Cc: linux-arm-msm@vger.kernel.org, phone-devel@vger.kernel.org, Kiran Gunda Subject: [PATCH V3 0/2] Fix WLED FSC Sync and brightness Sync settings Date: Mon, 1 Mar 2021 14:58:34 +0530 Message-Id: <1614590916-27070-1-git-send-email-kgunda@codeaurora.org> X-Mailer: git-send-email 2.7.4 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org This patch series has the following two WLED fixes 1. As per the current implementation, for WLED5, after the FSC (Full Scale Current) update the driver is incorrectly toggling the MOD_SYNC register instead of toggling the SYNC register. The patch 1/2 fixes this by toggling the SYNC register after FSC update. 2. Currently, the sync bits are transitioned from set-then-clear after FSC and brightness update. As per hardware team recommendation the FSC and brightness sync takes place from clear-then-set transition of the sync bits. The patch 2/2 fies this issue. Changes from V2: 1. Added Daniel's "Reviewed-by" tag for patch 1/2. 2. Updated the patch 2/2 description with "set" and "clear" terminology instead of "1" and "0". 3. Updated the cover letter with "set" and "clear" terminology instead of "1" and "0". Changes from V1: 1. Updated the cover letter. 2. Updated the description of the patches as per Daniel's suggestion. Kiran Gunda (2): backlight: qcom-wled: Fix FSC update issue for WLED5 backlight: qcom-wled: Correct the sync_toggle sequence drivers/video/backlight/qcom-wled.c | 37 +++++++++++++++++++++++++------------ 1 file changed, 25 insertions(+), 12 deletions(-) -- The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, a Linux Foundation Collaborative Project