Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Mon, 1 Mar 2021 12:51:02 +0100
From:   Marc Kleine-Budde <mkl@pengutronix.de>
To:     Dario Binacchi <dariobin@libero.it>
Cc:     linux-kernel@vger.kernel.org,
        Alexander Stein <alexander.stein@systec-electronic.com>,
        Federico Vaga <federico.vaga@gmail.com>,
        "David S. Miller" <davem@davemloft.net>,
        Jakub Kicinski <kuba@kernel.org>,
        Oliver Hartkopp <socketcan@hartkopp.net>,
        Vincent Mailhol <mailhol.vincent@wanadoo.fr>,
        Wolfgang Grandegger <wg@grandegger.com>,
        YueHaibing <yuehaibing@huawei.com>,
        Zhang Qilong <zhangqilong3@huawei.com>,
        linux-can@vger.kernel.org, netdev@vger.kernel.org
Subject: Re: [PATCH v2 5/6] can: c_can: prepare to up the message objects
 number
Message-ID: <20210301115102.j5qwmiy2on3ezd4d@pengutronix.de>
References: <20210225215155.30509-1-dariobin@libero.it>
 <20210225215155.30509-6-dariobin@libero.it>
 <20210226083315.cutpxc4iety4qedp@pengutronix.de>
 <1564374858.544328.1614507493409@mail1.libero.it>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="2dhc5sepxjp7dlct"
Content-Disposition: inline
In-Reply-To: <1564374858.544328.1614507493409@mail1.libero.it>
Precedence: bulk


--2dhc5sepxjp7dlct
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On 28.02.2021 11:18:13, Dario Binacchi wrote:
> > > +	u32 msg_obj_rx_mask;
> >=20
> > Is this variable big enough after you've extended the driver to use 64
> > mailboxes?
>=20
> Yes. I have kept the message assignment policy unchanged, they are equall=
y=20
> divided between reception and transmission. Therefore, in the case of 64=
=20
> messages, 32 are used for reception and 32 for transmission. So a 32-bit=
=20
> variable is enough.
>=20
> >=20
> > If you want to support 128 message objects converting the driver to the
> > linux bitmap API is another option.
> >=20
>=20
> Do you know if any of the hardware managed by Linux use a D_CAN controlle=
r=20
> with 128 message objects?

Even the am437x only uses 64 message objects. Ok let's stay with 64 as
max for now.

regards,
Marc

--=20
Pengutronix e.K.                 | Marc Kleine-Budde           |
Embedded Linux                   | https://www.pengutronix.de  |
Vertretung West/Dortmund         | Phone: +49-231-2826-924     |
Amtsgericht Hildesheim, HRA 2686 | Fax:   +49-5121-206917-5555 |

--2dhc5sepxjp7dlct
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQEzBAABCgAdFiEEK3kIWJt9yTYMP3ehqclaivrt76kFAmA81SMACgkQqclaivrt
76nyPQf/aaa/oKtyI9yNhbSa5NQXHNe7o/CjFKpk5OCavnNpKh0eTRSxmdip+sDT
PReCAnYwfvQAa4o2zMuW8xR4igotXas/6o2JXY/RLWmihXp3zTHVAuku0aRJlNiE
ePSAVAof3SdenghvekzLu+y7gk1qgFULQkHyp6AZxY8ABJUowTOrarK5rhD9U8xy
g8ERGLxVOObBqbDh9yEarTv0mY1PC224uZToSK4v94Bfyh4gUD97iYLknbtHdKhK
gugf8iOvLfIVB1H2EUvxWL4SzPASF/IGJCKVzyuY3HPMmt31RIGiD14yYoKqBHJB
/0yOSFgRkH6E24iHYGeP9co18gY0Bw==
=4J6b
-----END PGP SIGNATURE-----

--2dhc5sepxjp7dlct--