Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932266AbWI2AUv (ORCPT ); Thu, 28 Sep 2006 20:20:51 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S932309AbWI2AUv (ORCPT ); Thu, 28 Sep 2006 20:20:51 -0400 Received: from smtp.osdl.org ([65.172.181.4]:33180 "EHLO smtp.osdl.org") by vger.kernel.org with ESMTP id S932266AbWI2AUu (ORCPT ); Thu, 28 Sep 2006 20:20:50 -0400 Date: Thu, 28 Sep 2006 17:20:37 -0700 From: Andrew Morton To: David Brownell Cc: linux-usb-devel@lists.sourceforge.net, Linus Torvalds , Greg KH , linux-kernel@vger.kernel.org Subject: Re: [linux-usb-devel] [GIT PATCH] More USB patches for 2.6.18 Message-Id: <20060928172037.69a6a401.akpm@osdl.org> In-Reply-To: <200609281708.34599.david-b@pacbell.net> References: <20060928224250.GA23841@kroah.com> <20060928165951.2c5bd4c7.akpm@osdl.org> <200609281708.34599.david-b@pacbell.net> X-Mailer: Sylpheed version 2.2.7 (GTK+ 2.8.6; i686-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1077 Lines: 34 On Thu, 28 Sep 2006 17:08:33 -0700 David Brownell wrote: > > --- a/drivers/usb/host/ohci-hub.c~ohci-add-auto-stop-support-hack-hack > > +++ a/drivers/usb/host/ohci-hub.c > > @@ -132,6 +132,10 @@ static inline struct ed *find_head (stru > > return ed; > > } > > > > +#ifdef CONFIG_PM > > +static int ohci_restart(struct ohci_hcd *ohci); > > +#endif > > + > > /* caller has locked the root hub */ > > Better to just always include the forward decl... much cleaner! See other email. > ... reviewing and testing those new OHCI changes is still on my > list; erm, we prefer to do that before code hits mainline. > all that suspend stuff needs care, things that work on PCs don't > necessarily work on embedded hardware (where OHCI is common, and > PM tends to be more critical). I guess we'll find out. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/