Received: by 2002:a05:6a10:8c0a:0:0:0:0 with SMTP id go10csp460836pxb; Wed, 3 Mar 2021 07:30:37 -0800 (PST) X-Google-Smtp-Source: ABdhPJwReElZEoTIj4HyMilkWlLsrO9oFGoh+oyEwGdBLkdYiLAYGvbR5F9Ok+vaZar9XmWQ+MVc X-Received: by 2002:aa7:c903:: with SMTP id b3mr7803157edt.156.1614785437593; Wed, 03 Mar 2021 07:30:37 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1614785437; cv=none; d=google.com; s=arc-20160816; b=fZoHsf4byANoSYtG8rwt7uCQhqaIQ71CNDLbchodS1R5cjqjbxpZpvqOUUTX3h/Yjp WD3NtcqqnqvCK/QqmvlkNu2Ewqk1KqqyJoBEUy05Sio58B9/iYQ4VKm0RGMx2n1v5uDi OQGWJWtylv+h58JVeRpQMk9TNhtuw51yFSpl3lF6zihp1fvoMkfwMS/D4DMZ+ej8zXI/ 2jm2LsjXOBfztt6h1o3bKJ94K6VjlwHwtC0A2V6Um7QBhky5LX4jc29QbVeL41NJ22ZQ ViczGzkYn0ebyF3m8R+crvyUQ41Y1P703jAJRKQjeSwehQ3f4WPorMHZaNnDMeREnpDk Qe2Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=eONmr7ghb0U7+797sLxZsAMyi97w7ALXo5TFvhlPSgQ=; b=J8wP4RP01ycKduQKr30ezH8U3UjhssTDGyLzR+a3hiEn/1Yn7CTEjfMd+wIxrgo5Ph p8zsQs7nyQpGNxd4itk5zyk4fd/huePlyc0VxahsW0j2jq9Z+HljLx4uvUwvey5EpKsL 3dkxta9uFIlWNUfDMFsT7CTWLEEkInK3/vS7+HTnFTSoCoXECg5xr4/cKcIW40G/X+4W 0rtyPpflKvUv5TLEHwohc6OA6BylSVUm/UvXvuVdUCgjujeZ2yFw7Owlnk1AacIQk+Gc KervNuX80fecLdHHbBPXPV/ZmeKHtoKCUXQ/tQeFXyh4o+FgRblJl1tizcBuJ0Jc9ObL 9uPQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=QGIlx86v; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id s19si16107904ejb.327.2021.03.03.07.29.31; Wed, 03 Mar 2021 07:30:37 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=QGIlx86v; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1344201AbhCAWvU (ORCPT + 99 others); Mon, 1 Mar 2021 17:51:20 -0500 Received: from mail.kernel.org ([198.145.29.99]:40980 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S238396AbhCARrS (ORCPT ); Mon, 1 Mar 2021 12:47:18 -0500 Received: by mail.kernel.org (Postfix) with ESMTPSA id E2E4864F69; Mon, 1 Mar 2021 16:59:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1614617956; bh=t+OlSRSKsvR2p+UkRmB/vxRTFGJ2W8Y7c1keWtxtQ8Y=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=QGIlx86v94TXTbVHMlNqZrCuE6SkWvUQ+5ysTizSkA6MyO4o3tOgT/l6FlYS/9ClL EF6SWqtSXbtAsuHUowJtpkvPT537XpsvHz1i2bibJk4PH81HwrRNO4k7Sb4+bimw2s yiI7eiXswa8BWlkNIBe8x3n8drfhuk3GoExci1Cs= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Coly Li , Kai Krakow , Jens Axboe Subject: [PATCH 5.4 255/340] bcache: Give btree_io_wq correct semantics again Date: Mon, 1 Mar 2021 17:13:19 +0100 Message-Id: <20210301161100.846774185@linuxfoundation.org> X-Mailer: git-send-email 2.30.1 In-Reply-To: <20210301161048.294656001@linuxfoundation.org> References: <20210301161048.294656001@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Kai Krakow commit d797bd9897e3559eb48d68368550d637d32e468c upstream. Before killing `btree_io_wq`, the queue was allocated using `create_singlethread_workqueue()` which has `WQ_MEM_RECLAIM`. After killing it, it no longer had this property but `system_wq` is not single threaded. Let's combine both worlds and make it multi threaded but able to reclaim memory. Cc: Coly Li Cc: stable@vger.kernel.org # 5.4+ Signed-off-by: Kai Krakow Signed-off-by: Coly Li Signed-off-by: Jens Axboe Signed-off-by: Greg Kroah-Hartman --- drivers/md/bcache/btree.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- a/drivers/md/bcache/btree.c +++ b/drivers/md/bcache/btree.c @@ -2670,7 +2670,7 @@ void bch_btree_exit(void) int __init bch_btree_init(void) { - btree_io_wq = create_singlethread_workqueue("bch_btree_io"); + btree_io_wq = alloc_workqueue("bch_btree_io", WQ_MEM_RECLAIM, 0); if (!btree_io_wq) return -ENOMEM;