Received: by 2002:a05:6a10:8c0a:0:0:0:0 with SMTP id go10csp485252pxb; Wed, 3 Mar 2021 08:03:35 -0800 (PST) X-Google-Smtp-Source: ABdhPJxN7MlgukZaKZhD/evRl1PQ/pTDABeezS/epEFT3qAJ4STaz02UJbQeNelw2LsWiUXi2DNQ X-Received: by 2002:a17:906:1c4f:: with SMTP id l15mr26000814ejg.148.1614787414995; Wed, 03 Mar 2021 08:03:34 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1614787414; cv=none; d=google.com; s=arc-20160816; b=JUUMAtwcsUiSiWI8+FdC0riiul+2Gd0JFde8uyEXIjjFeMlwRFqBWzMQN84TQC+cP2 /qcSqbjerTvwFlPS4dnu4qn5RD05iBqn70qSRaeettu7vXef4b5DX5+wdUC6zb870gE8 lIsFs3hFhasZJ2KG4q/3032/oUI9AFi9i5lDiQ5LTtExaTBVzzkg/IoczVl/O0+iabKW to9U6p1bNKcBQ4nzcmeFU6MvlDHcJk1uUfr6WEUNRavSDhaQMSxaMMljij9pMriRuWdG S6hyX7zrB5IEi6hZ9cBvWuF69rkTTGgLcz+uUo3L5GoHnX28CUypwKAE3/FoVQar0PX/ Vosg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=HrWEZ5PacG4iikgsixN5l11PLOR0EU1V10CcbW7P7Qc=; b=SgzCuP01F7uj8SFyQdcG5xT/2PcbxZpbynMuw2rZw1qKaTCXJ4nLrNm0Tb6HqrJy/M wXE1AdDYpBy3UHimetaNe10pH2wfFvJ2ArCHCysxJERQ1ow4O8hJTLFTwXbctQXMYQUF DI98xy6YV6QwtcosJzjpptXNKHDKLHq+XqzuAg96OwY3WJdnk5BEoDEaVvc/ZyMnm/P1 bsRnJppqwtMeVH6IwqNAkttxvkFc82dSyUGOQMpn17vo9JnZANbK9dbffGhD40cpOf4C aG5KTMPgDT+PnXf+vAU0+CGJ0EbI1S+MywrkAH8WGmS6S8rStnG6EwqNgXZYizHXWTw4 XV5w== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=EWoMUXbr; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id dn4si16932764ejc.686.2021.03.03.08.02.49; Wed, 03 Mar 2021 08:03:34 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=EWoMUXbr; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1345585AbhCAX0Y (ORCPT + 99 others); Mon, 1 Mar 2021 18:26:24 -0500 Received: from mail.kernel.org ([198.145.29.99]:54744 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S238983AbhCASCm (ORCPT ); Mon, 1 Mar 2021 13:02:42 -0500 Received: by mail.kernel.org (Postfix) with ESMTPSA id 20DA6651E0; Mon, 1 Mar 2021 17:19:01 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1614619142; bh=Rex5nsfLetPhwlgcEJ6NQpbEQSd5JBpMwOJn5U52yyU=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=EWoMUXbraB3vKoO+ehrWSIW5tXKVYDLUS5a37x50jG3wABJSmccQ1Ga40N7NkXa8k PorToR2Donj8eXv59UwnZap9a5ZTV4mACQpq6OZXHBXA6Y/PwuXyfkaJstmf0YOP1Q FWANMCpZezQVVIwQGHAubFNMHJgAN4K3LgHHa8x8= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Bob Pearson , Jason Gunthorpe , Sasha Levin Subject: [PATCH 5.10 347/663] RDMA/rxe: Correct skb on loopback path Date: Mon, 1 Mar 2021 17:09:55 +0100 Message-Id: <20210301161159.016466594@linuxfoundation.org> X-Mailer: git-send-email 2.30.1 In-Reply-To: <20210301161141.760350206@linuxfoundation.org> References: <20210301161141.760350206@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Bob Pearson [ Upstream commit 5120bf0a5fc15dec210a0fe0f39e4a256bb6e349 ] rxe_net.c sends packets at the IP layer with skb->data pointing at the IP header but receives packets from a UDP tunnel with skb->data pointing at the UDP header. On the loopback path this was not correctly accounted for. This patch corrects for this by using sbk_pull() to strip the IP header from the skb on received packets. Fixes: 8700e3e7c485 ("Soft RoCE driver") Link: https://lore.kernel.org/r/20210128182301.16859-1-rpearson@hpe.com Signed-off-by: Bob Pearson Signed-off-by: Jason Gunthorpe Signed-off-by: Sasha Levin --- drivers/infiniband/sw/rxe/rxe_net.c | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/drivers/infiniband/sw/rxe/rxe_net.c b/drivers/infiniband/sw/rxe/rxe_net.c index 943914c2a50c7..bce44502ab0ed 100644 --- a/drivers/infiniband/sw/rxe/rxe_net.c +++ b/drivers/infiniband/sw/rxe/rxe_net.c @@ -414,6 +414,11 @@ int rxe_send(struct rxe_pkt_info *pkt, struct sk_buff *skb) void rxe_loopback(struct sk_buff *skb) { + if (skb->protocol == htons(ETH_P_IP)) + skb_pull(skb, sizeof(struct iphdr)); + else + skb_pull(skb, sizeof(struct ipv6hdr)); + rxe_rcv(skb); } -- 2.27.0