Received: by 2002:a05:6a10:8c0a:0:0:0:0 with SMTP id go10csp485256pxb; Wed, 3 Mar 2021 08:03:35 -0800 (PST) X-Google-Smtp-Source: ABdhPJwwVFK0UvlM2Ore1xXjDjvYfpzE35G1VfHiQS/viyadmcKRHXNc137zx2vERnN6sEPMwz+2 X-Received: by 2002:a17:906:39d9:: with SMTP id i25mr26757697eje.226.1614787414997; Wed, 03 Mar 2021 08:03:34 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1614787414; cv=none; d=google.com; s=arc-20160816; b=kAybKPStIIVz02vMNuB5rquBfmwwAF3FnC1yJL3gMrTDPbEEx+BuyOiI6veo3AZC0W MUQ5gf4SwoyVP8k79c3g4X9O/aUkBuD9yGwRHajFYMRzlGisAHvBHHOCx30Jud/O1nGy 9xN4R7AgiY/QabOgfSm+UQgOggVeeh7lVo1UlEMGahCIy81t6uugngxrOVLUrGuCclBl NAH+j0jUzBzVIxxVZ74FeQuILTujGQC8fd2xrrjVj2W48aC2CWIHueURvsFtZsqCNdQR PF/90Y2y7UXpEdbSFSdBalPz3m4h+rZZflhvUZ/IZiukzBgrN4T8L/9RP2ZvKGn4Q7VK KDsQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=EOcP4/ZvKqxvU8tEiuLBwBnm4ieTygpqH30SuN2O84Y=; b=SScZi6PFmbflykXI73/8HxNKjUCH5doZcaeq9yb+IIvvTUMF1bFTTj7Q6q2kruu83D k0ReXKf2nLtEa3oOefTaN+Or7Iy3fl97+zXCVEIYbnpQiZ0Jc+WDOq0989lfXf/+LbSb YI08wgySHz1mPVWEXDOMjyujgs+gvlQMTIxRXirCvkXw7c3dpiUvQ1tUnDSzirLBGHzf Nty5rOPM7HiuIf24HVIOUUWiqAYBRrZH2VAJ3NohTkZCfXA6yxAULlcDCJKiXqqrut/Q njG/1aJmCHRCEBbZ9pzsowmMMWwJKUkuZqKeZeZPqdCEiTJYa6/FNVIcfbPKvoY8hGJ8 Z8bA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=Ksxv7IMR; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id v1si16277104edb.592.2021.03.03.08.02.48; Wed, 03 Mar 2021 08:03:34 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=Ksxv7IMR; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1344381AbhCAXZX (ORCPT + 99 others); Mon, 1 Mar 2021 18:25:23 -0500 Received: from mail.kernel.org ([198.145.29.99]:54168 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S238503AbhCASBa (ORCPT ); Mon, 1 Mar 2021 13:01:30 -0500 Received: by mail.kernel.org (Postfix) with ESMTPSA id 8C83864F43; Mon, 1 Mar 2021 17:06:07 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1614618368; bh=b9i9u8H2bsi2ZIS8euZUpgwfGvirjFMoUIvfimt7xJY=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=Ksxv7IMRclDhxWOlv5VRFjGAWmaSobppuY5BRGj31QbcvQiXf61koEgA/SBkfBkft AEfLw5f+fA0HGTvwiSuxupxkkLzb+kJrwnWzQipE+WxPtL1/C6GR5vBnWZb9u3ZCky K1z38RFftrrYC9f3F9ykecPoIWUJR+ArJcv1V1JQ= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Pan Bian , Marcel Holtmann , Sasha Levin Subject: [PATCH 5.10 060/663] Bluetooth: Put HCI device if inquiry procedure interrupts Date: Mon, 1 Mar 2021 17:05:08 +0100 Message-Id: <20210301161144.705029052@linuxfoundation.org> X-Mailer: git-send-email 2.30.1 In-Reply-To: <20210301161141.760350206@linuxfoundation.org> References: <20210301161141.760350206@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Pan Bian [ Upstream commit 28a758c861ff290e39d4f1ee0aa5df0f0b9a45ee ] Jump to the label done to decrement the reference count of HCI device hdev on path that the Inquiry procedure is interrupted. Fixes: 3e13fa1e1fab ("Bluetooth: Fix hci_inquiry ioctl usage") Signed-off-by: Pan Bian Signed-off-by: Marcel Holtmann Signed-off-by: Sasha Levin --- net/bluetooth/hci_core.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/net/bluetooth/hci_core.c b/net/bluetooth/hci_core.c index c4aa2cbb92697..555058270f112 100644 --- a/net/bluetooth/hci_core.c +++ b/net/bluetooth/hci_core.c @@ -1356,8 +1356,10 @@ int hci_inquiry(void __user *arg) * cleared). If it is interrupted by a signal, return -EINTR. */ if (wait_on_bit(&hdev->flags, HCI_INQUIRY, - TASK_INTERRUPTIBLE)) - return -EINTR; + TASK_INTERRUPTIBLE)) { + err = -EINTR; + goto done; + } } /* for unlimited number of responses we will use buffer with -- 2.27.0