Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [PATCH] s390: cio: Return -EFAULT if copy_to_user() fails
To:     Heiko Carstens <hca@linux.ibm.com>, Wang Qing <wangqing@vivo.com>
Cc:     Cornelia Huck <cohuck@redhat.com>,
        Halil Pasic <pasic@linux.ibm.com>,
        Vineeth Vijayan <vneethv@linux.ibm.com>,
        Peter Oberparleiter <oberpar@linux.ibm.com>,
        Vasily Gorbik <gor@linux.ibm.com>,
        Christian Borntraeger <borntraeger@de.ibm.com>,
        linux-s390@vger.kernel.org, kvm@vger.kernel.org,
        linux-kernel@vger.kernel.org
References: <1614600093-13992-1-git-send-email-wangqing@vivo.com>
 <YDzob/k70ix1g0s+@osiris>
From:   Eric Farman <farman@linux.ibm.com>
Message-ID: <e7edc20c-49d7-9297-7d0e-01f8a55c9c37@linux.ibm.com>
Date:   Mon, 1 Mar 2021 13:07:26 -0500
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.7.0
MIME-Version: 1.0
In-Reply-To: <YDzob/k70ix1g0s+@osiris>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Precedence: bulk


On 3/1/21 8:13 AM, Heiko Carstens wrote:
> On Mon, Mar 01, 2021 at 08:01:33PM +0800, Wang Qing wrote:
>> The copy_to_user() function returns the number of bytes remaining to be
>> copied, but we want to return -EFAULT if the copy doesn't complete.
>>
>> Signed-off-by: Wang Qing <wangqing@vivo.com>
>> ---
>>   drivers/s390/cio/vfio_ccw_ops.c | 4 ++--
>>   1 file changed, 2 insertions(+), 2 deletions(-)
> 
> Applied, thanks!
> 

There's a third copy_to_user() call in this same routine, that deserves 
the same treatment. I'll get that fixup applied.

Thanks,
Eric