Received: by 2002:a05:6a10:8c0a:0:0:0:0 with SMTP id go10csp534806pxb; Wed, 3 Mar 2021 09:03:54 -0800 (PST) X-Google-Smtp-Source: ABdhPJxB9mhSyAIMin97KiN7A871CnI0DsOjfPDl3jewJHen9Ot0a784mFRUX5U7rqbTns8Ua905 X-Received: by 2002:a5d:4203:: with SMTP id n3mr27728576wrq.116.1614791033822; Wed, 03 Mar 2021 09:03:53 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1614791033; cv=none; d=google.com; s=arc-20160816; b=C0W5Dvz9Y4QSja+6dlmO1gbLJOS7HFSioHyQgFqAoCFTfEF7CCKU7dZorZUe2Xx9dv Z2pbOrPLbWswBhjONBA4NSNV6bzURQPyP3p7bYhjgO2dGKmDEK4zqY/JjlHyK1MRLy9i +sN+HUg0wmu9aol5FYJ905g7L+vBxo7kG9bYs2P2SQAHwR6o67IFyFSld+0myMLhMd5G jyvfb7xC/fulu3+i1yDlfx00rFLEJYWVxgxsJ6tTZK8jB4FUSS6LMTgW6vPW1AcIXZ9S r9ElqLp3bJzwKEo5Yb36UFQzy9NhzHEVNkpmPcH0DUs3HI4awv1FnlDC7SSm8LlDZMJa px1g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=k3PD/X8TC8/DjpANpVt80llKmg5WNFC/GJhvSxQCyAA=; b=lt2H83nsvrGXCxLUbhi+/oGFsTII+edCZdf5+5FhqUo+8L19bFNoXRRuINv++2t6pS 6GeLZPG4XOKZut2/mKuTJ8G1cCj56vX1TIum800N8UCytQqdPIHhfUckTOdHScdfx9JE qT3YdqwpT2ONSIwSEkNnekxmz9CV7CJNjqOaW4T5MsIfrXtpk+i9SKur4mQ8TrIWGaFS DxmwKJDYngpO8PrjJ6P0fvlcRPwA4K2ebuFhMfzuIXqL8+51KPCkzEZL0tMfihmcwkSd MxLh6QAJEJ/V7RZtsB9aJdEszaCxgNSTrJsVY6b3gaKQvs1wavnKqyC9V67BJoq0/q1q ozxQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=wPkgR0Ia; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id js7si15113721ejc.27.2021.03.03.09.03.21; Wed, 03 Mar 2021 09:03:53 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=wPkgR0Ia; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1348093AbhCBA2d (ORCPT + 99 others); Mon, 1 Mar 2021 19:28:33 -0500 Received: from mail.kernel.org ([198.145.29.99]:43166 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234861AbhCAS3G (ORCPT ); Mon, 1 Mar 2021 13:29:06 -0500 Received: by mail.kernel.org (Postfix) with ESMTPSA id 520BB65001; Mon, 1 Mar 2021 17:09:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1614618549; bh=44yxA0E7WiIwxw9+9jOtNTZsmjjapBtEe9/Oejm4uNQ=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=wPkgR0IaZ9VGKNVpdp4q9t4SRW1lI5MHsuUlZmZO71L2Y8ea4F9zaWx55m6nyfXn6 atWm5uvNqBF1zXcONzBoOtFs4uGpF87FCXre9pIgG5N8CahvUFJ6EBZG7YAspSzICv GZqzbmlFad9EGKYAahLX+zqNCHyqhxeCcX7tk+xc= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Lijun Pan , "David S. Miller" , Sasha Levin Subject: [PATCH 5.10 126/663] ibmvnic: skip send_request_unmap for timeout reset Date: Mon, 1 Mar 2021 17:06:14 +0100 Message-Id: <20210301161147.969852181@linuxfoundation.org> X-Mailer: git-send-email 2.30.1 In-Reply-To: <20210301161141.760350206@linuxfoundation.org> References: <20210301161141.760350206@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Lijun Pan [ Upstream commit 7d3a7b9ea59ddb223aec59b45fa1713c633aaed4 ] Timeout reset will trigger the VIOS to unmap it automatically, similarly as FAILVOER and MOBILITY events. If we unmap it in the linux side, we will see errors like "30000003: Error 4 in REQUEST_UNMAP_RSP". So, don't call send_request_unmap for timeout reset. Fixes: ed651a10875f ("ibmvnic: Updated reset handling") Signed-off-by: Lijun Pan Signed-off-by: David S. Miller Signed-off-by: Sasha Levin --- drivers/net/ethernet/ibm/ibmvnic.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/drivers/net/ethernet/ibm/ibmvnic.c b/drivers/net/ethernet/ibm/ibmvnic.c index d6cd131625525..5e1f4e71af7bc 100644 --- a/drivers/net/ethernet/ibm/ibmvnic.c +++ b/drivers/net/ethernet/ibm/ibmvnic.c @@ -249,8 +249,13 @@ static void free_long_term_buff(struct ibmvnic_adapter *adapter, if (!ltb->buff) return; + /* VIOS automatically unmaps the long term buffer at remote + * end for the following resets: + * FAILOVER, MOBILITY, TIMEOUT. + */ if (adapter->reset_reason != VNIC_RESET_FAILOVER && - adapter->reset_reason != VNIC_RESET_MOBILITY) + adapter->reset_reason != VNIC_RESET_MOBILITY && + adapter->reset_reason != VNIC_RESET_TIMEOUT) send_request_unmap(adapter, ltb->map_id); dma_free_coherent(dev, ltb->size, ltb->buff, ltb->addr); } -- 2.27.0