Received: by 2002:a05:6a10:8c0a:0:0:0:0 with SMTP id go10csp611839pxb; Wed, 3 Mar 2021 10:43:05 -0800 (PST) X-Google-Smtp-Source: ABdhPJyu+8+jW73AnpBHDikl8qyuuWi/jBaXKI/nzYwS70OKqhhvjljofhjbgE4TJBgmc9pqlEOg X-Received: by 2002:a17:907:3da5:: with SMTP id he37mr233473ejc.300.1614796985736; Wed, 03 Mar 2021 10:43:05 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1614796985; cv=none; d=google.com; s=arc-20160816; b=PDKDyzhb2Wo+AJbUwpxDd0JcYaTKI40plxXQwKaQwesbSDWGV9FVpXstFmHrCGcsUV KlB1M5w7NOoXHtAilKn93uymwnLuJ2Vif+Supta0/uBEG90HyOle4Md3CDtrX2Ko/2no Vvzmhdj4LudgLy5a1LxVlVULs1zjLFqWhTsEjIueWSaNjVSxMtAxLFm9lqTp8003b/IU LVQnxxlj/RBUCyuoDv+lcBaHbNcLs8czO+gP9tOMEaMZ1E1dC1sJPJ29YpME/GCGaDvJ bHtzFA3Y9hmTbwzXBrFUJTaxbVmZZQGL0kuQ1bAnziwLN6zkQJUqGazHQsPJ5NQtYkE+ dVeA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=ZgA4doFCTT7ToiL9Q+Qby6S+061n698qdR7fjOrzIYU=; b=BctCQhmgXYSQWaPadbriddzptSyvf/KKS/tI/Dp7fYBEibkH+fUa9A7Jf6Tv8AI+9U jht5OUu2ONprG5fd7dDpECwUOebxvgRhtTTOCAnko9G4tvQYWUa1BSj5mLhtqyEIX29j NDkPePGC9X4sn7vpc6D2SgehVg3wi6qUXVew1dPPhzFqngtqqtDUtiDS36UTLz4ttuOk k7DyYZEw1Eb9cuqenPmO6tJ5/2ZHvUUiRVv3F9ROW0SxhgSndMuRf/20TVIPuPlCWXOr DdEZDWpzpaEgf3NLOFgj91JKFVkK68OsrcUO65luYdE9Te8cJTDQAOUrs/RmLWmRCFH8 wcZw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=NZ91JsT2; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id k5si1581984ejc.134.2021.03.03.10.42.33; Wed, 03 Mar 2021 10:43:05 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=NZ91JsT2; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1378418AbhCBBGC (ORCPT + 99 others); Mon, 1 Mar 2021 20:06:02 -0500 Received: from mail.kernel.org ([198.145.29.99]:34072 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S240813AbhCATBG (ORCPT ); Mon, 1 Mar 2021 14:01:06 -0500 Received: by mail.kernel.org (Postfix) with ESMTPSA id 8BA0E6505E; Mon, 1 Mar 2021 17:22:45 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1614619366; bh=rORETC1/UC1sVNbYvdG5T1po8QqdkKbQL2PpoGpWZCs=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=NZ91JsT2y9GCwBOBPKwD2segChS8IbB6H6ZF/dnxKu1tS7+a7UGMdgFWfZllFDthi tH7HlQakKl3uzzjKnilKu0VZpED5vPxd/jQRntocbPnP7H2Gzrr9UvBr/pOLBSV8Gr cAjvdC2c9FikgR1UbNlRVxEYTNRLrG14ulR/DfcY= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Yoshihiro Shimoda , Geert Uytterhoeven , Marek Vasut , Lorenzo Pieralisi , Bjorn Helgaas , Wolfram Sang , linux-renesas-soc@vger.kernel.org, Sasha Levin Subject: [PATCH 5.10 398/663] PCI: rcar: Always allocate MSI addresses in 32bit space Date: Mon, 1 Mar 2021 17:10:46 +0100 Message-Id: <20210301161201.559406023@linuxfoundation.org> X-Mailer: git-send-email 2.30.1 In-Reply-To: <20210301161141.760350206@linuxfoundation.org> References: <20210301161141.760350206@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Marek Vasut [ Upstream commit c4e0fec2f7ee013dbf86445394ff47f719408f99 ] This fixes MSI operation on legacy PCI cards, which cannot issue 64bit MSIs. The R-Car controller only has one MSI trigger address instead of two, one for 64bit and one for 32bit MSI, set the address to 32bit PCIe space so that legacy PCI cards can also trigger MSIs. Link: https://lore.kernel.org/r/20201016120431.7062-1-marek.vasut@gmail.com Fixes: 290c1fb35860 ("PCI: rcar: Add MSI support for PCIe") Tested-by: Yoshihiro Shimoda Tested-by: Geert Uytterhoeven Signed-off-by: Marek Vasut Signed-off-by: Lorenzo Pieralisi Reviewed-by: Yoshihiro Shimoda Reviewed-by: Geert Uytterhoeven Cc: Bjorn Helgaas Cc: Geert Uytterhoeven Cc: Lorenzo Pieralisi Cc: Wolfram Sang Cc: Yoshihiro Shimoda Cc: linux-renesas-soc@vger.kernel.org Signed-off-by: Sasha Levin --- drivers/pci/controller/pcie-rcar-host.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/pci/controller/pcie-rcar-host.c b/drivers/pci/controller/pcie-rcar-host.c index cdc0963f154e3..2bee09b16255d 100644 --- a/drivers/pci/controller/pcie-rcar-host.c +++ b/drivers/pci/controller/pcie-rcar-host.c @@ -737,7 +737,7 @@ static int rcar_pcie_enable_msi(struct rcar_pcie_host *host) } /* setup MSI data target */ - msi->pages = __get_free_pages(GFP_KERNEL, 0); + msi->pages = __get_free_pages(GFP_KERNEL | GFP_DMA32, 0); rcar_pcie_hw_enable_msi(host); return 0; -- 2.27.0