Received: by 2002:a05:6a10:8c0a:0:0:0:0 with SMTP id go10csp913852pxb; Wed, 3 Mar 2021 20:52:08 -0800 (PST) X-Google-Smtp-Source: ABdhPJx3QTVP1/Ug/mNCAxlrScFsbfRL7sIWuTOUGa3sPgr0VSPOD+nl+V7LUsp/m35X9CGD1umN X-Received: by 2002:a50:eb49:: with SMTP id z9mr2484057edp.234.1614833527928; Wed, 03 Mar 2021 20:52:07 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1614833527; cv=none; d=google.com; s=arc-20160816; b=xZeRJ3fdxSSNoPFY6wmJrrEmwd6wx9c47yCD3LNOaWImCg7LHntBomtj/HQT77DZOH bvfxR3H+mmV+/0255wtcOZOTp2XZe/rlOtwSSI4MBfWEcTBsvouXuo8sqrp2JvM7yGoy Z6+HOK3e8sEBewvOGv9FSKvJhoytuBY11qoUsT0hQglQt22tJO/FSwLyWQZYjbPMuUuX IVWpeo4a+5VhtUhgINwd3OpTk54GlmpZyJl/l8ChpdIltsWigy4DaTSIqs62WewSxt47 qSAIUnOcuP2e6a3x/fBZQrJ8bTA4weKG5U4AMld4Gr5Arkk7xAYXFYp7EW+iR+fQrbt5 AVQA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=YZHetDyKQRXIKTky/xEjFEWt385QUtZ/Yn3oo/yoAyw=; b=VNfFiVz7KQ7kxqp4ecSM5IouLSIadOeBxgGi3sjZC4rgn548HbXXTOxaVj0ZjXqnx1 E78RslU1CCz6WPOw9O/xb2o+CnT3yRSr0owZ1HXYaIms4+4n1f3Gdw3qpTtChKahBoRG ZIbLdMh84aGsbwNTI0Gc1ps9ffXVJG85ATlnf3/FHiwU/GwrpRT2QM0gbO/NzzsS1OvR V8Frob5UzVzYOI0RBmRHo2hJT5//Jb0QGHmttsEVbQoawQlKsEIQlIxjzxj6o6GdLysF kQd7xy+/j6363yActUg2MaHh6abuPLTU+viQCtGdXmbLoEhR2PRdHS1yhdZVJ3WtUpfN bsqg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=Ap48byCf; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id n13si970322ejs.39.2021.03.03.20.51.45; Wed, 03 Mar 2021 20:52:07 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=Ap48byCf; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1442299AbhCBCMS (ORCPT + 99 others); Mon, 1 Mar 2021 21:12:18 -0500 Received: from mail.kernel.org ([198.145.29.99]:51200 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S238342AbhCAThT (ORCPT ); Mon, 1 Mar 2021 14:37:19 -0500 Received: by mail.kernel.org (Postfix) with ESMTPSA id E9CAF64EE1; Mon, 1 Mar 2021 17:13:08 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1614618789; bh=oH5Pp1LqGFyLTprX5Ex1z/4ukUshR6UmE3FUtvYo8p0=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=Ap48byCf0QQ7nEsIjao26PxjMyLIjzXl663utJfI8JNqoTwd6U5obWq1q1tC40iqN EeuLczofb4DlQ2Xmspvgm8GcSv+ksZ0jfkJA4yd8RvbruxmukAvbMoOSO1+R+KsmUf yrbbsiRTxqJM1ETcHFrXeP73dCEEQHvWa6HmSfiU= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Yongqiang Niu , Chun-Kuang Hu , Sasha Levin Subject: [PATCH 5.10 217/663] drm/mediatek: Fix aal size config Date: Mon, 1 Mar 2021 17:07:45 +0100 Message-Id: <20210301161152.529130643@linuxfoundation.org> X-Mailer: git-send-email 2.30.1 In-Reply-To: <20210301161141.760350206@linuxfoundation.org> References: <20210301161141.760350206@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org [ Upstream commit 71dcadba34203d8dd35152e368720f977e9cdb81 ] The orginal setting is not correct, fix it to follow hardware data sheet. If keep this error setting, mt8173/mt8183 display ok but mt8192 display abnormal. Fixes: 0664d1392c26 ("drm/mediatek: Add AAL engine basic function") Signed-off-by: Yongqiang Niu Signed-off-by: Chun-Kuang Hu Signed-off-by: Sasha Levin --- drivers/gpu/drm/mediatek/mtk_drm_ddp_comp.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/mediatek/mtk_drm_ddp_comp.c b/drivers/gpu/drm/mediatek/mtk_drm_ddp_comp.c index 3064eac1a7507..7fcb717f256c9 100644 --- a/drivers/gpu/drm/mediatek/mtk_drm_ddp_comp.c +++ b/drivers/gpu/drm/mediatek/mtk_drm_ddp_comp.c @@ -180,7 +180,9 @@ static void mtk_aal_config(struct mtk_ddp_comp *comp, unsigned int w, unsigned int h, unsigned int vrefresh, unsigned int bpc, struct cmdq_pkt *cmdq_pkt) { - mtk_ddp_write(cmdq_pkt, h << 16 | w, comp, DISP_AAL_SIZE); + struct mtk_ddp_comp_dev *priv = dev_get_drvdata(comp->dev); + + mtk_ddp_write(cmdq_pkt, w << 16 | h, &priv->cmdq_reg, priv->regs, DISP_AAL_SIZE); } static void mtk_aal_start(struct mtk_ddp_comp *comp) -- 2.27.0