Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Mon, 1 Mar 2021 20:46:53 +0100
From:   Marc Kleine-Budde <mkl@pengutronix.de>
To:     Dario Binacchi <dariobin@libero.it>
Cc:     linux-kernel@vger.kernel.org,
        Federico Vaga <federico.vaga@gmail.com>,
        Oliver Hartkopp <socketcan@hartkopp.net>,
        Vincent Mailhol <mailhol.vincent@wanadoo.fr>,
        YueHaibing <yuehaibing@huawei.com>,
        Zhang Qilong <zhangqilong3@huawei.com>,
        linux-can@vger.kernel.org, netdev@vger.kernel.org
Subject: Re: [PATCH v3 5/6] can: c_can: prepare to up the message objects
 number
Message-ID: <20210301194653.egjnrysvfmqusd45@pengutronix.de>
References: <20210228103856.4089-1-dariobin@libero.it>
 <20210228103856.4089-6-dariobin@libero.it>
 <20210301113805.jylhc373sip7zmed@pengutronix.de>
 <20210301130845.3s45ujmhkazscm6x@pengutronix.de>
 <198393892.577352.1614619471062@mail1.libero.it>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="df4yjeailgg3kxvn"
Content-Disposition: inline
In-Reply-To: <198393892.577352.1614619471062@mail1.libero.it>
Precedence: bulk


--df4yjeailgg3kxvn
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On 01.03.2021 18:24:31, Dario Binacchi wrote:
> Hi Marc,
>=20
> > Il 01/03/2021 14:08 Marc Kleine-Budde <mkl@pengutronix.de> ha scritto:
> >=20
> > =20
> > On 01.03.2021 12:38:05, Marc Kleine-Budde wrote:
> > > On 28.02.2021 11:38:54, Dario Binacchi wrote:
> > > [...]
> > >=20
> > > > @@ -730,7 +728,7 @@ static void c_can_do_tx(struct net_device *dev)
> > > >  	while ((idx =3D ffs(pend))) {
> > > >  		idx--;
> > > >  		pend &=3D ~(1 << idx);
> > > > -		obj =3D idx + C_CAN_MSG_OBJ_TX_FIRST;
> > > > +		obj =3D idx + priv->msg_obj_tx_first;
> > > >  		c_can_inval_tx_object(dev, IF_TX, obj);
> > > >  		can_get_echo_skb(dev, idx, NULL);
> > > >  		bytes +=3D priv->dlc[idx];
> > > > @@ -740,7 +738,7 @@ static void c_can_do_tx(struct net_device *dev)
> > > >  	/* Clear the bits in the tx_active mask */
> > > >  	atomic_sub(clr, &priv->tx_active);
> > > > =20
> > > > -	if (clr & (1 << (C_CAN_MSG_OBJ_TX_NUM - 1)))
> > > > +	if (clr & (1 << (priv->msg_obj_tx_num - 1)))
> > >=20
> > > Do we need 1UL here, too?
> >=20
> > There are several more "1 <<" in the driver. As the right side of the
> > sift operation can be up to 32, I think you should replace all "1 <<"
> > with "1UL <<".
>=20
> Do you agree if I use the BIT macro for all these shift operations?

No, only use BIT(), where you want to set a single bit, use GENMASK()
for masks.

regards,
Marc

--=20
Pengutronix e.K.                 | Marc Kleine-Budde           |
Embedded Linux                   | https://www.pengutronix.de  |
Vertretung West/Dortmund         | Phone: +49-231-2826-924     |
Amtsgericht Hildesheim, HRA 2686 | Fax:   +49-5121-206917-5555 |

--df4yjeailgg3kxvn
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQEzBAABCgAdFiEEK3kIWJt9yTYMP3ehqclaivrt76kFAmA9RKsACgkQqclaivrt
76k8bwgAseV6n0GjZF7s/1Dg64W063rxRs/X0o6rdNGyZyEgx6gl5hLuF/Z3bCMf
7mw4mPC0Ub4TEH14CdDb23LW2xXDPyyDgUcE00T2Qmp4GQZACqYJQinvUS7mF6Uv
T1fHr6ynyjfu1XSkLWespNXbG3rDbbd/78FiT9P3frbCkA4AJR2bUvODbX6fiHNW
u3KvKUtRx5aJEmHHBRhT95JIRRP4DRPOfs9C8c+S9HtwYPX4+OT8lWde2roUWUPw
Il8VkTofjEWe6W+bUkAcTa44/fxAoilok3EPtrEuaaDIFrt2o/uERqM3hgZR/xM6
jY8jIasV+bRLv5XbJbKQCCfzzxoQRQ==
=M5u4
-----END PGP SIGNATURE-----

--df4yjeailgg3kxvn--