Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
From:   Jonathan Corbet <corbet@lwn.net>
To:     hjh <huangjianghui@uniontech.com>
Cc:     Alex Shi <alex.shi@linux.alibaba.com>,
        Harry Wei <harryxiyou@gmail.com>, linux-doc@vger.kernel.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH] PATCH Documentation translations:translate
 sound/hd-audio/controls to chinese
In-Reply-To: <20210301122019.80234-1-huangjianghui@uniontech.com>
References: <20210301122019.80234-1-huangjianghui@uniontech.com>
Date:   Mon, 01 Mar 2021 14:16:36 -0700
Message-ID: <8735xe4lsb.fsf@meer.lwn.net>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

hjh <huangjianghui@uniontech.com> writes:

> Signed-off-by: hjh <huangjianghui@uniontech.com>
> ---
>  Documentation/translations/zh_CN/index.rst    |   1 +
>  .../zh_CN/sound/hd-audio/controls.rst         | 102 ++++++++++++++++++
>  .../zh_CN/sound/hd-audio/index.rst            |  17 +++
>  .../translations/zh_CN/sound/index.rst        |  26 +++++
>  4 files changed, 146 insertions(+)
>  create mode 100644 Documentation/translations/zh_CN/sound/hd-audio/contr=
ols.rst
>  create mode 100644 Documentation/translations/zh_CN/sound/hd-audio/index=
.rst
>  create mode 100644 Documentation/translations/zh_CN/sound/index.rst

So you have sent me two versions of this in the last 24 hours with no
indication of what has changed or why I should prefer one over the
other.  Always include that information (under the "---" line) when you
send updated versions.

It looks like you got a Reviewed-by tag from Alex on the other version,
but that doesn't appear here; why?

[...]

> diff --git a/Documentation/translations/zh_CN/sound/hd-audio/index.rst b/=
Documentation/translations/zh_CN/sound/hd-audio/index.rst
> new file mode 100644
> index 000000000000..c287aad51066
> --- /dev/null
> +++ b/Documentation/translations/zh_CN/sound/hd-audio/index.rst
> @@ -0,0 +1,17 @@
> +.. include:: ../../disclaimer-zh_CN.rst
> +
> +:Original: :doc:`../../../../sound/hd-audio/index`
> +:Translator: Huang Jianghui <huangjianghui@uniontech.com>
> +
> +
> +=E9=AB=98=E6=B8=85=E9=9F=B3=E9=A2=91
> +=3D=3D=3D=3D=3D=3D=3D=3D
> +
> +.. toctree::
> +   :maxdepth: 2
> +
> +   notes
> +   models
> +   controls
> +   dp-mst
> +   realtek-pc-beep

So you list a bunch of files here, but most of them are not added in
your patch.  That will, of course, break the docs build.

> diff --git a/Documentation/translations/zh_CN/sound/index.rst b/Documenta=
tion/translations/zh_CN/sound/index.rst
> new file mode 100644
> index 000000000000..42d86b361e42
> --- /dev/null
> +++ b/Documentation/translations/zh_CN/sound/index.rst
> @@ -0,0 +1,26 @@

Similarly, including the index.rst file at this level is good, but...

> +.. include:: ../disclaimer-zh_CN.rst
> +
> +:Original: :doc:`../../../sound/index`
> +:Translator: Huang Jianghui <huangjianghui@uniontech.com>
> +
> +
> +=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D
> +Linux =E5=A3=B0=E9=9F=B3=E5=AD=90=E7=B3=BB=E7=BB=9F=E6=96=87=E6=A1=A3
> +=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D
> +
> +.. toctree::
> +   :maxdepth: 2
> +
> +   kernel-api/index
> +   designs/index
> +   soc/index
> +   alsa-configuration
> +   hd-audio/index
> +   cards/index

What are all of these files?

Please fix these issues and make sure that the docs build runs correctly
before resubmitting.

Thanks,

jon