Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Mon, 1 Mar 2021 22:44:07 +0100
From:   Uwe =?utf-8?Q?Kleine-K=C3=B6nig?= <u.kleine-koenig@pengutronix.de>
To:     Clemens Gruber <clemens.gruber@pqgruber.com>
Cc:     linux-pwm@vger.kernel.org,
        Thierry Reding <thierry.reding@gmail.com>,
        Sven Van Asbroeck <TheSven73@gmail.com>,
        Lee Jones <lee.jones@linaro.org>, linux-kernel@vger.kernel.org,
        Mika Westerberg <mika.westerberg@linux.intel.com>,
        David Jander <david@protonic.nl>
Subject: Re: [PATCH v5 1/7] pwm: pca9685: Switch to atomic API
Message-ID: <20210301214407.4xitetvqbsdoer6w@pengutronix.de>
References: <20201215212228.185517-1-clemens.gruber@pqgruber.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="jbzb7vdleqvxvrto"
Content-Disposition: inline
In-Reply-To: <20201215212228.185517-1-clemens.gruber@pqgruber.com>
Precedence: bulk


--jbzb7vdleqvxvrto
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

Hello Clemens,

On Tue, Dec 15, 2020 at 10:22:22PM +0100, Clemens Gruber wrote:
> +	if (state->polarity !=3D PWM_POLARITY_NORMAL)
> +		return -EOPNOTSUPP;

We agreed on -EINVAL for that one since 2b1c1a5d5148.

Other than that the patch looks ok (but note I only looked quickly).

Best regards
Uwe

--=20
Pengutronix e.K.                           | Uwe Kleine-K=F6nig            |
Industrial Linux Solutions                 | https://www.pengutronix.de/ |

--jbzb7vdleqvxvrto
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQEzBAABCgAdFiEEfnIqFpAYrP8+dKQLwfwUeK3K7AkFAmA9YCQACgkQwfwUeK3K
7AlbVggAjhMX1tA5gAqeopKXsYbCnrWvjpnvYNV8amg8MkQxRz878g0aceOQ4EYG
+cc9M2GflTbj/xdReZ1b7Z6noB4CM+QQkPsIGlf0I8j6eT1qRPBPW6KxR3jhw1+K
/scoZGR4MOVThQtBAFNvFF6CFV9VXiVUaE/cuw+9jlHuWtITuxYyZLnQsEEzdAOB
/hZiaLfl/fD9+ApLnYOmnBfyVBhTu7taufPvJYU0HKOtuKs/LIOeCavj0Wyplww3
377KV2Kyok4ux85pQYZqxz0FEeA1uufVt0RgudlanfbDlBcKgTgryJs5MGVenlkL
QxXjnI4bYJ3WOp+3aGbPkUZBmAAayQ==
=ig8H
-----END PGP SIGNATURE-----

--jbzb7vdleqvxvrto--