Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
IronPort-SDR: rWxhSzw0bFEXRgWzOpzZt4EG/g96JxyPkloOsvFl6mDPzkSVLrFtrEbIQSaVzwDkwVWYQZWDh4
 6lzjjNkIi/XZR3iJgiXW5P/9N6YiB38bsseruO1/0yBK8xyeuDCThXargHL7+rWit1WEzFLcK3
 UfZT84Bu6a4ffhaeNYD1EzU++lFjJdZtfc2AtLBJ/fS6Wvk/lEgvkTsd8aI5ZcjHlZiQ9HRdR/
 uomU2bSI7z/rAAC+fBdSoA9jpps+LjMDjRfpnee9irqlGLwiuoA9TcsX4aSmRItW893jL/CgXT
 saw=
From:   Avri Altman <Avri.Altman@wdc.com>
To:     Jiapeng Chong <jiapeng.chong@linux.alibaba.com>,
        "alim.akhtar@samsung.com" <alim.akhtar@samsung.com>
CC:     "jejb@linux.ibm.com" <jejb@linux.ibm.com>,
        "martin.petersen@oracle.com" <martin.petersen@oracle.com>,
        "linux-scsi@vger.kernel.org" <linux-scsi@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: RE: [PATCH] scsi: ufs: convert sysfs sprintf/snprintf family to
 sysfs_emit
Thread-Topic: [PATCH] scsi: ufs: convert sysfs sprintf/snprintf family to
 sysfs_emit
Thread-Index: AQHXDyp+KdsAkQvzZE2ICiXVQJOZMqpwRe3g
Date:   Tue, 2 Mar 2021 07:04:05 +0000
Message-ID: <DM6PR04MB65758DF8DCE75B782D0A10F0FC999@DM6PR04MB6575.namprd04.prod.outlook.com>
References: <1614665298-115183-1-git-send-email-jiapeng.chong@linux.alibaba.com>
In-Reply-To: <1614665298-115183-1-git-send-email-jiapeng.chong@linux.alibaba.com>
Accept-Language: en-US
Content-Language: en-US
wdcipoutbound: EOP-TRUE
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-Network-Message-Id: c2c578fe-c1fc-4964-b010-08d8dd495e1a
X-MS-Exchange-CrossTenant-originalarrivaltime: 02 Mar 2021 07:04:05.2948
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: b61c8803-16f3-4c35-9b17-6f65f441df86
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: jbwnuPE1GaaCWuvTjMwWEydDq4RnL87nMSG1+SdJPdSGK97aEv5cD3/3j3/1KwEez4jv0GfIwjX3QTpe6I4Ycw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR04MB4842
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


> Fix the following coccicheck warning:
>=20
> ./drivers/scsi/ufs/ufshcd.c:1538:8-16: WARNING: use scnprintf or
> sprintf.
>=20
> Reported-by: Abaci Robot <abaci@linux.alibaba.com>
> Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>
Reviewed-by: Avri Altman <avri.altman@wdc.com>

> ---
>  drivers/scsi/ufs/ufshcd.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>=20
> diff --git a/drivers/scsi/ufs/ufshcd.c b/drivers/scsi/ufs/ufshcd.c
> index 7716175..7fb94d7 100644
> --- a/drivers/scsi/ufs/ufshcd.c
> +++ b/drivers/scsi/ufs/ufshcd.c
> @@ -1535,7 +1535,7 @@ static ssize_t ufshcd_clkscale_enable_show(struct
> device *dev,
>  {
>         struct ufs_hba *hba =3D dev_get_drvdata(dev);
>=20
> -       return snprintf(buf, PAGE_SIZE, "%d\n", hba->clk_scaling.is_enabl=
ed);
> +       return sysfs_emit(buf, "%d\n", hba->clk_scaling.is_enabled);
>  }
>=20
>  static ssize_t ufshcd_clkscale_enable_store(struct device *dev,
> --
> 1.8.3.1