Received: by 2002:a05:6a10:8c0a:0:0:0:0 with SMTP id go10csp943235pxb; Wed, 3 Mar 2021 21:59:47 -0800 (PST) X-Google-Smtp-Source: ABdhPJzFyZ77nvGOTH31bICXJoMjeudNEwVQq3mNJ9SwNVbVLCL87um9qTnMEFQv12WaaUo2EHt4 X-Received: by 2002:a17:906:38da:: with SMTP id r26mr2471577ejd.251.1614837587599; Wed, 03 Mar 2021 21:59:47 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1614837587; cv=none; d=google.com; s=arc-20160816; b=t2kFvPuJM9ZkB8t3V0gvRSXodX/q2r8c4f9KcfdX+jzh+h1b6VWR5P7YhoCRTgQB2E CfRQDDwX6U6mG/sc2vlpWyBVu1KBV5LKiqbgaMgdVTFjvM0Tsy/fJ2TN4P+rIs1FcCUm eMga+y6Fnsy7qUO/5smyU4P9Q/o+4Wve2OAviTEb9bEZ8i9MKqc+O7MalGnNuUWbynWy L6HawUbMrweepa6QW5ckfMzRv9Sp5vFzzXl5P3/qgUoDRX1smi0+ppFKuxWV1Nc6kow8 uNYBI/BC8lJjH8/5CMH4hR/RkGCxBXVEYtqX9nFAbcax/2K84En7TJX/AYOYrzK48lxx xWpg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:message-id:date:subject:cc:to:from; bh=pHO4vQnEFdUXeJrthHIA47uWX3+J3r7dwRpRzFbxnn8=; b=0TuC7GvBDgQyeBy6dH3D6Z8VjQe/T2c8RnNlVu2oLt09Ug1SUfGVvzvqZgewSqnFzy dXW5RSpg9TjyH04tksva0yV3iKBXYFvQcb5WZFWHG6eKgDkYQoAd/P0Yujam86jFqMXJ 7222Ez1w20xlozF/zUJ4Nx27RSElQd37ExYHHxcfC/oEae9L6asxUc+DnBQ8b2hGaSMq ckZAeJw4KwAZAVGv9Ff62vv7JtiARTEfnP3rf5Zl5HnIXeztpnXRtG2Ex1iVQ8hZcnCM 5Lp99abNWiVBkKzS8XP08XS+13WNKUEIsD1ptaAk9MShm5cOd8WtGsLbQ7Ni3tsSm2D6 7tGw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id l13si17315415ejg.121.2021.03.03.21.59.24; Wed, 03 Mar 2021 21:59:47 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1381503AbhCBHxH (ORCPT + 99 others); Tue, 2 Mar 2021 02:53:07 -0500 Received: from mail.loongson.cn ([114.242.206.163]:55552 "EHLO loongson.cn" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1381422AbhCBHaL (ORCPT ); Tue, 2 Mar 2021 02:30:11 -0500 Received: from linux.localdomain (unknown [113.200.148.30]) by mail.loongson.cn (Coremail) with SMTP id AQAAf9Dxr_AR6T1ggTMTAA--.7754S2; Tue, 02 Mar 2021 15:28:18 +0800 (CST) From: Tiezhu Yang To: Paul Walmsley , Palmer Dabbelt , Albert Ou Cc: linux-riscv@lists.infradead.org, linux-kernel@vger.kernel.org Subject: [PATCH] riscv: Return -EFAULT if copy_to_user() failed in signal.c Date: Tue, 2 Mar 2021 15:28:17 +0800 Message-Id: <1614670097-28536-1-git-send-email-yangtiezhu@loongson.cn> X-Mailer: git-send-email 2.1.0 X-CM-TRANSID: AQAAf9Dxr_AR6T1ggTMTAA--.7754S2 X-Coremail-Antispam: 1UD129KBjvJXoW7Wr17Wry3Jry7CF1DGrykXwb_yoW8Jr1DpF 4UCa4xKrW8GrnruF9ayw1kW34rJ3saqa4xKr90k3W3AFs0qr45t34vqa4jqF4rJFyrCrs0 ka4qkrWYkw48WrJanT9S1TB71UUUUUUqnTZGkaVYY2UrUUUUjbIjqfuFe4nvWSU5nxnvy2 9KBjDU0xBIdaVrnRJUUUvlb7Iv0xC_tr1lb4IE77IF4wAFF20E14v26r1j6r4UM7CY07I2 0VC2zVCF04k26cxKx2IYs7xG6rWj6s0DM7CIcVAFz4kK6r1j6r18M28lY4IEw2IIxxk0rw A2F7IY1VAKz4vEj48ve4kI8wA2z4x0Y4vE2Ix0cI8IcVAFwI0_Xr0_Ar1l84ACjcxK6xII jxv20xvEc7CjxVAFwI0_Cr0_Gr1UM28EF7xvwVC2z280aVAFwI0_Cr1j6rxdM28EF7xvwV C2z280aVCY1x0267AKxVW0oVCq3wAS0I0E0xvYzxvE52x082IY62kv0487Mc02F40EFcxC 0VAKzVAqx4xG6I80ewAv7VACjcxG62k0Y48FwI0_Jr0_Gr1lYx0E2Ix0cI8IcVAFwI0_Jr 0_Jr4lYx0Ex4A2jsIE14v26r4j6F4UMcvjeVCFs4IE7xkEbVWUJVW8JwACjcxG0xvY0x0E wIxGrwCY02Avz4vE14v_GF4l42xK82IYc2Ij64vIr41l4I8I3I0E4IkC6x0Yz7v_Jr0_Gr 1lx2IqxVAqx4xG67AKxVWUJVWUGwC20s026x8GjcxK67AKxVWUGVWUWwC2zVAF1VAY17CE 14v26r126r1DMIIYrxkI7VAKI48JMIIF0xvE2Ix0cI8IcVAFwI0_Jr0_JF4lIxAIcVC0I7 IYx2IY6xkF7I0E14v26r1j6r4UMIIF0xvE42xK8VAvwI8IcIk0rVWrZr1j6s0DMIIF0xvE x4A2jsIE14v26r1j6r4UMIIF0xvEx4A2jsIEc7CjxVAFwI0_Gr0_Gr1UYxBIdaVFxhVjvj DU0xZFpf9x07jV1vsUUUUU= X-CM-SenderInfo: p1dqw3xlh2x3gn0dqz5rrqw2lrqou0/ Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org copy_to_user() returns the amount left to copy, it should return -EFAULT if copy to user failed. Signed-off-by: Tiezhu Yang --- arch/riscv/kernel/signal.c | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/arch/riscv/kernel/signal.c b/arch/riscv/kernel/signal.c index 65942b3..2238fc5 100644 --- a/arch/riscv/kernel/signal.c +++ b/arch/riscv/kernel/signal.c @@ -67,7 +67,7 @@ static long save_fp_state(struct pt_regs *regs, fstate_save(current, regs); err = __copy_to_user(state, ¤t->thread.fstate, sizeof(*state)); if (unlikely(err)) - return err; + return -EFAULT; /* We support no other extension state at this time. */ for (i = 0; i < ARRAY_SIZE(sc_fpregs->q.reserved); i++) { @@ -140,8 +140,12 @@ static long setup_sigcontext(struct rt_sigframe __user *frame, { struct sigcontext __user *sc = &frame->uc.uc_mcontext; long err; + /* sc_regs is structured the same as the start of pt_regs */ err = __copy_to_user(&sc->sc_regs, regs, sizeof(sc->sc_regs)); + if (unlikely(err)) + return -EFAULT; + /* Save the floating-point state. */ if (has_fpu) err |= save_fp_state(regs, &sc->sc_fpregs); -- 2.1.0